From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2E91A04C4; Wed, 20 Nov 2019 23:02:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F28227D; Wed, 20 Nov 2019 23:02:07 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 331A3271 for ; Wed, 20 Nov 2019 23:02:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574287325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ERqmIbvyPh3Od5IqKJsly4LuU/d3uJ7CSkdr6Gch7s=; b=fwhUoMgwcbUzevzubGPs+h3rN8WLe+0Z/AFJfrY8tBVBJ1+ey6QMKpZ3ts+qXBaSA4itzX IzrbFS2vsyVIUORNreK9DV+fSsAdCklYkF6GAuz0vRty8rEHrD5VXJTkUyorlcz7/J+veJ xZl1/94fyTNzag+DW3mNQk6XjsCIrTs= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-151-b64QV8VCMBOQMO36947O9w-1; Wed, 20 Nov 2019 17:02:04 -0500 Received: by mail-ua1-f72.google.com with SMTP id d22so302946ual.1 for ; Wed, 20 Nov 2019 14:02:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aZl8ESACWlbEH4LleEGMt88jAr9P6F/ovONTAlriht4=; b=dE3XCeLSB3FV1EKzHrwNb9kLjV6FhIbROPUPG2qO70C97hV32MJz5B8lIcCA+Q+Txa sotvj4sWPr2YRGfgb7Z1+JVJqzqi1Gg9KkMBuNOteyil3+GuyWon59e18vn9tLjkpbe0 SjTAwy2VIDYKihxRlmgJLwWfsIEVtheu5kCcnE4mdSdFxd0uflnG6Tbu4XZpZIcQDMvF FsgTW6DgDF6Qt5WFitsTrKxFlCKNmUV6qxkpCgf5tWKkzmvsFQGLV61zxXMCgl3DApN/ sbcCbDuhFaYwDp8QKVZzxW2WfNQCQPxfj18mqjzKIYnAyZ6Y9Pj355YwfYid9qpoNJWd nl0A== X-Gm-Message-State: APjAAAVYeZ+4IUVxucNt8K8eT6JHL2yAVijrD/AwraBAh89BBddeP+dZ 1/sj6+e8p6+Lsx8YeGg66e8SyNkilyaCA1ANSIjuLulTALpWSB1pLmsPmCp0xuUQkApuLRbL1qa /If5SOD9LVQiPWvONcT8= X-Received: by 2002:a9f:318b:: with SMTP id v11mr3558323uad.41.1574287323321; Wed, 20 Nov 2019 14:02:03 -0800 (PST) X-Google-Smtp-Source: APXvYqw7HeGXNm8YdzWGjcEVUKKc5MVB+EHXPACL6n16yeHoYLgmDUZ/SQTGCiejFwwZXgUwsScK4kk6ISBGC2eOvog= X-Received: by 2002:a9f:318b:: with SMTP id v11mr3558284uad.41.1574287322722; Wed, 20 Nov 2019 14:02:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 20 Nov 2019 23:01:51 +0100 Message-ID: To: Anatoly Burakov Cc: dev , Thomas Monjalon X-MC-Unique: b64QV8VCMBOQMO36947O9w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v8 01/12] config: change ABI versioning to global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 8:51 PM David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:23 PM Anatoly Burakov > wrote: > > > > From: Marcin Baran > > > > As per new ABI policy [1], all of the libraries are now versioned using > > one global ABI version. Stable libraries use the MAJOR.MINOR ABI > > version for their shared objects, while experimental libraries > > use the 0.MAJORMINOR convention for their versioning. > > Experimental library versioning is managed globally. Changes in this > > patch implement the necessary steps to enable that. > > The next patch just removes the config entry CONFIG_RTE_MAJOR_ABI > while this patch entirely removes its usage. > I squashed patch 2 in patch 1 and added its commitlog here. > > > > > [1] https://doc.dpdk.org/guides/contributing/abi_policy.html > > > > Signed-off-by: Marcin Baran > > Signed-off-by: Pawel Modrak > > Signed-off-by: Anatoly Burakov > > Acked-by: Bruce Richardson > > [snip] > > > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk > > index 4df8849a08..3b318a5306 100644 > > --- a/mk/rte.lib.mk > > +++ b/mk/rte.lib.mk > > @@ -11,20 +11,16 @@ EXTLIB_BUILD ?=3D n > > # VPATH contains at least SRCDIR > > VPATH +=3D $(SRCDIR) > > > > -ifneq ($(CONFIG_RTE_MAJOR_ABI),) > > -ifneq ($(LIBABIVER),) > > -LIBABIVER :=3D $(CONFIG_RTE_MAJOR_ABI) > > -endif > > +ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),) > > +LIBABIVER :=3D $(shell cat $(RTE_SRCDIR)/ABI_VERSION) > > +else > > +# EXPERIMENTAL ABI is versioned as 0.major+minor, e.g. 0.201 for 20.1 = ABI > > +LIBABIVER :=3D 0.$(shell cat $(RTE_SRCDIR)/ABI_VERSION | td -d '.') > > s/td/tr/ > > Will fix while applying. On this part again, for ethtool example library, this triggers a warning since ABI_VERSION does not exist in this example source directory. diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 94a80e024..655a1b143 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -13,7 +13,7 @@ VPATH +=3D $(SRCDIR) ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),) LIBABIVER :=3D $(shell cat $(RTE_SRCDIR)/ABI_VERSION) -else +else ifeq ($(LIBABIVER),) # EXPERIMENTAL ABI is versioned as 0.major+minor, e.g. 0.201 for 20.1 ABI LIBABIVER :=3D 0.$(shell cat $(RTE_SRCDIR)/ABI_VERSION | tr -d '.') endif In the patch removing LIBABIVER, I let examples/ethtool/lib/Makefile untouc= hed. With this, an external library manages its ABI version. --=20 David Marchand