From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A68C845C85; Tue, 5 Nov 2024 09:32:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7733E4025D; Tue, 5 Nov 2024 09:32:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 008D3400EF for <dev@dpdk.org>; Tue, 5 Nov 2024 09:32:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730795574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kCzyyxkIEpceho1wnJYY5wHqEmvwNZ/sDAtAjQEXCsg=; b=ZWVjGi3QaAwEnb9VLtvjwTYKZtQeBIbfafa+MjiKcJnzK74CW6L6zOM2AWqLRBBAqSQYFh sD8GIfv0q3y0HwHVhr3prOlhARjMM1Zki0CVvdBeGWyobo9JXJHfoHl+wpLNOYZxtwjlFp u1sJNrHkVhlzjdISP+TlN1GUZ5VmXCo= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-Ows545CGNVSbZSjt7fW9tQ-1; Tue, 05 Nov 2024 03:32:51 -0500 X-MC-Unique: Ows545CGNVSbZSjt7fW9tQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539fbbadca7so4805689e87.3 for <dev@dpdk.org>; Tue, 05 Nov 2024 00:32:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730795570; x=1731400370; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kCzyyxkIEpceho1wnJYY5wHqEmvwNZ/sDAtAjQEXCsg=; b=khVqh70XV9RieS8TIo5eni6iDxeWkQOwcia+RgUcYXiajLElX2XZWyXafH1gNtzTUH hkV534r9PhiA2MXSO7YHzr/49wfLdNOsS1XEdXdpr3uh78NCDFe9CVpGQWAp77MqWcdT aVvuZitl6bN6ybRG7p/oFrDXTOiGVLS8D6fbgMToMFJD+g3klaRpp8cwOt8Nk9ITGpq9 QO5HiW97v7OefaJ/5AeoI5jy+w0FEHk/5ztJ4sSAmTpVplT6IkHSmv1cwisk5Shl/6kG c6hlfdYxFzs+wxxb/7k8jknDZJA746cZhdaWR9eYRsCQ/MyVimpKpnD5p66u0m8O6kaU plVw== X-Forwarded-Encrypted: i=1; AJvYcCW8TffTaSjAcIAObBVUErpvBCx8/pC/Ut0xKN/DkGIAfb/dbzQ79zkfM3WY1mHJccQIsNM=@dpdk.org X-Gm-Message-State: AOJu0YxIsVJSe7xb16R+OGxQUBmFiQx92nWK/4v9udFZk4pzp4c4Hgtr AThQAVtp9bf9jz7O6o6zT92ngt2Ae2bumlQqRMhZvCJr7U8MDoRg3NoFG0VVcTca4dImRz9Oh+o csZ8stJFgMNtpULaKqNjUL60LcaeLaDnpEeC8jaXJpinOPvGqUr0LwheSmS4OoGwt5P5xhv+rmx Qf1LfmevhsEY5gMG0= X-Received: by 2002:a05:6512:3a8a:b0:53b:4bc0:72aa with SMTP id 2adb3069b0e04-53c79e4d45emr9016371e87.34.1730795569588; Tue, 05 Nov 2024 00:32:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8JVn0ma1Jm3NV0mf8IFbFbo/OK1U4L7EZTqsFhFeIAPb3m83MUYSO0p2Mbsbj6LfFRCn+2vNbzcn4NkDPxBg= X-Received: by 2002:a05:6512:3a8a:b0:53b:4bc0:72aa with SMTP id 2adb3069b0e04-53c79e4d45emr9016302e87.34.1730795567694; Tue, 05 Nov 2024 00:32:47 -0800 (PST) MIME-Version: 1.0 References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1730776553-31277-1-git-send-email-andremue@linux.microsoft.com> <1730776553-31277-19-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1730776553-31277-19-git-send-email-andremue@linux.microsoft.com> From: David Marchand <david.marchand@redhat.com> Date: Tue, 5 Nov 2024 09:32:36 +0100 Message-ID: <CAJFAV8yTL_+YUYO8Rz2_OUgYz1eCU-74=rvDgakmHnLbUat9GA@mail.gmail.com> Subject: Re: [PATCH v4 18/19] test: remove use of VLAs for Windows built code in bitset tests To: Andre Muezerie <andremue@linux.microsoft.com> Cc: stephen@networkplumber.org, aman.deep.singh@intel.com, anatoly.burakov@intel.com, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, dev@dpdk.org, dmitry.kozliuk@gmail.com, dsosnowski@nvidia.com, fanzhang.oss@gmail.com, fengchengwen@huawei.com, ferruh.yigit@amd.com, gakhil@marvell.com, harry.van.haaren@intel.com, hkalra@marvell.com, honnappa.nagarahalli@arm.com, hujiayu.hu@foxmail.com, jingjing.wu@intel.com, kevin.laatz@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, pallavi.kadam@intel.com, reshma.pattan@intel.com, roretzla@linux.microsoft.com, sameh.gobriel@intel.com, suanmingm@nvidia.com, thomas@monjalon.net, vfialko@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Nov 5, 2024 at 4:19=E2=80=AFAM Andre Muezerie <andremue@linux.microsoft.com> wrote: > > MSVC does not support VLAs, replace VLAs with standard C arrays > or alloca(). alloca() is available for all toolchain/platform > combinations officially supported by DPDK. This commitlog does not reflect what is being changed in the patch. > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com> gcc 13 (at least) complains about this patch. https://github.com/ovsrobot/dpdk/actions/runs/11677008675/job/32514228727#s= tep:12:3658 I suspect you may have to change some "static" bitset into a dynamically allocated one. --=20 David Marchand