Re: If feeling bored

[David Marchand <david.marchand@redhat.com>]

On Tue, Sep 12, 2023 at 5:46 PM Morten Brørup <mb@smartsharesystems.com> wrote:
> RTE_LIBRTE_xxx seems redundant. There are still a bunch of those in DPDK, which could be replaced by RTE_xxx.
>
> Cleaning up this will probably break the API.

If we exclude config/ doc/ and any rte_.*.h header, we should be good?

$ for pattern in $(git grep -o 'RTE_LIBRTE_[A-Z0-9_]*' ':^**/rte**.h'
':^config/' ':^doc/'); do file=${pattern%%:*}; symbol=${pattern##*:};
! git grep -wq $symbol '**/rte**.h' config/ doc/ || continue; sed -i
-e "s/$symbol/${symbol##RTE_LIB}/g" $file; done
$ git diff --stat
...
 135 files changed, 437 insertions(+), 437 deletions(-)

$ ninja -C build
...


There are still some exposed defines but it is a first move forward.
$ git grep RTE_LIBRTE_ | wc
    306    1010   22337



-- 
David Marchand