From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B51104257F; Tue, 12 Sep 2023 19:50:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DC4B40293; Tue, 12 Sep 2023 19:50:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E643340289 for ; Tue, 12 Sep 2023 19:50:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694541017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fsbpxxgYpNZGV7Ejm8C+0Iy1GPSXXbEbp/PhsLZYmmQ=; b=YZjUHQ5j8bgreN1Ig50to/gINGQCYU08ZyOb4P92A98yNl/Mj7CnAR+oFpLOtg1n73yW7d e2wi+oMaO6dtkuka3iW6tUt9kcroF1vejwwYSkhOC1wQpeHRTUWJVdM2hqKkwTXGV/yQIf +QkKA4s1ku7jdvAT7i6K7LbRZ+kmodQ= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-OiqZTStzOIyhHEeWyLSyAw-1; Tue, 12 Sep 2023 13:50:15 -0400 X-MC-Unique: OiqZTStzOIyhHEeWyLSyAw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2be58d1b2a0so67141561fa.1 for ; Tue, 12 Sep 2023 10:50:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694541014; x=1695145814; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fsbpxxgYpNZGV7Ejm8C+0Iy1GPSXXbEbp/PhsLZYmmQ=; b=s25qq3dtnufKEbJAT4UIRu+gVr1GBq3L+GF8k8QrcoLyHpqRt//T7rxhxdlI8a1icW IiOJl+eh5S3ATd7n+4kIQU45QHB0l7HAOXuh7jpTbBaHZpHS5sJ0VxqfJAlsRByskMst bAa9ML/C358ANyeB/JvXUeQn9nYNTiycYgDGVv0JJfOkSb0/JdWarMIikx5JzkIcHsq9 9enVWS26zTuM56UQ2cZcwLkzjALLabEK5YXvElX+lP+Z+2ehWSPqPFqWzhB+QKpEtzcj 15ngy0abOfXDaK+OQNGGTYRXUGDKa6+Gvs9qsn2zXfR2FRiXMZ2WBT7I1kmPWXfkL4ov wnmA== X-Gm-Message-State: AOJu0Yw9ezJRTxgH5Dq0rR3m+5OF3gj2N1ijPfZp7n+IY9sANPZNdZIa zQyYlqDkJZoruswXFqTyZ5H2phSksdZ0LBxukYK3pEsZIg0srbduaJdc38mrRu8FMhkmW7IW37D CUqzRnSjYtPKvpO5FUAQ= X-Received: by 2002:a2e:2c12:0:b0:2bc:b224:98ac with SMTP id s18-20020a2e2c12000000b002bcb22498acmr416702ljs.31.1694541014303; Tue, 12 Sep 2023 10:50:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgh7/JTf+u/x5UXkFmbySB1XKavLvLUhXmNiqAg3EqbbElwvfq1PZhsmCnUG8umuNYtGD60Q24Loywg/lPzSc= X-Received: by 2002:a2e:2c12:0:b0:2bc:b224:98ac with SMTP id s18-20020a2e2c12000000b002bcb22498acmr416693ljs.31.1694541013961; Tue, 12 Sep 2023 10:50:13 -0700 (PDT) MIME-Version: 1.0 References: <98CBD80474FA8B44BF855DF32C47DC35D87BA7@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87BA7@smartserver.smartshare.dk> From: David Marchand Date: Tue, 12 Sep 2023 18:50:02 +0100 Message-ID: Subject: Re: If feeling bored To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 12, 2023 at 5:46=E2=80=AFPM Morten Br=C3=B8rup wrote: > RTE_LIBRTE_xxx seems redundant. There are still a bunch of those in DPDK,= which could be replaced by RTE_xxx. > > Cleaning up this will probably break the API. If we exclude config/ doc/ and any rte_.*.h header, we should be good? $ for pattern in $(git grep -o 'RTE_LIBRTE_[A-Z0-9_]*' ':^**/rte**.h' ':^config/' ':^doc/'); do file=3D${pattern%%:*}; symbol=3D${pattern##*:}; ! git grep -wq $symbol '**/rte**.h' config/ doc/ || continue; sed -i -e "s/$symbol/${symbol##RTE_LIB}/g" $file; done $ git diff --stat ... 135 files changed, 437 insertions(+), 437 deletions(-) $ ninja -C build ... There are still some exposed defines but it is a first move forward. $ git grep RTE_LIBRTE_ | wc 306 1010 22337 --=20 David Marchand