From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38500A32A8 for ; Sat, 26 Oct 2019 16:43:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 996541BF7F; Sat, 26 Oct 2019 16:43:29 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id BFF6B1BF60 for ; Sat, 26 Oct 2019 16:43:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572101006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dh1L46XNLyjwYeMP4rHTTO319WXTQQ8Z1mYYSPQrJkU=; b=iWsmmsMxi+5A6Nu06c6GuKyeljhB5frHHfzbl93moYcji2DC1CYKFDc8jMWC/zEYNmiKTW aAcT/MpZPFIvORzKUIFy3Il+7Oww1AOqkLyJcme+S87vR1Tl9GuWf0QTfKfRQgctI2MN16 YnTREEJZm7PdkcTGF+aa7Dc7Up4nXgY= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-tqnWyiGKP02BS5bWEbQhFQ-1; Sat, 26 Oct 2019 10:43:23 -0400 Received: by mail-vk1-f200.google.com with SMTP id a188so1818261vkc.7 for ; Sat, 26 Oct 2019 07:43:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CAEDLXIOJP6VwG2p3d+JaLoXBIPi9Ggk29mP8G3NqbE=; b=SRyqXD9ycwCkB9Ic9M+JqY/lAVzuegcdwW/bfxTRYQCfK14gNk/fp66BwhmgzJ7R3Q IauPlQ9ke4rwhJ+r8ehmjTlo9zC1RWF2oWpjBz4mjYDVWS5YQ57pb2Gd/GdwkXMe35p4 rWRsXVdSGTCPzXnqGP6oAjf3rwgCJN8vlF50fBaVpcMYj3nljA+BBuWqxDfvMfb1ahie ZL/NvTyMS2o9UgEyKhZGv3xSDvXG90eqqRASR4sntoGg9o8AotgCUNlenwpNi2EuPO6e 47wlerhx1n06j3XgBkTnBu2NKnHAxaOMbpXxVgBOk+xHEQNgpvfSy7I+pKqJmOjzqHC5 Kr3A== X-Gm-Message-State: APjAAAVGOVw/h0Nqb9nD1GiK5mIvabomK5CzT/qJ/MlpaO1U8+prp8Vh 29uLRpMNrtDuW+YdNlCW6ApP8/ei/oTjkdSbuTN00eA/wKltzze0kl3WGx/n4VMxB3oS5DkmYMm wqIq9aAdHP0oXXAJo6vE= X-Received: by 2002:ab0:304e:: with SMTP id x14mr4449485ual.41.1572101002799; Sat, 26 Oct 2019 07:43:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqyUxPDaQBRrj7da+tkXbKtrcYRUxKsOhwF8wm2RhN7a65WCsPxs60Cn1QHtmLXLEanv0LdPAPavtuj6vgpXmQk= X-Received: by 2002:ab0:304e:: with SMTP id x14mr4449472ual.41.1572101002388; Sat, 26 Oct 2019 07:43:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Sat, 26 Oct 2019 16:43:11 +0200 Message-ID: To: Ziyang Xuan , Xiaoyun Wang Cc: dev , shahar.belkar@huawei.com, luoxianjun@huawei.com, tanya.brokhman@huawei.com, Ferruh Yigit X-MC-Unique: tqnWyiGKP02BS5bWEbQhFQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 00/15] A new net PMD - hinic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 27, 2019 at 4:26 PM Ferruh Yigit wrote= : > > On 6/27/2019 9:10 AM, Ziyang Xuan wrote: > > This patch set adds support of a new net PMD > > for Huawei Intelligent nic. This patch provides supoort > > for basic RX/TX and the contorl path needed for it. > > Later on new features will be added like VLAN, VFs, etc. > > > > Basic features: > > 1. Basic device operations: probe, initialization, start/stop, > > configure, info get. > > 2. RX/TX queue operations: setup/release, start/stop. > > 3. RX/TX. > > > > Stats: > > 1. statistics and extended statistics. > > > > --- > > v2: > > - Fix arm64 compilation issue. > > - Fix some checkpatch checks issues > > - Fix patches thread issue. > > - Fit to the newest rte_ prefix patch > > > > v3: > > - Remove Rami from hinic pmd maintainers > > - Remove hinic_logs.* files and move log codes to other files > > - Remove the C++ guards within hinic pmd codes > > - Remove variable related errors shields from compilation files > > - Use lib link statu related functions but selfdefined > > - Fix x86_64-native-linuxapp-clang compilation errors > > - Fix i686-native-linuxapp-gcc compilation errors > > > > v4: > > - Update doc hinic.ini and hinic.rst > > - Remove x86-32, i686, BSD, Power8, ARMv7 compilations > > - Fit to newest IPV4 and IPV6 uppercase > > > > v5: > > - Update doc hinic.rst and release_19_08.rst > > - Delete unused codes > > - Optimize arch of codes and delete unnecessary files > > - Remove rte_panic > > - Subdivided patches > > > > v6: > > - Adjust hinic pmd maintainers > > - Use "CONFIG_RTE_ARCH_X86_64" to determine X86_64 for SSE instruction > > - Fix "check-git-log.sh" checking errors > > - Move "hinic_pmd_ethdev.h" to patch 11/15, and > > "hinic_pmd_rx.h"/"hinic_pmd_tx.h" to patch 12/15 > > > > Ziyang Xuan (15): > > net/hinic/base: add HW registers definition > > net/hinic/base: add HW interfaces of bar operation > > net/hinic/base: add API command channel code > > net/hinic/base: add support for cmdq mechanism > > net/hinic/base: add eq mechanism function code > > net/hinic/base: add mgmt module function code > > net/hinic/base: add code about hardware operation > > net/hinic/base: add NIC business configurations > > net/hinic/base: add context and work queue support > > net/hinic/base: add various headers > > net/hinic: add hinic PMD build and doc files > > net/hinic: add device initailization > > net/hinic: add start stop close queue ops > > net/hinic: add Rx/Tx package burst > > net/hinic: add RSS stats promiscuous ops > > For series, > Reviewed-by: Ferruh Yigit > > Series applied to dpdk-next-net/master, thanks. > > > This is first PMD from Huawei, welcome to dpdk, thanks for your efforts. This driver is explicitely disabled for FreeBSD with the make build framewo= rk. But I am getting a build error with meson on FreeBSD. ninja -C build-gcc-static ninja: Entering directory `build-gcc-static' [660/1372] Compiling C object 'drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o'. FAILED: drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o ccache gcc -Idrivers/net/hinic/base/12a4447@@hinic_base@sta -Idrivers/net/hinic/base -I../drivers/net/hinic/base -I. -I../ -Iconfig -I../config -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_ethdev -I../lib/librte_ethdev -Ilib/librte_net -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring -I../lib/librte_ring -Ilib/librte_meter -I../lib/librte_meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/bsd -Ilib/librte_pci -I../lib/librte_pci -Ilib/librte_hash -I../lib/librte_hash -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -march=3Dnative -Wno-format-truncation -MD -MQ 'drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o' -MF 'drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o.d' -o 'drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o' -c ../drivers/net/hinic/base/hinic_pmd_cmdq.c In file included from ../drivers/net/hinic/base/hinic_pmd_cmdq.c:5:0: ../drivers/net/hinic/base/hinic_compat.h: In function 'hinic_mutex_lock': ../drivers/net/hinic/base/hinic_compat.h:263:9: error: implicit declaration of function 'pthread_mutex_consistent'; did you mean 'pthread_mutex_init'? [-Werror=3Dimplicit-function-declaration] (void)pthread_mutex_consistent(pthreadmutex); ^~~~~~~~~~~~~~~~~~~~~~~~ pthread_mutex_init ../drivers/net/hinic/base/hinic_compat.h:263:9: error: nested extern declaration of 'pthread_mutex_consistent' [-Werror=3Dnested-externs] cc1: all warnings being treated as errors Please fix or disable compilation. Thanks. --=20 David Marchand