From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6501AA00BE; Tue, 7 Jul 2020 13:16:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 454501DDDB; Tue, 7 Jul 2020 13:16:57 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id A44C11D6DF for ; Tue, 7 Jul 2020 13:16:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594120615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yyyzjja31+wQthQO3hJOTpOwSW9jlVT9BMcQHoKfMvI=; b=AIGnOYskXVZG1LgVi3+5MhZHnOcRALnJGN0r7P6GFL3nmMmxCCoe4sGOPRq39uroeDUOzM SZBm+qnVcdhIdzKdjghz8g1BwwgZRL+D87VNkNvmJciXGdo+aFyqpGMIa4z8vHZ6xpxVbz 73m2jF432X4soEw6S8R2gKVyFmopi2w= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-WzjKJs4lPuWBghTx9rPuGw-1; Tue, 07 Jul 2020 07:16:53 -0400 X-MC-Unique: WzjKJs4lPuWBghTx9rPuGw-1 Received: by mail-vk1-f197.google.com with SMTP id n129so7758306vkn.0 for ; Tue, 07 Jul 2020 04:16:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yyyzjja31+wQthQO3hJOTpOwSW9jlVT9BMcQHoKfMvI=; b=HeJr5ZGVS8koZL92yzqVJZoIBJ7MbovIceeI/6xV2Q8dErMRLPqTf+0lGNnViYV7ag vORLGsT76TQQfV+Enuvf1GyKjLprg8xbg+SAQaRYNHJs4KNu1upPdtm+Hom1zSJT+lea TXxIjz6mUIAFTcYIABXTwjJkjMtNyyThlJDJoIanTFuWrZmD5nQgNc7R+5JZVRxxLHHD lmznX+2noYFRmcBvqh9GILANrxvYeZvGtifZecasvlcM5zKf8ex114m2aC0P2LrEWICX lnPZZqO4dUSfGlqsoJfY5dw8R7DesxlXmscGG1cQPZlwoXTvFTIWZrdCg5mvhqC0t6XM 8PIw== X-Gm-Message-State: AOAM532qm1vw3pAaCQGdt2xExGjl50p8Pk+ZUDi+KDkYj0BZB2AIkjU5 vsUEkZ1gR99GAX0vqI21f9q4orFTK1UB6owMq9wpxRIpLOxeQMTFdYSGwYA3TG22TOII1XMvLag iL1W7pQKiTCstkD6YcoI= X-Received: by 2002:a9f:27e6:: with SMTP id b93mr37147742uab.126.1594120613014; Tue, 07 Jul 2020 04:16:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCUyS1gcVdjatpWP6gYElc8MukOldXpzrg4lth61E4uyccd6PUCPE2nee9rRKSGe+Mk811v+DEq7WEbYtjCmc= X-Received: by 2002:a9f:27e6:: with SMTP id b93mr37147718uab.126.1594120612815; Tue, 07 Jul 2020 04:16:52 -0700 (PDT) MIME-Version: 1.0 References: <20200608213417.9764-1-honnappa.nagarahalli@arm.com> <20200626203502.20658-1-honnappa.nagarahalli@arm.com> In-Reply-To: <20200626203502.20658-1-honnappa.nagarahalli@arm.com> From: David Marchand Date: Tue, 7 Jul 2020 13:16:41 +0200 Message-ID: To: Honnappa Nagarahalli Cc: dev , Jerin Jacob Kollanukkaran , Hemant Agrawal , Akhil Goyal , ogerlitz@mellanox.com, Ajit Khaparde , Pavan Nikhilesh , nd , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/arm: generic counter based loop for CPU freq calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 26, 2020 at 10:35 PM Honnappa Nagarahalli wrote: > > get_tsc_freq uses 'nanosleep' system call to calculate the CPU > frequency. However, 'nanosleep' results in the process getting > un-scheduled. The kernel saves and restores the PMU state. This > ensures that the PMU cycles are not counted towards a sleeping > process. When RTE_ARM_EAL_RDTSC_USE_PMU is defined, this results > in incorrect CPU frequency calculation. This logic is replaced > with generic counter based loop. > > Bugzilla ID: 450 > Fixes: f91bcbb2d9a6 ("eal/arm: use high-resolution cycle counter") > Cc: stable@dpdk.org > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > Reviewed-by: Dharmik Thakkar > Reviewed-by: Phil Yang > Acked-by: Jerin Jacob Series applied, thanks. -- David Marchand