From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9B9241C49; Thu, 9 Feb 2023 09:31:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9FF640EDC; Thu, 9 Feb 2023 09:31:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3FADF40DF8 for ; Thu, 9 Feb 2023 09:31:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675931483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7zmSpakTIWsm4uuBm7bHOWxsYjWZXpt4jIc+SgyLw/U=; b=O1hoMYGYW5SgfMMnBP7yM2f6kF5+2F4LcG+r7yKiGGUnyeIjTtcYLwqPnaQfirZqxbk3NT R0x+DsV7loN4UpiRdkxNFt/KIDx/NieNRfCdNP/Kx4uULgPBTXU0qQcwclWSNHV3gFPIRd vIcOi1pd+zZyTKxVo6YJJAUoQxZ7eiM= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-46-9l_C9NR5OmCnZ_NbIzMIQg-1; Thu, 09 Feb 2023 03:31:22 -0500 X-MC-Unique: 9l_C9NR5OmCnZ_NbIzMIQg-1 Received: by mail-pl1-f198.google.com with SMTP id jb5-20020a170903258500b00199226cbbdeso934652plb.19 for ; Thu, 09 Feb 2023 00:31:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7zmSpakTIWsm4uuBm7bHOWxsYjWZXpt4jIc+SgyLw/U=; b=0q76HfPNLX1k96LIpVYmneUOUT/iVAhNSky3C/Ec/wDedc9QhLgnPnNCU6sn9Zd3d4 3D47YJ2cAELO3VDhODLAKcrO7HaC0aqHh5dLZM0CVhGEl5kMcvQmK1FiKy/9+jo8qAuu EXxjQnnZsgdJHcmhlwUfkWdNF8vPY4O8RZgJ1gaJh4gq4Z/gEsDGXwi1hh8BaiCGNIll FHxMuXQn6oheqrmFMXw2vsOK40/Y+ec+mcsLtITOIqowot4tUg4syhuwHj8fXJjBmKij fGihJn2DZU95o0jR7ohSQS+4UNYY8DPoTO1oUgIY9D9khaYqY+FV9mWP0k2jyPaCZgi/ icKg== X-Gm-Message-State: AO0yUKWryAJxMguTY72ET8r5H/7qrx90vhK4iOciylwBqv0NprjvGshB lxQ7Eb9U82brb/QOFROgU+Qgk5GKwricOFZgKAzVBL0aXpDa+80814kQZRP600mfaI+Jfum0Awc kQQDEPwdVt03h02i0hIo= X-Received: by 2002:a17:903:41c9:b0:199:642:1c2c with SMTP id u9-20020a17090341c900b0019906421c2cmr2657283ple.33.1675931481278; Thu, 09 Feb 2023 00:31:21 -0800 (PST) X-Google-Smtp-Source: AK7set9sV7MUQjqzDAzMHhqTo4BhI5DlFX+dMC7Y+NGYlXYmzH5N634MIIuWLk6qoqd4zdrLDOO4MAIpmwvBJ9eijOM= X-Received: by 2002:a17:903:41c9:b0:199:642:1c2c with SMTP id u9-20020a17090341c900b0019906421c2cmr2657276ple.33.1675931480990; Thu, 09 Feb 2023 00:31:20 -0800 (PST) MIME-Version: 1.0 References: <20221123102612.1688865-1-rjarry@redhat.com> <20230207193731.1242505-2-rjarry@redhat.com> <3cd7617f-dbb5-9626-2db1-e6a8ce5f6376@huawei.com> <373cbd89-3efe-fc4c-2300-edead9c0808c@huawei.com> In-Reply-To: <373cbd89-3efe-fc4c-2300-edead9c0808c@huawei.com> From: David Marchand Date: Thu, 9 Feb 2023 09:31:09 +0100 Message-ID: Subject: Re: [PATCH v9 1/5] eal: add lcore info in telemetry To: "lihuisong (C)" Cc: Robin Jarry , dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Kevin Laatz , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 9, 2023 at 3:19 AM lihuisong (C) wrote: > >>> + if (info->lcore_id != lcore_id) > >> Suggest: info->lcore_id != lcore_id -> lcore_id != info->lcore_id > >> Here, info->lcore_id is a target and lcore_id is the variable to be > >> judged, right? > > Yeah that looks better. I didn't pay too much attention since this > > principle is not well respected in the current code base. > That's not a very good reason. > It's similar to "ret != 0" and "p != NULL" in DPDK coding style. I'll squash this suggestion when applying. -- David Marchand