From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39E28A034F; Thu, 14 May 2020 18:31:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 104F31DA15; Thu, 14 May 2020 18:31:02 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id A657F1D9CE for ; Thu, 14 May 2020 18:31:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589473860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+b4pvPku7YMNKEhujvQjl1bo2amVVytWsjc8Qqy7r2o=; b=PYXlFVYmg2zZ0BiAoaw4vYAewyQgLepXXns3Msrnt+o7TkBv8s2GbZ59l7Oja1qvo132yi n1mGbpdloksT1dTWMb3++taClmWWPVDD3BxSBmEOp7lC7fCpfy0X1fzl2NSn13M+So1RZv xZO392QRRjH+tI8tWC7nnXTEeky8+K8= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-wYfXGuZyOqiPo9m4PYj6Mw-1; Thu, 14 May 2020 12:30:45 -0400 X-MC-Unique: wYfXGuZyOqiPo9m4PYj6Mw-1 Received: by mail-vk1-f200.google.com with SMTP id y192so1551912vky.2 for ; Thu, 14 May 2020 09:30:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+b4pvPku7YMNKEhujvQjl1bo2amVVytWsjc8Qqy7r2o=; b=fe1kZdPdEQKbt1BRLjUs0ai6UQyTvEtZWmDyKEYAYZEe71tyJ+EG9+TdESo5gaZV3M wKZxrEtaqFDrYBIE00s0rMsXWxJAvY0zn52EpLD8RpEQPb7BJ6NcIaAJHh1J6ZN1Fewf yOCsizzlSQoSIU2ayjd+Z8OHNwaInVxutUhcb9hkARvhGACfr9kVLAkd8DzlB4rhxzKP Ngqq+6V7/YcKGUwCPVGtqOWJPzsOjaljngyVYXbLdm3M+0dX4isaKMRXBbJDuG608UrV jb9Ld0CLiJ9JDZ75Zi9bQeyn3ZUvQlUpmR4kENE7qf1TUEmLwGN8Xc1k2iaKp9Gc3ylK 9SqA== X-Gm-Message-State: AOAM531wiS75dvsrrTW2M8qKPlDmyDSGmLFWMVQSWnuz8VWJ1vCnnXiF pDx5Ne1l8emFPOhkrdwyGS/HacTJykNXh76f7YF+7qTAnq1G2NTlC5c9BvfETFomFUdOBgLbfXQ A6p19jpsPEhHnr3ngAEU= X-Received: by 2002:a1f:2e16:: with SMTP id u22mr4261438vku.12.1589473845399; Thu, 14 May 2020 09:30:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfZE9Lf1bnLP6B4cxia56hFzbEyPezhfaWOjnzsz+E9lb9QNP9CbBJRKStUUgfImd1NgnJPdxNSa/dJopwXMc= X-Received: by 2002:a1f:2e16:: with SMTP id u22mr4261409vku.12.1589473845144; Thu, 14 May 2020 09:30:45 -0700 (PDT) MIME-Version: 1.0 References: <20200513121149.2283385-1-ferruh.yigit@intel.com> <20200514115236.3293364-1-ferruh.yigit@intel.com> <29137948-49d4-0dfd-a030-3f084dafd99b@intel.com> In-Reply-To: <29137948-49d4-0dfd-a030-3f084dafd99b@intel.com> From: David Marchand Date: Thu, 14 May 2020 18:30:34 +0200 Message-ID: To: Ferruh Yigit Cc: Ray Kinsella , Neil Horman , Cristian Dumitrescu , Eelco Chaudron , dev , Thomas Monjalon , dpdk stable , Luca Boccassi , Bruce Richardson , Ian Stokes , Andrzej Ostruszka X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] meter: provide experimental alias of API for old apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 14, 2020 at 6:08 PM Ferruh Yigit wrote: > > On 5/14/2020 4:32 PM, David Marchand wrote: > > On Thu, May 14, 2020 at 1:52 PM Ferruh Yigit wrote: > >> > >> On v20.02 some meter APIs have been matured and symbols moved from > >> EXPERIMENTAL to DPDK_20.0.1 block. > >> > >> This can break the applications that were using these mentioned APIs on > >> v19.11. Although there is no modification on the APIs and the action is > >> positive and matures the APIs, the affect can be negative to > >> applications. > >> > >> Since experimental APIs can change or go away without notice as part of > >> contract, to prevent this negative affect that may occur by maturing > >> experimental API, a process update already suggested, which enables > >> aliasing without forcing it: > >> https://patches.dpdk.org/patch/65863/ > >> > >> This patch provides aliasing by duplicating the existing and versioned > >> symbols as experimental. > >> > >> Since symbols moved from DPDK_20.0.1 to DPDK_21 block in the v20.05, the > >> aliasing done between EXPERIMENTAL and DPDK_21. > >> > >> Also following changes done to enabling aliasing: > >> > >> Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > > > This helper (+ script update) must come with the process update: the > > macro is referenced in its v5 revision. > > The macro is implementation detail, and this patch does the implementation. > There is a dependency to process update patch, but that doesn't need to define > how the macro should be. This is inconsistent. The process update patch gives a clear example of how the macro must be used. -- David Marchand