From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id D7834A05D3
	for <public@inbox.dpdk.org>; Mon, 20 May 2019 10:30:44 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 9BB84569B;
	Mon, 20 May 2019 10:30:44 +0200 (CEST)
Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com
 [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 114895689
 for <dev@dpdk.org>; Mon, 20 May 2019 10:30:44 +0200 (CEST)
Received: by mail-vs1-f66.google.com with SMTP id z11so8373878vsq.9
 for <dev@dpdk.org>; Mon, 20 May 2019 01:30:43 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=r6tuHBGC9HFQToLWR1z5SkXtGfz2VUhnHQvXKxFKbJk=;
 b=HbXrkcGMQ3JwP2eF13Zd2S1uK3iiN9gaFGxOCksTKMDGS0mRU3OlYZxNdCbC72PlJl
 7dkk+v1KtMDpgkmy0R3Sme5v06RPWRRfhkENuvDFiVhm0SUXmDAi/vVVeXC87wr4Po/C
 jerqeidweV701H9WV6YPd7SrpLMm97SK4lQwoWaetwIsw8nox2JgaR3fs/UyUgZiVD7b
 wDkTYgF/4iWpGgNTKg00KM7VNXCpcr26TPhdxCj1xR3fTpl3OpnXcGzLTxdfC8Lf8FLG
 jkxsQ4j35ENow0l6ITAELtoLITHuIFM0CbBXZs/3YiTq3DD6obNLenM7ys9T7ggPCxlB
 ZVBw==
X-Gm-Message-State: APjAAAXMJgw5kBYzcMTWhxsjni42BJxoKrsYm/L2rEuBiCC5qIXL0cbN
 DId71PxPe0xCnwtCJJg+AQrZ4DjOG0xHwRlRKKIvrA==
X-Google-Smtp-Source: APXvYqz6qQ0Zqi1WJQaMVmSlNlfV1QKV5s3y27a0MiQIQoSjmgSF6lSgwgCzFRCTDQTwcfU3GN+UWDSWwjecD5EEz1c=
X-Received: by 2002:a67:ef45:: with SMTP id k5mr9314171vsr.105.1558341043488; 
 Mon, 20 May 2019 01:30:43 -0700 (PDT)
MIME-Version: 1.0
References: <20190517150613.13310-1-maxime.coquelin@redhat.com>
 <20190517150613.13310-6-maxime.coquelin@redhat.com>
In-Reply-To: <20190517150613.13310-6-maxime.coquelin@redhat.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 20 May 2019 10:30:32 +0200
Message-ID: <CAJFAV8yU0DoD3v=_aPsoM1FSuNqBL4r9tTKgwamJaCaRqkeQEQ@mail.gmail.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>, 
 Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, Tiwei Bie <tiwei.bie@intel.com>, 
 Jens Freimann <jfreimann@redhat.com>, Zhihong Wang <zhihong.wang@intel.com>, 
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 5/5] eal/x86: force inlining of all memcpy
	and mov helpers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, May 17, 2019 at 5:14 PM Maxime Coquelin <maxime.coquelin@redhat.com>
wrote:

> Some helpers in the header file are forced inlined other are
> only inlined, this patch forces inline for all.
>
> It will avoid it to be embedded as functions when called multiple
> times in the same object file. For example, when we added packed
> ring support in vhost-user library, rte_memcpy_generic got no
> more inlined.
>

Weird that we have only some functions marked as always inlined in commit:
https://git.dpdk.org/dpdk/commit/?id=1c9467a6efd8d85b5bbbf7004a4407cae2d09431

Bruce, is there a reason for this?


-- 
David Marchand