From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA3E43735; Mon, 18 Dec 2023 15:04:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 956F2402B6; Mon, 18 Dec 2023 15:04:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EA32C40282 for ; Mon, 18 Dec 2023 15:04:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702908242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Cp1M6+o3z8sB/1jEIjJ1CEYNUZFjqkurHEV7h9rBrc=; b=NFicY9bleISbhaD6OEcTNDfxB+UktvkUjxVFj84zXVa6JI8mOibWIHrhwaRwm/bvoZ85UX RbQhkyV+InJvKnhKlKfAX1VuPpR5nJnviIYGzpbZbW5+w/m2Jke3BIpLEtxLVG9hjs2IWI xjObgrXRtZokvXmolhGKMj1oMHIMVKs= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-5tgL9HKmNEiU7DRW0G6f9A-1; Mon, 18 Dec 2023 09:04:00 -0500 X-MC-Unique: 5tgL9HKmNEiU7DRW0G6f9A-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-50e186d2e54so1731260e87.0 for ; Mon, 18 Dec 2023 06:03:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702908239; x=1703513039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Cp1M6+o3z8sB/1jEIjJ1CEYNUZFjqkurHEV7h9rBrc=; b=M3O4FrhFUSPL5MbjOPth1mCuOVv7ze1/iOnrJ2nj2cGyeyHcdzqJDTKFS3rm7V8j/u iL7VL/KgNObIVdYE4XFHmiS24oJHShuNNBTe2FgxiJ1KbtMlAAROCs3mEZmUgJEaHIQL 5fjYz59AEmu9iWSWf33cuXzro29PsO/5GZpzMkqBHKz67HNh+7ThQ6BBIo60jCsbb42u DPFVNNwpCoyGhXhu3F1Ns3Romgle/32jKRjnMetsb5R9zmutmmb/xulCy3b799GWY/Ce 31YcqbV0p+OqvhpCNWS7ri3oTjdL5R7QOxEAJ41dAtpZHBmgJO/XudC7qd3OEqcLT6r2 zqnQ== X-Gm-Message-State: AOJu0Yxcx6zOUnhBXrOwKIoRIctiUaly/iJuDV8tjxatb/sRKf6UqC4y 3bEbZIOio6B4EGMu/hSNdzPXGCwbrIgK7qY3iPo+paNxl88KHakbKYjtV0yYT2q/F0qd9bYfDfe prornsnbryMM8wDyjBHLm+UlsY1Yntw== X-Received: by 2002:a05:6512:6c9:b0:50b:d341:4f6c with SMTP id u9-20020a05651206c900b0050bd3414f6cmr11825836lff.6.1702908238807; Mon, 18 Dec 2023 06:03:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/FXyl13aaCAZ71HSasghlO4beGVWa7h/gmj15RFMMyYy9+Akg+OMNFAVF8ewiKGUcOjm+2KBtj06tX1enrZs= X-Received: by 2002:a05:6512:6c9:b0:50b:d341:4f6c with SMTP id u9-20020a05651206c900b0050bd3414f6cmr11825807lff.6.1702908238253; Mon, 18 Dec 2023 06:03:58 -0800 (PST) MIME-Version: 1.0 References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213041920.729403-1-stephen@networkplumber.org> <20231213070907.0fd50f45@hermes.local> In-Reply-To: <20231213070907.0fd50f45@hermes.local> From: David Marchand Date: Mon, 18 Dec 2023 15:03:46 +0100 Message-ID: Subject: Re: [PATCH v2 00/25] Replace use of RTE_LOGTYPE_PMD To: Stephen Hemminger Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 13, 2023 at 4:09=E2=80=AFPM Stephen Hemminger wrote: > > On Wed, 13 Dec 2023 09:00:48 +0100 > David Marchand wrote: > > > On Wed, Dec 13, 2023 at 5:19=E2=80=AFAM Stephen Hemminger > > wrote: > > > > > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > > > As a first step, fix many drivers to not use it, and add a > > > helper for the RTE_LOG_DP(). > > > > I don't see why we need a new rte_log_dp helper. > > The #define RTE_LOGTYPE_XXX trick should work fine with RTE_LOG_DP(). > > What else is missing? > > The problem is RTE_LOG_DP() usage today takes suffixes. So the param > log type can only be one of the pre-defined fixed values. > > Changing the macro in one patch would be a huge patch. I am not asking for change in the RTE_LOG_DP() API. I sent a patch doing for what I had in mind: https://patchwork.dpdk.org/project/dpdk/patch/20231218135932.1497163-1-davi= d.marchand@redhat.com/ > > It seemed best to have RTE_LOG_DP() stay like RTE_LOG() > and introduce rte_log_dp() to match rte_log(). > rte_log() seems a low level API, I don't like the idea of adding another one with rte_log_dp(). And it will conflict with the cleanup I started on multiline / line with \n in logs. --=20 David Marchand