From: David Marchand <david.marchand@redhat.com>
To: Ibtisam Tariq <ibtisam.tariq@emumba.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage
Date: Thu, 18 Feb 2021 10:59:23 +0100 [thread overview]
Message-ID: <CAJFAV8yV4jGzDmMmMsowXvFRHLMCj6BOJx9-eaTDYUygWNDtUQ@mail.gmail.com> (raw)
In-Reply-To: <20210204073420.2421-1-ibtisam.tariq@emumba.com>
On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq <ibtisam.tariq@emumba.com> wrote:
>
> Instead of using getopt_long return value, strcmp was used to
> compare the input parameters with the struct option array. This
> patch get rid of all those strcmp by directly binding each longopt
> with an int enum. This is to improve readability and consistency in
> all examples.
>
> Bugzilla ID: 238
> Cc: marko.kovacevic@intel.com
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
For such a series, please provide a cover letter, this is easier when
replying on the whole series (and for me when applying).
For the series,
Reviewed-by: David Marchand <david.marchand@redhat.com>
There are still some unaligned examples (flow_classify, ip_reassembly,
kni, l2fwd-crypto, l3fwd-power, multi_process/symmetric_mp, vpda,
vmdq, vmdq_dcb), but this series is a good cleanup as is for now.
--
David Marchand
next prev parent reply other threads:[~2021-02-18 9:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 7:34 Ibtisam Tariq
2021-02-04 7:34 ` [dpdk-dev] [PATCH v4 2/7] examples/l3fwd-acl: " Ibtisam Tariq
2021-02-04 7:34 ` [dpdk-dev] [PATCH v4 3/7] examples/packet_ordering: " Ibtisam Tariq
2021-02-04 7:34 ` [dpdk-dev] [PATCH v4 4/7] examples/performance-thread/l3fwd-thread: " Ibtisam Tariq
2021-02-04 7:34 ` [dpdk-dev] [PATCH v4 5/7] examples/qos_sched: " Ibtisam Tariq
2021-02-04 7:34 ` [dpdk-dev] [PATCH v4 6/7] examples/vhost: " Ibtisam Tariq
2021-03-23 11:19 ` Maxime Coquelin
2021-02-04 7:34 ` [dpdk-dev] [PATCH v4 7/7] examples/vhost_crypto: " Ibtisam Tariq
2021-02-05 16:21 ` Zhang, Roy Fan
2021-03-23 11:27 ` Maxime Coquelin
2021-02-18 9:59 ` David Marchand [this message]
2021-02-18 10:47 ` [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: " Ibtisam Tariq
2021-02-18 11:14 ` David Marchand
2021-03-23 11:52 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yV4jGzDmMmMsowXvFRHLMCj6BOJx9-eaTDYUygWNDtUQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ibtisam.tariq@emumba.com \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).