From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDA91A054D; Thu, 18 Feb 2021 10:59:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52A0B160734; Thu, 18 Feb 2021 10:59:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 51A7C160733 for ; Thu, 18 Feb 2021 10:59:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613642381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgbtPqIgDhBEyOr8Pt/6aJBiaYwhhCXicbD2+Y1qAHA=; b=cl3Ry9kg82R9F+K9SzCEsVWxrGPmek3HC3nZkX1/Nk0G7uLREKkymDss4HmA1mtby4UTHn 4TLaie289JtSFMyWwGKga5DSc4JurlOUyOqDTcRfwgjjGqoqieRAal5CPz4UVhuwhPPZL3 kHjPf1uRNban8tT12Amd4NH7MjPq8lg= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-RNaY1YdzOLSlJ1VR2g4Bug-1; Thu, 18 Feb 2021 04:59:37 -0500 X-MC-Unique: RNaY1YdzOLSlJ1VR2g4Bug-1 Received: by mail-ua1-f70.google.com with SMTP id d9so679291uaf.18 for ; Thu, 18 Feb 2021 01:59:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OgbtPqIgDhBEyOr8Pt/6aJBiaYwhhCXicbD2+Y1qAHA=; b=tV9IYs/veStTcUOPnH/6eo9MGOVTf2+8wNeG7d/nurXurXskaicAWtMFrEvp1PqSEB aAUGlorFCgCx631m2AImu4P38UNyrO1yEU9f0NMjkABpygRTcDV6zXbcWMBWVK3AjjH1 vK0UgTG8+dLwX3TngPpnhkQVvTYiykEG/7wNPkAdZb9JjXofZROPeq4O5S/Z1i0lB3U1 90tYRKRY5dWi2+a2gwXZXyFqiNbdXDaaepMJznHHnPVYg/GOUQ7t9fQSLfNwdRkOvxm1 7QrLncuty53rjD8t4CHHw9UqEvxDGbtakxTzG73aZLRppF82BbgMEASrg+s7pE9/Bmbd 3ICQ== X-Gm-Message-State: AOAM531+TEGO+8E/vO9PKVO/1wPjEB0PmikIgLJ40H4pSKBlzz9bWuDG JPGjHq6I3+4z5BOyL5uK93krbNbJmHND8eXUpXf7KLLod8+47IxGmU56uY/uhO4PsZM53UDQqr9 YVK65dUrYPOQNGcKgZho= X-Received: by 2002:a1f:6e0f:: with SMTP id j15mr2525400vkc.18.1613642374276; Thu, 18 Feb 2021 01:59:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJyVZCpNo5qjWxOf9n4CwKUKifQe8Ws3HnHhjU+vZnDG3w+nrsp0HiW+mESOLic9OFtXLcvw/Nwcrk5uMzQAXL4= X-Received: by 2002:a1f:6e0f:: with SMTP id j15mr2525389vkc.18.1613642374060; Thu, 18 Feb 2021 01:59:34 -0800 (PST) MIME-Version: 1.0 References: <20210204073420.2421-1-ibtisam.tariq@emumba.com> In-Reply-To: <20210204073420.2421-1-ibtisam.tariq@emumba.com> From: David Marchand Date: Thu, 18 Feb 2021 10:59:23 +0100 Message-ID: To: Ibtisam Tariq Cc: Maxime Coquelin , "Xia, Chenbo" , Cristian Dumitrescu , "Singh, Jasvinder" , "Mcnamara, John" , "Pattan, Reshma" , "Ananyev, Konstantin" , "Kovacevic, Marko" , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readability and consistency in > all examples. > > Bugzilla ID: 238 > Cc: marko.kovacevic@intel.com > > Reported-by: David Marchand > Signed-off-by: Ibtisam Tariq For such a series, please provide a cover letter, this is easier when replying on the whole series (and for me when applying). For the series, Reviewed-by: David Marchand There are still some unaligned examples (flow_classify, ip_reassembly, kni, l2fwd-crypto, l3fwd-power, multi_process/symmetric_mp, vpda, vmdq, vmdq_dcb), but this series is a good cleanup as is for now. -- David Marchand