From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7A05A0A0E; Mon, 10 May 2021 16:06:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50A2940140; Mon, 10 May 2021 16:06:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 33DA54003E for ; Mon, 10 May 2021 16:06:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620655576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DQcNPMRvuxxMYSM6q7x6bqN7EGH6BQQ/nxbWs/3b1V0=; b=E9/FMceGQsp9t6OTd0VIlcgBvMUPEvGpU8dYErZ9SWvc8t9L7Brz8HJSGGohqHEeu+jUbv 36/vJlUqiyt9skDbum6hfWEdFn6iSJNvLj4DEZa7jla5ePNL5xO0rRJgRWqRf1HzCIHITu quWwIbwVQs5ltRgcWYSZyYnPOaGqwsc= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-301-gFw7Up_7PAyuRxomvUP8eA-1; Mon, 10 May 2021 10:06:12 -0400 X-MC-Unique: gFw7Up_7PAyuRxomvUP8eA-1 Received: by mail-vk1-f198.google.com with SMTP id a28-20020a056122013cb02901eb816f5778so1934653vko.10 for ; Mon, 10 May 2021 07:06:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DQcNPMRvuxxMYSM6q7x6bqN7EGH6BQQ/nxbWs/3b1V0=; b=uldx8EWHsDGl5/Q257h2e8qs61kMbZ12+ZJfxco2BN6SggdaaEJM+uLg4o0DGcHUvr hKyNjJTDfDTjbhq9uCIdXzhId/FLDfVdt9WfU/9JvpO4zMpKTye9mY7rihOkEB2cwFdG /dwerIT0c176eYamyrdsUo9W8pRyGCz56MckvXKzYaV+n2O9e47iPGnBy+1aGC4w7U3T 3vk/ceht4fqV5prcOS34f9vrkNeCExLmrywXj1CjVHAAhrk3xBgl2VEzqJfdpHFzLfW2 uigxvlMpPZJMMwbfqhmHHFbLI1NSXbhgYhKxYrVMzPSBieOQLy2nUUdV0sqB5kGQdyl0 fF+w== X-Gm-Message-State: AOAM533TrZ/rXjDja8TNoVpAkFBZ6/PRfRs/UWGSztS+x3MfS3KxKxa/ bjbIKIqh49oMOf82qUX1M+AX1HND72okQSv0ijCDzpY7QaGasH0xzCdEhotZ9ufPh3HtmrY8wm6 rRd/ZYR8S/YkpvcSiQxc= X-Received: by 2002:a67:f645:: with SMTP id u5mr19124340vso.18.1620655571728; Mon, 10 May 2021 07:06:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzGQPU8Ir77E1hN5HMQH2DSajtD4HvYaIuLqkuEdpZDus7FPBjmkmb7OyyAmkGBAbiizlF+g8t5paYQO2Mg2Q= X-Received: by 2002:a67:f645:: with SMTP id u5mr19124303vso.18.1620655571474; Mon, 10 May 2021 07:06:11 -0700 (PDT) MIME-Version: 1.0 References: <20210507172025.181720-1-kevin.laatz@intel.com> <20210510125514.12914-1-kevin.laatz@intel.com> In-Reply-To: <20210510125514.12914-1-kevin.laatz@intel.com> From: David Marchand Date: Mon, 10 May 2021 16:06:00 +0200 Message-ID: To: Kevin Laatz Cc: dev , Bruce Richardson , Sunil Pai G Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 10, 2021 at 2:55 PM Kevin Laatz wrote: > > In the function __idxd_completed_ops() we have a parameter shadow warning > due to a local variable having the same name as one of the function > parameters. This issue is fixed by simply renaming the local variable. > > This warning was discovered during an OVS build with DPDK 21.05-rc2. The > OVS build passes the -Wshadow flag by default, allowing the warning to be > seen. A bit confusing. -Wshadow only affects OVS code and there is no code calling this in the OVS master branch. I did not see this issue while updating my dpdk-latest OVS branch and running builds in GHA. So I guess Sunil caught it with his patch: https://patchwork.ozlabs.org/project/openvswitch/patch/20201023094845.35652-2-sunil.pai.g@intel.com/ -- David Marchand