DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels
@ 2020-10-02  7:54 Maxime Coquelin
  2020-10-02  8:33 ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2020-10-02  7:54 UTC (permalink / raw)
  To: dev, chenbo.xia, david.marchand, xiao.w.wang
  Cc: Maxime Coquelin, stable, Brandon Lo

VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel
headers, causing build issue.

Le's define it in IFC vDPA driver only if wasn't already.

Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc: stable@dpdk.org

Reported-by: Brandon Lo <blo@iol.unh.edu>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 drivers/vdpa/ifc/base/ifcvf.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
index a288ce57dc..573a35ffb4 100644
--- a/drivers/vdpa/ifc/base/ifcvf.h
+++ b/drivers/vdpa/ifc/base/ifcvf.h
@@ -13,7 +13,10 @@
 #define IFCVF_SUBSYS_DEVICE_ID	0x001A
 
 #define IFCVF_MAX_QUEUES		1
+
+#ifndef VIRTIO_F_IOMMU_PLATFORM
 #define VIRTIO_F_IOMMU_PLATFORM		33
+#endif
 
 /* Common configuration */
 #define IFCVF_PCI_CAP_COMMON_CFG	1
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels
  2020-10-02  7:54 [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels Maxime Coquelin
@ 2020-10-02  8:33 ` David Marchand
  2020-10-02 16:40   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2020-10-02  8:33 UTC (permalink / raw)
  To: Maxime Coquelin; +Cc: dev, Xia, Chenbo, Xiao Wang, dpdk stable, Brandon Lo

On Fri, Oct 2, 2020 at 9:54 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel
> headers, causing build issue.
>
> Le's define it in IFC vDPA driver only if wasn't already.

Let's* define it in the* IFC vDPA driver only if it* wasn't already.

>
> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> Cc: stable@dpdk.org
>
> Reported-by: Brandon Lo <blo@iol.unh.edu>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  drivers/vdpa/ifc/base/ifcvf.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
> index a288ce57dc..573a35ffb4 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.h
> +++ b/drivers/vdpa/ifc/base/ifcvf.h
> @@ -13,7 +13,10 @@
>  #define IFCVF_SUBSYS_DEVICE_ID 0x001A
>
>  #define IFCVF_MAX_QUEUES               1
> +
> +#ifndef VIRTIO_F_IOMMU_PLATFORM
>  #define VIRTIO_F_IOMMU_PLATFORM                33
> +#endif
>
>  /* Common configuration */
>  #define IFCVF_PCI_CAP_COMMON_CFG       1
> --
> 2.26.2
>

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels
  2020-10-02  8:33 ` David Marchand
@ 2020-10-02 16:40   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-10-02 16:40 UTC (permalink / raw)
  To: Maxime Coquelin
  Cc: dev, Xia, Chenbo, Xiao Wang, dpdk stable, Brandon Lo, ci, dpdklab

On Fri, Oct 2, 2020 at 10:33 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Oct 2, 2020 at 9:54 AM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
> >
> > VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel
> > headers, causing build issue.
> >
> > Le's define it in IFC vDPA driver only if wasn't already.
>
> Let's* define it in the* IFC vDPA driver only if it* wasn't already.
>
> >
> > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Brandon Lo <blo@iol.unh.edu>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Acked-by: David Marchand <david.marchand@redhat.com>

Applied directly in main to avoid noise coming from the Fedora Rawhide job.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-02 16:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02  7:54 [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels Maxime Coquelin
2020-10-02  8:33 ` David Marchand
2020-10-02 16:40   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).