From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12C8A43C5F; Wed, 6 Mar 2024 17:14:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA68D40A6D; Wed, 6 Mar 2024 17:14:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 640AD40276 for ; Wed, 6 Mar 2024 17:14:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709741670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EzRQ7kaR3RRQOwPXhmpTh6TR8++RaNQnDOZpPWyUH/c=; b=TM/uScXil16gjlk3iVD7aP2b+IM8YRMYWXFiPmPLIw5UqHtrdF1UFRJVRedl/yE0E9jboJ 6p4owcxJMf8RAQEK3gQ+RDJQtqnX6n3uZtyBFpjDflw2OrL2vMNOF0W2VhFiptjcKrKhmb pbrmQDmAEIhtQmOAIi1MNNu/AcJY9e0= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-Zr37rj6aMRq--cvJb2YoOA-1; Wed, 06 Mar 2024 11:14:29 -0500 X-MC-Unique: Zr37rj6aMRq--cvJb2YoOA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5131796a4b7so6959956e87.1 for ; Wed, 06 Mar 2024 08:14:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709741667; x=1710346467; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EzRQ7kaR3RRQOwPXhmpTh6TR8++RaNQnDOZpPWyUH/c=; b=Gfrvq25ufUnfp9LaNAbIBi05HVR7Wtpq6KjuyS1QDT3Q0/F1mlcSCl0bZ9k6ImVucc Wa+tb0KQ2WpwE530RD/FHNh8tlrgFK5dmlOeeli5F1nSpPL1Gzz8hWnkIAI28A4tC0o5 DXrNr4Ya6JzL9Hrb6P9Zrl2WC+a4XP3VhnsMtnl2cg/PTjomtLmI9AXwasYWgzV76r4U FaSp4u51GnNR2xB4kh/PgHNsGVu7D8wvLB/BAql9kaLgHPC6Qwt39LC27zcvN24ZcMMr 1AYK7vHmTgt5y1h5+OoDp0YTsRY/NVJvjUxy930d7whlFThVG23XSKFEIkO8QJ8ZTd2i 37EQ== X-Forwarded-Encrypted: i=1; AJvYcCX5K7X898m7++pWSr8LdxoduTVcgY212pYoFCqpQ4cPJXatQ0m30V/9M2umzBytd5WSN00ptO3N9HkRmCk= X-Gm-Message-State: AOJu0YwkCJF6VTIxJGXSa6Ud2RoRG0zyxmdGh2IBLYNcI1o8YKT7svcq SaTuxlK9ntN5VBgsa3kt1Ubme91ND2qBmXOAx3Y2FQIvwmAkvc+QYaKuJboThbpiYpYWomjq8aS zAbMKOCPYu3pLtRErroqni7fIzzWWVbY6Hr/bkOM+sZItp1tlAXixjRHxCCB7EJKcCEPd1Da5dq oUn6li7soeFCU8Oxs= X-Received: by 2002:ac2:554b:0:b0:513:2858:6a67 with SMTP id l11-20020ac2554b000000b0051328586a67mr2983134lfk.63.1709741667487; Wed, 06 Mar 2024 08:14:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkjWQ1/vOH3aJymsCGoPVMj+rW5FwTmQOcknGoqXheCKgUCZHY8uMyfOXLGL4rBUm0q6pBmzP9gyOmb483j2g= X-Received: by 2002:ac2:554b:0:b0:513:2858:6a67 with SMTP id l11-20020ac2554b000000b0051328586a67mr2983120lfk.63.1709741667008; Wed, 06 Mar 2024 08:14:27 -0800 (PST) MIME-Version: 1.0 References: <20240306143539.160467-1-paul.szczepanek@arm.com> <20240306143539.160467-2-paul.szczepanek@arm.com> In-Reply-To: <20240306143539.160467-2-paul.szczepanek@arm.com> From: David Marchand Date: Wed, 6 Mar 2024 17:14:15 +0100 Message-ID: Subject: Re: [RFC v1 1/1] devtools: allow libraries with no global section To: Paul Szczepanek , Bruce Richardson Cc: thomas@monjalon.net, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 6, 2024 at 3:36=E2=80=AFPM Paul Szczepanek wrote: > > If a library has no global section in the version.map > allow it not to have symbols and not report it as an error. > This happens if a library doesn't export any functions > if they're all inline. > > Signed-off-by: Paul Szczepanek Added Bruce. Having a library without any actual code compiled is (I think) new in DPDK. On the other hand, for headers only, there should be no need for a version.map file at all. The current meson code expects that every library provides some files to compile via the sources variable and it expects a version.map file too. I wonder if we could skip the whole library generation at the lib/meson.build level. Something like: diff --git a/lib/meson.build b/lib/meson.build index 179a272932..f0bbab6658 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -222,6 +222,10 @@ foreach l:libraries includes +=3D include_directories(l) dpdk_includes +=3D include_directories(l) + if sources.length() =3D=3D 0 + continue + endif + if developer_mode and is_windows and use_function_versioning message('@0@: Function versioning is not supported by Windows.'.format(name)) endif No version.map, no check to update :-) --=20 David Marchand