From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E365A04B5; Wed, 30 Sep 2020 20:49:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8D761D57A; Wed, 30 Sep 2020 20:49:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 3405F1D579 for ; Wed, 30 Sep 2020 20:49:46 +0200 (CEST) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601491784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ddxFMY19MBZqpTq0oXaJ0fEr/bcTIRhiUjOMrwYnALA=; b=K8otYpsRX5E1tqxro6oqvoXMPLLLFr86uFCd6Bsa4VOd6WH9uUb6nA1/A8BuasGVrriw/r nnaGJsVGyl60CdIyuQTz7c6hfEjToNylQMpmKEuAXvDL9a90umUMj5VKXZrQdAEXfo5jNe cVWdd+Xg78Iz575t4j+XQIgjLVoxR0o= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-461-lK7f9oO7NByRxSNz4Q89ww-1; Wed, 30 Sep 2020 14:49:42 -0400 X-MC-Unique: lK7f9oO7NByRxSNz4Q89ww-1 Received: by mail-vs1-f70.google.com with SMTP id u198so300279vsc.0 for ; Wed, 30 Sep 2020 11:49:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ddxFMY19MBZqpTq0oXaJ0fEr/bcTIRhiUjOMrwYnALA=; b=aq1WiLHW0b6vEQks8IFVCL2RLWy72+9A8iqtgCq0G6sLqlhEQdANn83ToWkXd5VBYI Lfyd3N9hZ6ElWiQ4f2+Itgmcjza1arB8cwX1EyrpISgEQWNrHpkzmZYWqv8pugTbCW21 vQmimQ6JofrOJPdYL7quS01cxlXNgUSvn9T3Gz3KzdhN6J3FbHuvYWgDUg46nGqUWkhL dK8Dj7trt0Z0a7usvV2VcpJnGvwMLV63rI4KCJ3Swvk21+grEC+zVh7DnQrxYn84s8Wi V6dDTzlmpXjeZQP0AvhTg4szef867rD7tSlQgRB93qx6rmUSC4Q8cCDtZvtHvEy/Vhqt U7ig== X-Gm-Message-State: AOAM5319HpnxDLt8wP13kaNFQsa2C+0wYQ6PBB0c3ltv5Hy1KhHKSA7a srF9pT3dnTirvfuy5FjuIoAaef2ojGJpMth4kroNENggKZYO86wAcFSGXnM18WZROVODJMcuW/7 ZAJqjBlfDPJQG8ad0GGI= X-Received: by 2002:a1f:43d0:: with SMTP id q199mr2679633vka.9.1601491781903; Wed, 30 Sep 2020 11:49:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+0pPGkBUJhSjEf5yzDVBo0BiXQU4LUDrepX+51ojFykz4ce9YsY5b5sx/5mdN3D06XO1VFqnnsQMiGVc+Dh0= X-Received: by 2002:a1f:43d0:: with SMTP id q199mr2679616vka.9.1601491781506; Wed, 30 Sep 2020 11:49:41 -0700 (PDT) MIME-Version: 1.0 References: <20200528010423.5941-1-gage.eads@intel.com> <20200528150442.321-1-gage.eads@intel.com> In-Reply-To: <20200528150442.321-1-gage.eads@intel.com> From: David Marchand Date: Wed, 30 Sep 2020 20:49:30 +0200 Message-ID: To: Gage Eads Cc: dev , Thomas Monjalon , Ray Kinsella , Neil Horman , Phil Yang , Honnappa Nagarahalli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [20.11] [PATCH v2] stack: remove experimental tag from API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 28, 2020 at 5:06 PM Gage Eads wrote: > > The stack library was first released in 19.05, and its interfaces have been > stable since their initial introduction. This commit promotes the full > interface to stable, starting with the 20.11 major version. > > Signed-off-by: Gage Eads > --- > doc/guides/rel_notes/release_20_11.rst | 3 +++ > lib/librte_stack/rte_stack.h | 29 ----------------------------- > lib/librte_stack/rte_stack_lf.h | 2 -- > lib/librte_stack/rte_stack_std.h | 3 --- > lib/librte_stack/rte_stack_version.map | 2 +- > 5 files changed, 4 insertions(+), 35 deletions(-) > > v2: > - Added 20.11 tag, will set patch status to 'Deferred' so it is skipped > for the 20.08 development period. > - Added release notes announcement. release_20_11.rst doesn't exist yet, > so I made the change to release_20_08.rst then edited the filename > directly in the patch. This will not apply cleanly. > - Changed rte_stack_version.map version to DPDK_21. > > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index 39064afbe..4eaf4f17d 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -101,6 +101,9 @@ ABI Changes > Also, make sure to start the actual text at the margin. > ========================================================= > > +* stack: the experimental tag has been dropped from the stack library, and its > + interfaces are considered stable as of DPDK 20.11. > + I would move this to the API changes section, as proposed by Thomas before. > * No ABI change that would break compatibility with 19.11. > > > diff --git a/lib/librte_stack/rte_stack.h b/lib/librte_stack/rte_stack.h > index 27ddb199e..343dd019a 100644 > --- a/lib/librte_stack/rte_stack.h > +++ b/lib/librte_stack/rte_stack.h > @@ -4,7 +4,6 @@ > > /** > * @file rte_stack.h > - * @b EXPERIMENTAL: this API may change without prior notice There is a little conflict here that git-pw/git-am seems to silently skip... > * > * RTE Stack > * > @@ -98,9 +97,6 @@ struct rte_stack { > #include "rte_stack_lf.h" > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Push several objects on the stack (MT-safe). > * > * @param s > @@ -112,7 +108,6 @@ struct rte_stack { > * @return > * Actual number of objects pushed (either 0 or *n*). > */ > -__rte_experimental > static __rte_always_inline unsigned int > rte_stack_push(struct rte_stack *s, void * const *obj_table, unsigned int n) > { > @@ -126,9 +121,6 @@ rte_stack_push(struct rte_stack *s, void * const *obj_table, unsigned int n) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Pop several objects from the stack (MT-safe). > * > * @param s > @@ -140,7 +132,6 @@ rte_stack_push(struct rte_stack *s, void * const *obj_table, unsigned int n) > * @return > * Actual number of objects popped (either 0 or *n*). > */ > -__rte_experimental > static __rte_always_inline unsigned int > rte_stack_pop(struct rte_stack *s, void **obj_table, unsigned int n) > { > @@ -154,9 +145,6 @@ rte_stack_pop(struct rte_stack *s, void **obj_table, unsigned int n) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Return the number of used entries in a stack. > * > * @param s > @@ -164,7 +152,6 @@ rte_stack_pop(struct rte_stack *s, void **obj_table, unsigned int n) > * @return > * The number of used entries in the stack. > */ > -__rte_experimental > static __rte_always_inline unsigned int > rte_stack_count(struct rte_stack *s) > { > @@ -177,9 +164,6 @@ rte_stack_count(struct rte_stack *s) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Return the number of free entries in a stack. > * > * @param s > @@ -187,7 +171,6 @@ rte_stack_count(struct rte_stack *s) > * @return > * The number of free entries in the stack. > */ > -__rte_experimental > static __rte_always_inline unsigned int > rte_stack_free_count(struct rte_stack *s) > { > @@ -197,9 +180,6 @@ rte_stack_free_count(struct rte_stack *s) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Create a new stack named *name* in memory. > * > * This function uses ``memzone_reserve()`` to allocate memory for a stack of > @@ -226,28 +206,20 @@ rte_stack_free_count(struct rte_stack *s) > * - ENOMEM - insufficient memory to create the stack > * - ENAMETOOLONG - name size exceeds RTE_STACK_NAMESIZE > */ > -__rte_experimental > struct rte_stack * > rte_stack_create(const char *name, unsigned int count, int socket_id, > uint32_t flags); > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Free all memory used by the stack. > * > * @param s > * Stack to free > */ > -__rte_experimental > void > rte_stack_free(struct rte_stack *s); > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Lookup a stack by its name. > * > * @param name > @@ -258,7 +230,6 @@ rte_stack_free(struct rte_stack *s); > * - ENOENT - Stack with name *name* not found. > * - EINVAL - *name* pointer is NULL. > */ > -__rte_experimental > struct rte_stack * > rte_stack_lookup(const char *name); > > diff --git a/lib/librte_stack/rte_stack_lf.h b/lib/librte_stack/rte_stack_lf.h > index e67630c27..eb106e64e 100644 > --- a/lib/librte_stack/rte_stack_lf.h > +++ b/lib/librte_stack/rte_stack_lf.h > @@ -27,7 +27,6 @@ > * @return > * Actual number of objects enqueued. > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_lf_push(struct rte_stack *s, > void * const *obj_table, > @@ -66,7 +65,6 @@ __rte_stack_lf_push(struct rte_stack *s, > * @return > * - Actual number of objects popped. > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_lf_pop(struct rte_stack *s, void **obj_table, unsigned int n) > { > diff --git a/lib/librte_stack/rte_stack_std.h b/lib/librte_stack/rte_stack_std.h > index 7142cbf8e..ae28add5c 100644 > --- a/lib/librte_stack/rte_stack_std.h > +++ b/lib/librte_stack/rte_stack_std.h > @@ -19,7 +19,6 @@ > * @return > * Actual number of objects pushed (either 0 or *n*). > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_std_push(struct rte_stack *s, void * const *obj_table, > unsigned int n) > @@ -59,7 +58,6 @@ __rte_stack_std_push(struct rte_stack *s, void * const *obj_table, > * @return > * Actual number of objects popped (either 0 or *n*). > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n) > { > @@ -94,7 +92,6 @@ __rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n) > * @return > * The number of used entries in the stack. > */ > -__rte_experimental > static __rte_always_inline unsigned int > __rte_stack_std_count(struct rte_stack *s) > { > diff --git a/lib/librte_stack/rte_stack_version.map b/lib/librte_stack/rte_stack_version.map > index 6662679c3..8c4ca0245 100644 > --- a/lib/librte_stack/rte_stack_version.map > +++ b/lib/librte_stack/rte_stack_version.map > @@ -1,4 +1,4 @@ > -EXPERIMENTAL { > +DPDK_21 { > global: > > rte_stack_create; > -- > 2.13.6 > Otherwise, lgtm. Acked-by: David Marchand -- David Marchand