From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32D32A0A0E; Mon, 10 May 2021 13:25:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD37C40140; Mon, 10 May 2021 13:25:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 28AB84003E for ; Mon, 10 May 2021 13:25:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620645944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gFemtqtcWG/+7iT/GWEzUlMIRe26n75IIcjEdRhDTsk=; b=GjM2M7+Qdss0qRqddZRinhxPZcuhqkoI4cZAdXSZbTGVb9/LyoLLKDB9YWwIKsJTO3mTyM JFePmeicde46nmUKWlKgNhzNsdGkn1pghtc0lyMj/WDTBr7aalfWNe+qHOShzkGbyHRm70 66cEFfXNYU/mXvvymmPNRuaKHIqAcYI= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-34-kvKHgMDyOnCciMxta6MljQ-1; Mon, 10 May 2021 07:25:40 -0400 X-MC-Unique: kvKHgMDyOnCciMxta6MljQ-1 Received: by mail-vs1-f70.google.com with SMTP id e12-20020a67d80c0000b029022a88436f30so3029076vsj.11 for ; Mon, 10 May 2021 04:25:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gFemtqtcWG/+7iT/GWEzUlMIRe26n75IIcjEdRhDTsk=; b=ZwtQiHczuSdbbcNSy2e5xMQ1bKXQ7uV/BjSh/sVaodyT/oIPs5OYFbfZx3EF2dR4T4 Pnnwp4yQAe2ayVWM4gIo+5QD/Lgu8OGleIYbDCq+TqgIoPi2yQx8HpKlO66wuMh3Nb6n zSC7LcxzHvJb7b1P/gbGrwFIgr5SWkcPUI7Td6t/7J1A6MzwDIpOHlFawtrPM8+0pIiU gMaGcK27nSzG8AYJGiIaSsAaedhnUbJvf6uh5Y1MWrLRBGc7LNJ1nR9Faz+ILtmRGcJM 46MwkaLfn41FjLSQglkEPvQKtgDMHgHHnTZyBVzeA78heL1WYJ4vvcgCWdMVIkhyXIKg lFXA== X-Gm-Message-State: AOAM532NfMiRyHvygzq65ieGhrkaCdz3yCa0W/TV51M71XrXQZ9QKd5E svIGsZCPgYQcuJ0Cs3+kcL4Dc42zJXiPTQmN3rICEIhkQ1DztQ1nBLu4YFs03HNG3BYJeqHgIwa ZUilAywncONF+QESURV0= X-Received: by 2002:a67:6b41:: with SMTP id g62mr18668371vsc.5.1620645940433; Mon, 10 May 2021 04:25:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCJ6iDOygirhe6eOb6iUVlgA9tI4JIw/R8yFdS7U6blIEYKuksrvuBxPDq9xQX2lrfLEi7kHQiYNy08m0ihfI= X-Received: by 2002:a67:6b41:: with SMTP id g62mr18668354vsc.5.1620645940237; Mon, 10 May 2021 04:25:40 -0700 (PDT) MIME-Version: 1.0 References: <20210506151426.28202-1-david.marchand@redhat.com> <20210506151426.28202-3-david.marchand@redhat.com> <20210507012356.216f1f49@sovereign> In-Reply-To: From: David Marchand Date: Mon, 10 May 2021 13:25:28 +0200 Message-ID: To: Ben Pfaff Cc: Dmitry Kozlyuk , dev , Ian Stokes , Kevin Traynor , Olivier Matz , Ranjit Menon , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Ben, On Fri, May 7, 2021 at 9:13 PM Ben Pfaff wrote: > > > > It would be interesting to know exact issue this solves for OVS. > > > > Referenced commit only says FreeBSD "insists" on this include order, > > > > but DPDK and standalone files with these includes build either way. > > > > > > Indeed, I tried building with FreeBSD 13.0 and I can see no pb. > > > This might be something that has been fixed in FreeBSD. > > > > > > Ben, would you have details on this header inclusion order? > > > > Using the wrong order caused a compiler error on whatever version of > > FreeBSD was current at the time of those commits. I think it was a > > historical BSD issue, since I remember running into this for many years > > across multiple BSD versions. > > > > If it's fixed now, we can drop the constraint. I reverted some bits on arpa/inet.h vs netinet/in.h headers in OVS but did not reproduce the issue on FreeBSD 11 and 12 with Cirrus. > > Oh, Mac OS X appears to also have this or a related problem: Reverting the patch on conntrack which deals with sys/types.h vs netinet/icmp6.h, there is an issue on FreeBSD 11 and 12: https://cirrus-ci.com/task/4786810854309888 In file included from lib/conntrack.c:libtool: compile: clang -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -I/usr/local/include -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -Wthread-safety -fno-strict-aliasing -Wswitch-bool -Wlogical-not-parentheses -Wsizeof-array-argument -Wshift-negative-value -Qunused-arguments -Wshadow -Wno-null-pointer-arithmetic -Warray-bounds-pointer-arithmetic -Werror -Werror -g -O2 -Wall -DHAVE_AVX512F -DHAVE_LD_AVX512_GOOD -MT lib/coverage.lo -MD -MP -MF lib/.deps/coverage.Tpo -c lib/coverage.c -o lib/coverage.o 21: /usr/include/netinet/icmp6.h:71:2: error: unknown type name 'u_int8_t' u_int8_t icmp6_type; /* type field */ ^ /usr/include/netinet/icmp6.h:72:2: error: unknown type name 'u_int8_t' u_int8_t icmp6_code; /* code field */ ^ ... I don't think it is worth dropping only the first constraint, so I would keep it as is in OVS. Thanks. -- David Marchand