From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E68B945E6A; Tue, 10 Dec 2024 14:32:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C40F4029B; Tue, 10 Dec 2024 14:32:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EB34440270 for ; Tue, 10 Dec 2024 14:32:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733837548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=InaRqQFsObxjrxPAZZ9Q0ZrZXuCj6/vLCtLj4ErYmCA=; b=QVimfIxzLbHz/3gFdTeiXGcseAoqu5eUc9pA6fE/qGyUZ0W3fO4OnHrNcxIlwWxKouJq73 JIjqOZRBpQHDyY0GoxRP9DAcj5JWeIahN9lcERwKYqSULidY18YVGPpG8kgAhTYb6PBfZU ujb6G6/j5AOVSgFBTjcnpdPSxNzUavQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-apw-dhMJMi6kauZBBXUr7A-1; Tue, 10 Dec 2024 08:32:26 -0500 X-MC-Unique: apw-dhMJMi6kauZBBXUr7A-1 X-Mimecast-MFC-AGG-ID: apw-dhMJMi6kauZBBXUr7A Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-53e1bddea1dso3020304e87.2 for ; Tue, 10 Dec 2024 05:32:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733837545; x=1734442345; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=InaRqQFsObxjrxPAZZ9Q0ZrZXuCj6/vLCtLj4ErYmCA=; b=dIRfWEH1fkrStQNgwI57HSBqo9B84S/iuPt3XtkacaOaCrpHaVxVVELeQa+sI+ubPU ppHMIcC6zhWCKgplqvrLasQn1G7HiS+72h2C+U7GXMMHOukpwLWWunJRU0ROX7E5Djz0 bte9HkMnTYtHKrmslc2ZRn5vLDy7YHVJyqtj8shcN2RA45ukxLBVbH4XUQ47QttwqZen aZHD+XK7vyJWWfrjly5Wqow54F1L7Dm96sibpxkVMSu4XWGiugqGQ1TSDUdf9YUVYCIO jFcxA0qkOUTPngPtCpADLfwAnmCpdsagu/0kBW0oF66CoL+PjrMq5d9V0B5gXYY9s2BZ pdTQ== X-Gm-Message-State: AOJu0YzX+JfYxfA6Pt7K6ad1P+M/+xm60SMZJO6/EG6Pyn/9DuuUXMuV 0BX08ewwrdJRq8LPQadlMh++9Rig3no7pLuTa2GSSP7HwGm8W6/XrqimqtftW2+yhTGk4I3+LYY fj+G6Bw8XMNskZoEF84rJAeFn8njWm5oNOXXy6ubCp4n+y1VeQrTsCLkZEdUpkImJ+RuttTACmg cBl2sMJVeKsz/1JbM= X-Gm-Gg: ASbGncsy9+q3QW7IG5lgYXGAApO7zbnUmX2qVvY5m+kX3pxk/bMYJT0e5TSEOu4und0 UcqScgdSkYmd1ELqvm5c76NHbNBhUIVD9BKV/qA== X-Received: by 2002:a05:6512:3ca0:b0:53e:391c:e985 with SMTP id 2adb3069b0e04-540240d1352mr1676011e87.32.1733837545268; Tue, 10 Dec 2024 05:32:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGytdYtW5tBhH82yPncUQgjzR6ATZ05ErG1mOrTL1s5a7drpKyEvEACJ3WFLy3ldqnNnPoIC8Xx8XGGdsp45Cs= X-Received: by 2002:a05:6512:3ca0:b0:53e:391c:e985 with SMTP id 2adb3069b0e04-540240d1352mr1675994e87.32.1733837544883; Tue, 10 Dec 2024 05:32:24 -0800 (PST) MIME-Version: 1.0 References: <20241107135254.1611676-1-sriharsha.basavapatna@broadcom.com> <20241107135254.1611676-18-sriharsha.basavapatna@broadcom.com> In-Reply-To: <20241107135254.1611676-18-sriharsha.basavapatna@broadcom.com> From: David Marchand Date: Tue, 10 Dec 2024 14:32:14 +0100 Message-ID: Subject: Re: [PATCH v8 17/47] net/bnxt: tf_ulp: support for Thor2 ulp layer To: Sriharsha Basavapatna Cc: dev@dpdk.org, Shuanglin Wang , Mike Baucom , Kishore Padmanabha , Manish Kurup , Shahaji Bhosle , Randy Schacher , Ajit Khaparde X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xJTlwFG1jgDPAViZRaciWMe_k1oKHUzITdUF8H38HOc_1733837545 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Thu, Nov 7, 2024 at 3:09=E2=80=AFPM Sriharsha Basavapatna wrote: > > From: Shuanglin Wang > > This patch includes the support for following features that enable > Thor2 support in the ULP layer: > > 1. Added support for ulp initialization on Thor2 platform. This involved > breaking the functionality that is common and not common between Thor and > Thor2 platforms. > 2. MPC support for Thor2. This feature enables the access of the DRAM > memory location in the HOST CPU for Exact match flows and Action records > for those flows. > 3. Added support for VF's on Thor2 platform. > 4. Added support to offload traffic between two VF's on the system. > 5. Renamed all BNXT_TF_DBG macros to BNXT_DRV_DBG. > 6. Added logic to get error conditions in the flow create path. > 7. Added support for Geneve header and set TTL action parsing. > 8. Add mpc batching to ulp flow create for Thor2. > > This patch also updates the template files for the changes > that are being added in this patch. > > Signed-off-by: Shuanglin Wang > Signed-off-by: Mike Baucom > Signed-off-by: Kishore Padmanabha > Signed-off-by: Manish Kurup > Signed-off-by: Sriharsha Basavapatna > Reviewed-by: Shahaji Bhosle > Reviewed-by: Randy Schacher > Reviewed-by: Ajit Khaparde It looks like the symbol ulp_class_sig_tbl was left behind. $ git grep ulp_class_sig_tbl dd0191d5e70d0e65a7f041a88af480fc673160e1 dd0191d5e70d0e65a7f041a88af480fc673160e1:drivers/net/bnxt/tf_ulp/ulp_templa= te_struct.h:extern uint16_t ulp_class_sig_tbl[]; $ git grep ulp_class_sig_tbl dd0191d5e70d0e65a7f041a88af480fc673160e1^ dd0191d5e70d0e65a7f041a88af480fc673160e1^:drivers/net/bnxt/tf_ulp/generic_t= emplates/ulp_template_db_class.c:uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] =3D { dd0191d5e70d0e65a7f041a88af480fc673160e1^:drivers/net/bnxt/tf_ulp/ulp_match= er.c: tmpl_id =3D ulp_class_sig_tbl[class_hid]; dd0191d5e70d0e65a7f041a88af480fc673160e1^:drivers/net/bnxt/tf_ulp/ulp_templ= ate_struct.h:extern uint16_t ulp_class_sig_tbl[]; --=20 David Marchand