From: David Marchand <david.marchand@redhat.com>
To: Akhil Goyal <gakhil@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
Ray Kinsella <mdr@ashroe.eu>,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Nipun Gupta <nipun.gupta@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Anoob Joseph <anoobj@marvell.com>,
Matan Azrad <matan@nvidia.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
Gagandeep Singh <g.singh@nxp.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Van Haaren Harry <harry.van.haaren@intel.com>,
Shijith Thotton <sthotton@marvell.com>,
Dodji Seketeli <dodji@redhat.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v10 1/4] devtools: add exception for reserved fields
Date: Thu, 15 Apr 2021 09:26:38 +0200 [thread overview]
Message-ID: <CAJFAV8yXQNmbKaz_bG-Ujpm=PQirZD_kEBrnp+gzaudqGaaTTg@mail.gmail.com> (raw)
In-Reply-To: <MW2PR18MB22840528F529463F6D4B84CED84D9@MW2PR18MB2284.namprd18.prod.outlook.com>
On Thu, Apr 15, 2021 at 7:33 AM Akhil Goyal <gakhil@marvell.com> wrote:
>
> Hi David,
> > > Certain structures are added with reserved fields
> > > to address any future enhancements to retain ABI
> > > compatibility.
> > > However, ABI script will still report error as it
> > > is not aware of reserved fields. Hence, adding a
> > > generic exception for reserved fields.
> > >
> > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > > ---
> > > devtools/libabigail.abignore | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> > > index 6c0b38984..654755314 100644
> > > --- a/devtools/libabigail.abignore
> > > +++ b/devtools/libabigail.abignore
> > > @@ -19,4 +19,8 @@
> > > ; Ignore fields inserted in cacheline boundary of rte_cryptodev
> > > [suppress_type]
> > > name = rte_cryptodev
> > > - has_data_member_inserted_between = {offset_after(attached), end}
> > > \ No newline at end of file
> > > + has_data_member_inserted_between = {offset_after(attached), end}
> > > +
> > > +; Ignore changes in reserved fields
> > > +[suppress_variable]
> > > + name_regexp = reserved
> > Mm, this rule is a bit scary, as it matches anything with "reserved" in it.
>
> Why do you feel it is scary? Reserved is something which may change at any time
> Just like experimental. Hence creating a generic exception rule for it make sense
> And it is done intentionally in this patch.
The reserved regexp on the name of a variable / struct field is too lax.
Anything could be named with reserved in it.
If we have clear patterns, they must be preferred, like (untested)
name_regexp = ^reserved_(64|ptr)s$
Experimental is different.
This is a symbol version tag, which has a clear meaning and can't be
used for anything else.
>
> >
> > You need an exception anyway to insert the new fields (like in patch 2).
> > Can you test your series dropping this patch 1 ?
> It will not work, as there are 2 changes,
> 1. addition of ca_enqueue after attached. This is taken care by the exception set in patch 2
> 2. change in the reserved_ptr[4] -> reserved_ptr[3]. For this change we need exception for reserved.
In the eventdev struct, reserved fields are all in the range between
the attached field and the end of the struct.
I pushed your series without patch 1 to a branch of mine, and it
passes the check fine:
https://github.com/david-marchand/dpdk/commits/crypto_fwd_mode_v10
https://github.com/david-marchand/dpdk/runs/2350324578?check_suite_focus=true#step:15:8549
--
David Marchand
next prev parent reply other threads:[~2021-04-15 7:26 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 18:12 [dpdk-dev] [PATCH] [RFC] eventdev: introduce crypto adapter enqueue API Akhil Goyal
2021-03-26 9:12 ` [dpdk-dev] [PATCH v1 0/2] Enhancements to crypto adapter forward mode Shijith Thotton
2021-03-26 9:12 ` [dpdk-dev] [PATCH v1 1/2] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-03-27 6:04 ` Pavan Nikhilesh Bhagavatula
2021-03-26 9:12 ` [dpdk-dev] [PATCH v1 2/2] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-03-27 6:27 ` Pavan Nikhilesh Bhagavatula
2021-03-29 4:31 ` Shijith Thotton
2021-03-29 15:04 ` [dpdk-dev] [PATCH v2 0/2] Enhancements to " Shijith Thotton
2021-03-29 15:04 ` [dpdk-dev] [PATCH v2 1/2] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-03-29 15:04 ` [dpdk-dev] [PATCH v2 2/2] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-02 15:03 ` [dpdk-dev] [PATCH v3 0/3] Enhancements to " Shijith Thotton
2021-04-02 15:03 ` [dpdk-dev] [PATCH v3 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-02 15:03 ` [dpdk-dev] [PATCH v3 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-02 15:03 ` [dpdk-dev] [PATCH v3 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-02 17:01 ` [dpdk-dev] [PATCH v4 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-02 17:01 ` [dpdk-dev] [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-03 12:32 ` Gujjar, Abhinandan S
2021-04-05 17:40 ` Akhil Goyal
2021-04-07 15:28 ` Gujjar, Abhinandan S
2021-04-08 14:56 ` Akhil Goyal
2021-04-08 16:57 ` Gujjar, Abhinandan S
2021-04-08 18:44 ` Akhil Goyal
2021-04-02 17:01 ` [dpdk-dev] [PATCH v4 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-03 10:20 ` Gujjar, Abhinandan S
2021-04-06 15:01 ` Anoob Joseph
2021-04-07 15:06 ` Gujjar, Abhinandan S
2021-04-08 6:45 ` Shijith Thotton
2021-04-02 17:01 ` [dpdk-dev] [PATCH v4 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-03 11:08 ` Gujjar, Abhinandan S
2021-04-05 6:10 ` Shijith Thotton
2021-04-08 19:24 ` [dpdk-dev] [PATCH v5 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-08 19:24 ` [dpdk-dev] [PATCH v5 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-08 19:24 ` [dpdk-dev] [PATCH v5 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-08 19:24 ` [dpdk-dev] [PATCH v5 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-09 14:00 ` [dpdk-dev] [PATCH v6 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-09 14:00 ` [dpdk-dev] [PATCH v6 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-09 14:00 ` [dpdk-dev] [PATCH v6 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-09 14:00 ` [dpdk-dev] [PATCH v6 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-12 5:10 ` Gujjar, Abhinandan S
2021-04-12 7:02 ` Shijith Thotton
2021-04-12 7:24 ` Gujjar, Abhinandan S
2021-04-12 7:35 ` Shijith Thotton
2021-04-12 13:52 ` Shijith Thotton
2021-04-12 15:00 ` Gujjar, Abhinandan S
2021-04-12 7:43 ` [dpdk-dev] [PATCH v7 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-12 7:43 ` [dpdk-dev] [PATCH v7 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-13 3:23 ` Gujjar, Abhinandan S
2021-04-12 7:43 ` [dpdk-dev] [PATCH v7 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-13 3:34 ` Gujjar, Abhinandan S
2021-04-13 8:51 ` Shijith Thotton
2021-04-12 7:43 ` [dpdk-dev] [PATCH v7 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-13 3:45 ` Gujjar, Abhinandan S
2021-04-13 10:29 ` [dpdk-dev] [PATCH v8 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-13 10:29 ` [dpdk-dev] [PATCH v8 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-14 7:28 ` Jerin Jacob Kollanukkaran
2021-04-14 7:58 ` Akhil Goyal
2021-04-14 8:18 ` Thomas Monjalon
2021-04-14 8:39 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-04-14 8:43 ` Thomas Monjalon
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 0/4] Enhancements to crypto adapter forward mode gakhil
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 1/4] eventdev: introduce crypto adapter enqueue API gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 0/4] Enhancements to crypto adapter forward mode gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 1/4] devtools: add exception for reserved fields gakhil
2021-04-14 20:57 ` David Marchand
2021-04-15 5:32 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-04-15 7:26 ` David Marchand [this message]
2021-04-15 8:25 ` Bruce Richardson
2021-04-15 8:27 ` Thomas Monjalon
2021-04-15 8:31 ` Akhil Goyal
2021-04-15 19:56 ` Stephen Hemminger
2021-04-15 9:13 ` [dpdk-dev] [PATCH v11 0/3] Enhancements to crypto adapter forward mode gakhil
2021-04-15 9:13 ` [dpdk-dev] [PATCH v11 1/3] eventdev: introduce crypto adapter enqueue API gakhil
2021-04-17 16:54 ` Jerin Jacob
2021-04-15 9:13 ` [dpdk-dev] [PATCH v11 2/3] event/octeontx2: support crypto adapter forward mode gakhil
2021-04-15 9:13 ` [dpdk-dev] [PATCH v11 3/3] test/event_crypto: use crypto adapter enqueue API gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 2/4] eventdev: introduce " gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 3/4] event/octeontx2: support crypto adapter forward mode gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 4/4] test/event_crypto: use crypto adapter enqueue API gakhil
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 2/4] event/octeontx2: support crypto adapter forward mode gakhil
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 3/4] test/event_crypto: use crypto adapter enqueue API gakhil
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 4/4] devtools: add exception for reserved fields gakhil
2021-04-14 12:53 ` Thomas Monjalon
2021-04-14 14:16 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-04-14 14:22 ` Thomas Monjalon
2021-04-14 17:56 ` Akhil Goyal
2021-04-13 10:29 ` [dpdk-dev] [PATCH v8 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-13 10:29 ` [dpdk-dev] [PATCH v8 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-13 19:40 ` Jerin Jacob
2021-03-30 4:04 ` [dpdk-dev] [PATCH v1 0/2] Enhancements to crypto adapter forward mode Jerin Jacob
2021-03-30 4:57 ` Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yXQNmbKaz_bG-Ujpm=PQirZD_kEBrnp+gzaudqGaaTTg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=erik.g.carrillo@intel.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=nipun.gupta@nxp.com \
--cc=pbhagavatula@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sthotton@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).