[PATCH] net/i40e: reduce log level of global register update msg

[PATCH] net/i40e: reduce log level of global register update msg

[Bruce Richardson]

The modifying of a global register value, which has an affect on multiple
ports is an important change to HW. However, the actual details of that
change is only relevant to developers and not general users. Therefore
reduce the log level from "warning" - which implies something is wrong -
to "info".

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 30dcdc68a8..39b6e28aad 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -750,7 +750,7 @@ i40e_write_global_rx_ctl(struct i40e_hw *hw, uint32_t reg_addr,
 	ori_reg_val = i40e_read_rx_ctl(hw, reg_addr);
 	i40e_write_rx_ctl(hw, reg_addr, reg_val);
 	if (ori_reg_val != reg_val)
-		PMD_DRV_LOG(WARNING,
+		PMD_DRV_LOG(INFO,
 			    "i40e device %s changed global register [0x%08x]."
 			    " original: 0x%08x, new: 0x%08x",
 			    dev->device->name, reg_addr, ori_reg_val, reg_val);
@@ -1352,7 +1352,7 @@ i40e_aq_debug_write_global_register(struct i40e_hw *hw,
 	}
 
 	if (ori_reg_val != reg_val)
-		PMD_DRV_LOG(WARNING,
+		PMD_DRV_LOG(INFO,
 			    "i40e device %s changed global register [0x%08x]."
 			    " original: 0x%"PRIx64", after: 0x%"PRIx64,
 			    dev->device->name, reg_addr, ori_reg_val, reg_val);
@@ -9774,7 +9774,7 @@ i40e_check_write_global_reg(struct i40e_hw *hw, uint32_t addr, uint32_t val)
 
 	if (reg != val) {
 		i40e_write_rx_ctl(hw, addr, val);
-		PMD_DRV_LOG(WARNING,
+		PMD_DRV_LOG(INFO,
 			    "i40e device %s changed global register [0x%08x]."
 			    " original: 0x%08x, new: 0x%08x",
 			    dev->device->name, addr, reg,
-- 
2.43.0

Re: [PATCH] net/i40e: reduce log level of global register update msg

[David Marchand]

On Tue, Jan 21, 2025 at 5:36 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The modifying of a global register value, which has an affect on multiple
> ports is an important change to HW. However, the actual details of that
> change is only relevant to developers and not general users. Therefore
> reduce the log level from "warning" - which implies something is wrong -
> to "info".
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

Re: [PATCH] net/i40e: reduce log level of global register update msg

[Bruce Richardson]

On Tue, Feb 11, 2025 at 02:57:21PM +0100, David Marchand wrote:
> On Tue, Jan 21, 2025 at 5:36 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The modifying of a global register value, which has an affect on multiple
> > ports is an important change to HW. However, the actual details of that
> > change is only relevant to developers and not general users. Therefore
> > reduce the log level from "warning" - which implies something is wrong -
> > to "info".
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Acked-by: David Marchand <david.marchand@redhat.com>
> 

Applied to dpdk-next-net-intel

/Bruce