From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 274D0A04FD; Mon, 23 May 2022 09:14:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A8104014F; Mon, 23 May 2022 09:14:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5883340041 for <dev@dpdk.org>; Mon, 23 May 2022 09:14:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653290062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QR1fDKHm6SkNkdVwJ0rG5CK6EVdEzrfDJJfW3Q9LsU4=; b=DnBMvC7yeD9Pl18PAtW4iUCyMjBriPqQxQQaNGAj8SQQVmUbmkTSLWv4PffX2pIY4FHDZh FjN5S6SKmbXgisXpGFXRUR5AzF07sWTwMTMFjb73sUDuBuPXgx9x6ftc4sWq4jiW58kRzK CxpDXmDXZ8rDfApDm8yN/z+OE+qarSI= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-384-62OARKLdPWu_ZkWwFbLlYQ-1; Mon, 23 May 2022 03:14:19 -0400 X-MC-Unique: 62OARKLdPWu_ZkWwFbLlYQ-1 Received: by mail-lj1-f200.google.com with SMTP id x16-20020a2e9c90000000b002509c7b56ebso2623007lji.14 for <dev@dpdk.org>; Mon, 23 May 2022 00:14:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QR1fDKHm6SkNkdVwJ0rG5CK6EVdEzrfDJJfW3Q9LsU4=; b=tsZE31gCCyDB9WQTv2/psMUfyed7Swvobyd78Y13HXuNgoaTEUtahmcLSdWVh/pW6M tqusbIWVkry6e+B2B7ixrEhdjeJvDCpbmEhbnTS90RFYlpO1LYT6D9vU4sOOl8XjwLe5 WM/s4DAWHmWwliJchZt6AD2lkGHPYDgE2He9CPyvfXmCsy394dRSTOXaAxd3dJozYwHU XUHG2necOCqFWo1t2IIicGnIQNZQRo3TK3ZyxWASa0VNsg6Be7l3uGLlSdiPv4rpSwri Pj1NmdKFV1CI5zg9ml8Eow0gLFq3jUer3jvB5SG96NThEDqKeiJWk202e5aRq35VBcH/ ikpA== X-Gm-Message-State: AOAM531zr6L8BztDuv1/18kq3cyl3/nO63JfyJg4jLYIJsSXqzHpN/te kkpGkb5x9nLvXT10hnb/95RL0yQTHMlryH4wziONi4e64yPcpNbxRGAxlRIcFiN2P78j7GpnBmu yZqAG4nBfln8b+dpOTaQ= X-Received: by 2002:a2e:a445:0:b0:24a:c1ba:b62f with SMTP id v5-20020a2ea445000000b0024ac1bab62fmr12298811ljn.81.1653290058034; Mon, 23 May 2022 00:14:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyroAblCiPYQ5Ff9//7AHXvKit+mY8OQ7Cm0TFEezjHhblnn2fvg6tgMK1cxbf8hI6Gq2UHLbzUnnGwmyYAnA= X-Received: by 2002:a2e:a445:0:b0:24a:c1ba:b62f with SMTP id v5-20020a2ea445000000b0024ac1bab62fmr12298804ljn.81.1653290057844; Mon, 23 May 2022 00:14:17 -0700 (PDT) MIME-Version: 1.0 References: <20220512020618.474816-1-stevex.yang@intel.com> <20220518065806.1005694-1-stevex.yang@intel.com> <CAJFAV8zxqyq_8P8gKEc7vOojDQ1fNdJMVBMGuERinVaVOd_1Ww@mail.gmail.com> <DM4PR11MB59941F2ED2AE731991A6B270D7D39@DM4PR11MB5994.namprd11.prod.outlook.com> <DM4PR11MB59941E9B6553381615D77115D7D29@DM4PR11MB5994.namprd11.prod.outlook.com> In-Reply-To: <DM4PR11MB59941E9B6553381615D77115D7D29@DM4PR11MB5994.namprd11.prod.outlook.com> From: David Marchand <david.marchand@redhat.com> Date: Mon, 23 May 2022 09:14:06 +0200 Message-ID: <CAJFAV8yYk1OdbdzjM2ud1NK4k-76Oay7ExOEvkAD7SR7S3z1ow@mail.gmail.com> Subject: Re: [PATCH v3] app/testpmd: support ddp dump command for ice To: "Zhang, Qi Z" <qi.z.zhang@intel.com> Cc: "Yang, SteveX" <stevex.yang@intel.com>, dev <dev@dpdk.org>, "Zhang, Yuying" <yuying.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@xilinx.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Thomas Monjalon <thomas@monjalon.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Sat, May 21, 2022 at 3:20 AM Zhang, Qi Z <qi.z.zhang@intel.com> wrote: > > > > Dump DDP runtime configure into a binary(package) file from ice PF port. > > > > > > > > Add command line: > > > > ddp dump <port_id> <config_path> > > > > > > > > Parameters: > > > > <port_id> the PF Port ID > > > > <config_path> dumped runtime configure file, if not a absolute path, > > > > it will be dumped to testpmd running directory. > > > > > > > > For example: > > > > testpmd> ddp dump 0 current.pkg > > > > > > > > If you want to dump ice VF DDP runtime configure, you need bind > > > > other unused PF port of the NIC first, and then dump the PF's > > > > runtime configure as target output. > > > > > > > > Signed-off-by: Steve Yang <stevex.yang@intel.com> > > > > > > I proposed a way to move such code in drivers, please have a look > > > at/give feedback to: > > > https://patchwork.dpdk.org/project/dpdk/list/?series=23000&state=* > > > > This looks like a good idea, we will review and thanks for the heads-up > > > > David > Are these RFC patches target to DPDK 22.07? > If not, is below proposal acceptable? > 1. merge this patch in DPDK 22.07. > 2. meanwhile we will also contribute the ice refactor patch based on your RFC, so it can be captured in next release. My intention is to get them in 22.07, if other maintainers are happy with it. I just posted a non-RFC series. -- David Marchand