This fixes the following build errors by adding 2 missing header includes: ``` drivers/common/mlx5/linux/mlx5_glue.c: In function 'mlx5_glue_destroy_flow_action': drivers/common/mlx5/linux/mlx5_glue.c:187:2: error: implicit declaration of function 'mlx5_free' [-Werror=implicit-function-declaration] mlx5_free(action); ^ ... drivers/common/mlx5/linux/mlx5_glue.c:620:46: error: 'SOCKET_ID_ANY' undeclared (first use in this function) action = mlx5_malloc(0, sizeof(*action), 0, SOCKET_ID_ANY); ... ``` The build error reproduces on Ubuntu 16.04 with rdma-core version v22.1 and with gcc version 5.4.0. Fixes: 0e25e18bfba9 ("common/mlx5: convert control path memory to unified malloc") Cc: suanmingm@mellanox.com Signed-off-by: Ali Alnubani <alialnu@mellanox.com> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> --- drivers/common/mlx5/linux/mlx5_glue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/common/mlx5/linux/mlx5_glue.c b/drivers/common/mlx5/linux/mlx5_glue.c index ea9c86b3a..fcf03e867 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.c +++ b/drivers/common/mlx5/linux/mlx5_glue.c @@ -8,6 +8,7 @@ #include <stddef.h> #include <stdint.h> #include <stdlib.h> +#include <rte_memory.h> /* * Not needed by this file; included to work around the lack of off_t * definition for mlx5dv.h with unpatched rdma-core versions. @@ -15,6 +16,7 @@ #include <sys/types.h> #include "mlx5_glue.h" +#include "../mlx5_malloc.h" static int mlx5_glue_fork_init(void) -- 2.27.0
Hi,
> -----Original Message-----
> From: Ali Alnubani <alialnu@mellanox.com>
> Sent: Sunday, July 19, 2020 2:52 PM
> To: dev@dpdk.org
> Cc: Suanming Mou <suanmingm@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>
> Subject: [PATCH] common/mlx5: fix mlx5 build
>
> This fixes the following build errors by adding 2
> missing header includes:
>
> ```
> drivers/common/mlx5/linux/mlx5_glue.c: In function
> 'mlx5_glue_destroy_flow_action':
> drivers/common/mlx5/linux/mlx5_glue.c:187:2: error: implicit declaration
> of function 'mlx5_free' [-Werror=implicit-function-declaration]
> mlx5_free(action);
> ^
> ...
> drivers/common/mlx5/linux/mlx5_glue.c:620:46: error: 'SOCKET_ID_ANY'
> undeclared (first use in this function)
> action = mlx5_malloc(0, sizeof(*action), 0, SOCKET_ID_ANY);
> ...
> ```
>
> The build error reproduces on Ubuntu 16.04 with rdma-core version v22.1
> and
> with gcc version 5.4.0.
>
> Fixes: 0e25e18bfba9 ("common/mlx5: convert control path memory to
> unified malloc")
> Cc: suanmingm@mellanox.com
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
> drivers/common/mlx5/linux/mlx5_glue.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/common/mlx5/linux/mlx5_glue.c
> b/drivers/common/mlx5/linux/mlx5_glue.c
> index ea9c86b3a..fcf03e867 100644
> --- a/drivers/common/mlx5/linux/mlx5_glue.c
> +++ b/drivers/common/mlx5/linux/mlx5_glue.c
> @@ -8,6 +8,7 @@
> #include <stddef.h>
> #include <stdint.h>
> #include <stdlib.h>
> +#include <rte_memory.h>
> /*
> * Not needed by this file; included to work around the lack of off_t
> * definition for mlx5dv.h with unpatched rdma-core versions.
> @@ -15,6 +16,7 @@
> #include <sys/types.h>
>
> #include "mlx5_glue.h"
> +#include "../mlx5_malloc.h"
>
> static int
> mlx5_glue_fork_init(void)
> --
> 2.27.0
Patch squashed into relevant commit in master-net-mlx,
Kindest regards,
Raslan Darawsheh
On Sun, Jul 19, 2020 at 5:17 PM Raslan Darawsheh <rasland@mellanox.com> wrote: > > @@ -15,6 +16,7 @@ > > #include <sys/types.h> > > > > #include "mlx5_glue.h" > > +#include "../mlx5_malloc.h" > > > > static int > > mlx5_glue_fork_init(void) > > -- > > 2.27.0 > > > Patch squashed into relevant commit in master-net-mlx, Raslan, The CI reported a lot of build issues for this patch: https://travis-ci.com/github/ovsrobot/dpdk/builds/176208345 -- David Marchand
Hi David,
Yes I noticed it already,
but it's coming from the fact that it's trying to apply it on a tree that doesn't have the patch which this patch is trying to fix.
../drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error: '../mlx5_malloc.h' file not found
#include "../mlx5_malloc.h"
^~~~~~~~~~~~~~~~~~
Kindest regards,
Raslan Darawsheh
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, July 20, 2020 11:25 AM
> To: Raslan Darawsheh <rasland@mellanox.com>
> Cc: Ali Alnubani <alialnu@mellanox.com>; dev@dpdk.org; Suanming Mou
> <suanmingm@mellanox.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> Thomas Monjalon <thomas@monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build
>
> On Sun, Jul 19, 2020 at 5:17 PM Raslan Darawsheh <rasland@mellanox.com>
> wrote:
> > > @@ -15,6 +16,7 @@
> > > #include <sys/types.h>
> > >
> > > #include "mlx5_glue.h"
> > > +#include "../mlx5_malloc.h"
> > >
> > > static int
> > > mlx5_glue_fork_init(void)
> > > --
> > > 2.27.0
> >
> >
> > Patch squashed into relevant commit in master-net-mlx,
>
> Raslan,
>
> The CI reported a lot of build issues for this patch:
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis
> -
> ci.com%2Fgithub%2Fovsrobot%2Fdpdk%2Fbuilds%2F176208345&data=
> 02%7C01%7Crasland%40mellanox.com%7Cf9c7646374764638494f08d82c8660
> e1%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C637308302949850
> 241&sdata=jKnsW32l9jGFHayO949aLNzcnWSgoHLNR8TB2hEIJ98%3D&a
> mp;reserved=0
>
>
> --
> David Marchand
On Mon, Jul 20, 2020 at 10:38 AM Raslan Darawsheh <rasland@mellanox.com> wrote:
>
> Hi David,
>
> Yes I noticed it already,
> but it's coming from the fact that it's trying to apply it on a tree that doesn't have the patch which this patch is trying to fix.
>
> ../drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error: '../mlx5_malloc.h' file not found
> #include "../mlx5_malloc.h"
> ^~~~~~~~~~~~~~~~~~
Ok, I see.
Too bad the robot is not testing on the right branch.
--
David Marchand
> -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Monday, July 20, 2020 11:52 AM > To: Raslan Darawsheh <rasland@mellanox.com> > Cc: Ali Alnubani <alialnu@mellanox.com>; dev@dpdk.org; Suanming Mou > <suanmingm@mellanox.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; > Thomas Monjalon <thomas@monjalon.net> > Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build > > On Mon, Jul 20, 2020 at 10:38 AM Raslan Darawsheh > <rasland@mellanox.com> wrote: > > > > Hi David, > > > > Yes I noticed it already, > > but it's coming from the fact that it's trying to apply it on a tree that doesn't > have the patch which this patch is trying to fix. > > > > ../drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error: > '../mlx5_malloc.h' file not found > > #include "../mlx5_malloc.h" > > ^~~~~~~~~~~~~~~~~~ > > Ok, I see. > Too bad the robot is not testing on the right branch. Yes I agree and I guess we need to fix that, who can help with this? > > > -- > David Marchand
On Mon, Jul 20, 2020 at 10:59 AM Raslan Darawsheh <rasland@mellanox.com> wrote: > > > Yes I noticed it already, > > > but it's coming from the fact that it's trying to apply it on a tree that doesn't > > have the patch which this patch is trying to fix. > > > > > > ../drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error: > > '../mlx5_malloc.h' file not found > > > #include "../mlx5_malloc.h" > > > ^~~~~~~~~~~~~~~~~~ > > > > Ok, I see. > > Too bad the robot is not testing on the right branch. > Yes I agree and I guess we need to fix that, who can help with this? Afaik, anyone can fix it. The robot scripts initiated by Aaron are on github: https://github.com/orgcandman/pw-ci -- David Marchand