From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B868A0526; Wed, 8 Jul 2020 15:15:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA2351DB13; Wed, 8 Jul 2020 15:15:41 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id A3FD11DAF3 for ; Wed, 8 Jul 2020 15:15:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594214140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FH0ss0gWwMTe/IFw+gSWu01yCSixNV8QCmtlBOHmaCk=; b=f8Iq1zqvJb6/yOTAY0W+TLF/hhueKm4P3tvDWZWd0ZCHh70RRYwBrA9YoS6iAsuiRfqwYe hpjhOtDHkVrAd9mnzQkqu/A+dMSC/QGZMrWv1eZj8u+wFU9hVAGXfOGBlYWF2q9FFeWf7l sYLgeIcZ/cMFGe9E1ZAxxPPzW3k1X6M= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-THlY8E3ZMo-mA775Da2R-A-1; Wed, 08 Jul 2020 09:15:38 -0400 X-MC-Unique: THlY8E3ZMo-mA775Da2R-A-1 Received: by mail-vs1-f69.google.com with SMTP id a203so427683vsd.5 for ; Wed, 08 Jul 2020 06:15:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FH0ss0gWwMTe/IFw+gSWu01yCSixNV8QCmtlBOHmaCk=; b=nyd9PmvXFyLUi9JaWMiFNwkL85zYBSKA++FtRdZ/DNOZh6Cw7kRj5v4A7CJZpQ9ui1 zNZND8U7S6YG/m0HI7/eLJaURBe8XDqL70EVIKDgMiRNAINZ9AfDLcFy1OKJZmgqKtwZ rK2KxJaYWUysCifMTqDouKl5qkgkhZLr1LFS4ku2en31fTeF6GhMFa+1IU9jdvWEphDr hBrpBkSi9m/EDTavTYqkQUH4bEzv5Vka/Y9qYiEXycB1Co3ho6JHBCIXD2wkYpMEDEVn Nur1NnrraSObTik2BykrLs5b4XnkXMZzig3sqvgReFndSdCVzIRc5xSiRqoXoa5WqVaG 3+DQ== X-Gm-Message-State: AOAM532m0LzRPHBamVYsCtJlpwSU724dohm7JiRPVwf27HimXnsJ51sL hR2L7mi2hTa5m7ZLxN8D5aWW+cnFq44ZOOVCxBduXiAlBRFaqUXP7BsaH1UlkgvPj6EPbmYhvuO 8l3IHEjcPTlTlJm0PxmQ= X-Received: by 2002:ab0:6950:: with SMTP id c16mr10938893uas.53.1594214136987; Wed, 08 Jul 2020 06:15:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAfFIaP/CO9SZbwY2F0KxDMSDwb/QS/LLHrfPr27M56g4HNGsy6ZN+A+pJqkuW+tSg6fRE9u+n05lpR+jfiFc= X-Received: by 2002:ab0:6950:: with SMTP id c16mr10938866uas.53.1594214136748; Wed, 08 Jul 2020 06:15:36 -0700 (PDT) MIME-Version: 1.0 References: <20200708102212.3311-1-david.marchand@redhat.com> <91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu> In-Reply-To: <91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu> From: David Marchand Date: Wed, 8 Jul 2020 15:15:25 +0200 Message-ID: To: "Kinsella, Ray" Cc: dev , Thomas Monjalon , Dodji Seketeli , Neil Horman , Aaron Conole Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 8, 2020 at 3:09 PM Kinsella, Ray wrote: > > + Aaron > > On 08/07/2020 11:22, David Marchand wrote: > > abidiff can provide some more information about the ABI difference it > > detected. > > In all cases, a discussion on the mailing must happen but we can give > > some hints to know if this is a problem with the script calling abidiff, > > a potential ABI breakage or an unambiguous ABI breakage. > > > > Signed-off-by: David Marchand > > --- > > devtools/check-abi.sh | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh > > index e17fedbd9f..521e2cce7c 100755 > > --- a/devtools/check-abi.sh > > +++ b/devtools/check-abi.sh > > @@ -50,10 +50,22 @@ for dump in $(find $refdir -name "*.dump"); do > > error=1 > > continue > > fi > > - if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then > > + abidiff $ABIDIFF_OPTIONS $dump $dump2 || { > > + abiret=$? > > echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'" > > error=1 > > - fi > > + echo > > + if [ $(($abiret & 3)) != 0 ]; then > > + echo "ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org." Forgot to --amend. Hopefully yes, this will be reported to dev@dpdk.org... I wanted to highlight this could be a script or env issue. > > + fi > > + if [ $(($abiret & 4)) != 0 ]; then > > + echo "ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue)." > > + fi > > + if [ $(($abiret & 8)) != 0 ]; then > > + echo "ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI." > > + fi > > + echo > > + } > > done > > > > [ -z "$error" ] || [ -n "$warnonly" ] > > > > This look good to me, my only thought was can we do anything to help the ABI checks play nice with Travis. > At the moment it takes time to find the failure reason in the Travis log. I usually look for "FILES_TO" to get to the last error. -- David Marchand