From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70855A0C43; Tue, 16 Nov 2021 13:04:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C54040141; Tue, 16 Nov 2021 13:04:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 660D240040 for ; Tue, 16 Nov 2021 13:04:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637064260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AgiiZpPI5xUgLU3cYZ0467U50UwLSB0uLfRxzrk1b+4=; b=aPP4gHmtz6wCnF0OtyyAr9GlU3dFOb5S5S/fRSZwnw2r8DyduSQ49dNEj1Z8Ut6TkdVE3I 5DSRR8bST3WfGhGOcpE0njmf3TiNqHIj1ZdE2pW92+AjEyz1DMeXwj7x3qNyRxTFhrRnRi I9MwXkVQJcP62SGUp/L1cUX/BFm3HxA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-510-8DM25OgzMF2GuaS3LGZnHg-1; Tue, 16 Nov 2021 07:04:19 -0500 X-MC-Unique: 8DM25OgzMF2GuaS3LGZnHg-1 Received: by mail-lf1-f70.google.com with SMTP id bp10-20020a056512158a00b0040376f60e35so8119414lfb.8 for ; Tue, 16 Nov 2021 04:04:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AgiiZpPI5xUgLU3cYZ0467U50UwLSB0uLfRxzrk1b+4=; b=RDQCt1cWrZKA5UZGHWcO44tXC8ERwotd3s06KYc0qA5BdS7RKp+aCYbWTj2TBvwu4w V+Q8iAXXKCJyENZgdYVhmrgl1H2Ga9mnvKZ+n34gPkxJOMyI31oPa0W9W5g17iflkJOQ M+1BUCeJVCkURk4+fT6DMJRELY6P3mPPTb38nz/cdwS4jthKUxUUiT1o6o6tIbzXrTOC mSy8M+a8aImre/FvMHfmZVVoyCsk+tHTNTxtcAz/eaZ6nDobSCUfJAfdZ+a0CWzCefUB QTw5LZZ+g2thptw6VEDSoyX0mohh7kfWtliRhRPuLBISuNkqC/hCKO0DZKW1KsR0cazs EecQ== X-Gm-Message-State: AOAM53142dPuK+Th8KkXtWKgx4otnlC1QL2Qj3PkKng7bwE4IR0Cvllx Oc5PSqloC+GAiRweu2aqcBmvsY9D5kSJjCejqA1GAPkN9fLKqraDG8uTuaaedJMpIgG91h6gLhF qqUeKFSnFn6qOa9oqDls= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr5924233lfv.560.1637064258092; Tue, 16 Nov 2021 04:04:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJyoLAJ3cWV6hPWi6SwNM2apF6/WOBhgZY3JQbtOJ0yS0OF2cwhyx0+YEyhE23UxUc6raaJb2mNVoshayez3aSk= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr5924143lfv.560.1637064257665; Tue, 16 Nov 2021 04:04:17 -0800 (PST) MIME-Version: 1.0 References: <20211112140111.922171-1-conor.walsh@intel.com> <20211115175855.1091621-1-conor.walsh@intel.com> <20211115175855.1091621-6-conor.walsh@intel.com> In-Reply-To: <20211115175855.1091621-6-conor.walsh@intel.com> From: David Marchand Date: Tue, 16 Nov 2021 13:04:06 +0100 Message-ID: Subject: Re: [PATCH 5/6] drivers/net: fix unused but set variables To: Conor Walsh Cc: "Yigit, Ferruh" , "Liang, LongfengX" , dev , David Hunt , "Wang, Yipeng1" , "Gobriel, Sameh" , Bruce Richardson , Vladimir Medvedkin , Hemant Agrawal , Sachin Saxena , "Trahe, Fiona" , John Griffin , Deepak Kumar Jain , Van Haaren Harry , Ajit Khaparde , Somnath Kotur , Ziyang Xuan , Xiaoyun Wang , Shijith Thotton , Srisivasubramanian Srinivasan , heinrich.kuhn@corigine.com, Harman Kalra , Rasesh Mody , Devendra Singh Rawat , Jiawen Wu , Yong Wang , "Mcnamara, John" , Akhil Goyal , Fan Zhang , "Kusztal, ArkadiuszX" , michael.baucom@broadcom.com, Venkat Duvvuru , Lance Richardson , kishore.padmanabha@broadcom.com, Jerin Jacob , mjatharakonda@oneconvergence.com, simon.horman@corigine.com, david.george@sophos.com, sony.chacko@qlogic.com, harish.patil@qlogic.com, Stephen Hemminger , Jerin Jacob , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 15, 2021 at 6:59 PM Conor Walsh wrote: > > This patch fixes unused but set variables in the following net drivers: > - bnxt > - hinic > - liquidio > - nfp > - octeontx > - qede > - txgbe > - vmxnet3 > > Bugzilla ID: 881 > Fixes: b87abb2e55cb ("net/bnxt: support marking packet") > Fixes: 88badb3aef94 ("net/bnxt: add helper functions for blob/regfile ops") > Fixes: a4957d87e05a ("net/hinic/base: add mgmt module") > Fixes: 5ee7640f95a0 ("net/liquidio: add API to flush IQ") > Fixes: 19af5a38f7b6 ("net/nfp: move CPP bridge to separate file") This change only moves code, it should be: Fixes: 29a62d1476b6 ("net/nfp: add CPP bridge as service") I will fix while applying. > Fixes: 9eb5cb3b11cc ("net/octeontx: fix access to indirect buffers") > Fixes: 86a2265e59d7 ("qede: add SRIOV support") > Fixes: b7311360fb67 ("net/txgbe: support VF interrupt") > Fixes: c3ecdbb376da ("vmxnet3: support TSO") Putting everything in a single patch will make life a bit harder for backports: we have candidates for backports in 19.11 and 20.11, and some patches are not relevant to backport. I'll split this patch per driver since the Fixes: tags for each driver only affect one version. > Cc: stable@dpdk.org > > Reported-by: Liang Longfeng > Signed-off-by: Conor Walsh Reviewed-by: David Marchand -- David Marchand