From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B67442DE6; Thu, 6 Jul 2023 10:53:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49ACD40F16; Thu, 6 Jul 2023 10:53:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 46C7940A79 for ; Thu, 6 Jul 2023 10:53:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688633581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E5CmGdn67FNOekNVJq2jmHfOMsjE81vjr3h1Z6pt5uw=; b=IIfoP0Ae7BF1tczwM3FqH4NiFdvK9rSghih6bAOpolxIvfuUAvyQloHiZBGiyE5tL3NYjB 1uv3hQu5bkuDxZnBSsB4Od8NzZIRFSU0ZYBk0I6Ewr7RY7rlZRdUff660CxyBIEE0hVv7l HwxHTT3dJ79Zd1hDEQEMMO6dg/JdrQc= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-75-ocwRxxwlNmiGtIYKkPCOxw-1; Thu, 06 Jul 2023 04:53:00 -0400 X-MC-Unique: ocwRxxwlNmiGtIYKkPCOxw-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-262c77ffb9dso692183a91.2 for ; Thu, 06 Jul 2023 01:53:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688633579; x=1691225579; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E5CmGdn67FNOekNVJq2jmHfOMsjE81vjr3h1Z6pt5uw=; b=Lp+DQK9ytDdXKcQaP3nf2woWoMB2bRajc0XAX0ql+p/bxO1KU5qzDnQ1JSGDL6WQe9 kDxOvgfJ2w4HwV8y6hLXPlzceKbaiKSar1znwKyiZ4W/omCgiLT5Vi092DFbr+BRAgKx P/nGmPeSbMKN6U31ibJSQQKja2ydaQLm+FLp8aA2QvL9F/Mh5p+CbrK6rCib6ZmUn9Ui O1LesrBZDzW1bYH00l92IgVbUBE4m4qJ1Tzo+rPohdWH+1Z1VtlQkrygC/luF/mEzZ1I YAOHBKGaxKRmoHvPxSTBlJ1kre+Gs7ZpEEiNNfhmn9wKf7y5ai+JM4JO1S0liuw3Wgpu E7ow== X-Gm-Message-State: ABy/qLbrGSZkzcgZJp0J8jdDlpbxXyYGcZmsbvbGFFUxju9JssH1EbKI 2zumMXc/1guwxtBGCZ4QdySPzUIprWG95pxnGX+4+TO3pMmDADJ7LFPRGkLddGZr+00qKCQr+Bo Mx3+UwAltOWTpwAL/kXs= X-Received: by 2002:a17:90a:4414:b0:262:ea83:ed34 with SMTP id s20-20020a17090a441400b00262ea83ed34mr1251402pjg.0.1688633579527; Thu, 06 Jul 2023 01:52:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlELh3HrhhywdAfF47NoFYaSho7XaBT814M+od90issdbe+IaVE4o5ZgUQoA2ztjIYOQcLSVpz9HGH/ESdoES5Y= X-Received: by 2002:a17:90a:4414:b0:262:ea83:ed34 with SMTP id s20-20020a17090a441400b00262ea83ed34mr1251388pjg.0.1688633579270; Thu, 06 Jul 2023 01:52:59 -0700 (PDT) MIME-Version: 1.0 References: <20230131022841.10775-1-haijie1@huawei.com> <4273274.ejJDZkT8p0@thomas> <2c9f8137-4af7-d139-c69a-76d03208c669@huawei.com> <3043990.CbtlEUcBR6@thomas> In-Reply-To: <3043990.CbtlEUcBR6@thomas> From: David Marchand Date: Thu, 6 Jul 2023 10:52:47 +0200 Message-ID: Subject: Re: [PATCH v4 3/3] ring: add telemetry cmd for ring info To: Thomas Monjalon Cc: Jie Hai , honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru, dev@dpdk.org, liudongdong3@huawei.com, bruce.richardson@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 4, 2023 at 4:11=E2=80=AFPM Thomas Monjalon wrote: > > 04/07/2023 10:04, Jie Hai: > > On 2023/6/20 22:34, Thomas Monjalon wrote: > > > 20/06/2023 10:14, Jie Hai: > > >> On 2023/2/20 20:55, David Marchand wrote: > > >>> On Fri, Feb 10, 2023 at 3:50 AM Jie Hai wrote: > > >>>> > > >>>> This patch supports dump of ring information by its name. > > >>>> An example using this command is shown below: > > >>>> > > >>>> --> /ring/info,MP_mb_pool_0 > > >>>> { > > >>>> "/ring/info": { > > >>>> "name": "MP_mb_pool_0", > > >>>> "socket": 0, > > >>>> "flags": "0x0", > > >>>> "producer_type": "MP", > > >>>> "consumer_type": "MC", > > >>>> "size": 262144, > > >>>> "mask": "0x3ffff", > > >>>> "capacity": 262143, > > >>>> "used_count": 153197, > > >>>> "consumer_tail": 2259, > > >>>> "consumer_head": 2259, > > >>>> "producer_tail": 155456, > > >>>> "producer_head": 155456, > > >>> > > >>> What would an external user make of such an information? > > >>> > > >>> I'd like to have a better idea what your usecase is. > > >>> If it is for debugging, well, gdb is probably a better candidate. > > >>> > > >>> > > >> Hi David, > > >> Thanks for your question and I'm sorry for getting back to you so la= te. > > >> There was a problem with my mailbox and I lost all my mails. > > >> > > >> The ring information exported by telemetry can be used to check the = ring > > >> status periodically during normal use. When an error occurs, the fau= lt > > >> cause can be deduced based on the information. > > >> GDB is more suitable for locating errors only when they are sure tha= t > > >> errors will occur. > > > > > > Yes, when an error occurs, you can use GDB, > > > and you don't need all these internal values in telemetry. > > > > > > > > Hi, David, Thomas, > > > > Would it be better to delete the last four items? > > "consumer_tail": 2259, > > "consumer_head": 2259, > > "producer_tail": 155456, > > "producer_head": 155456, > > Yes it would be better. > David, other maintainers, would it make the telemetry command a good idea= ? > > Without the ring head/tail exposed, it seems ok. It still exposes the ring flags which are kind of internal things, but those are parts of the API/ABI, iiuc, so it should not be an issue. --=20 David Marchand