From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A78041C61; Fri, 10 Feb 2023 15:24:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07A36410D3; Fri, 10 Feb 2023 15:24:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AD886410D0 for ; Fri, 10 Feb 2023 15:24:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676039076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3x4UAQF6nK0yNzqphv3aCV5ZtEDfzzUZyjZxlUP4AWA=; b=SZh4dwJhJHQuYBlSM3/ab2t2bStDW+Vp0CEC+zHHfDV8aqxjx+hJSaZdJapZ+oEUMj8Je5 CyHui1CRS8Br5mIt0Jnz/hvluS0VNvHkGYB0aqQWR5o98M3YaDKA3LW65VB2lVuSbj01Rh 70vQMK6sGwuehO93j7947vQJdFSIED0= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-633-ObEyGdsjOJyANQgwr2IuhQ-1; Fri, 10 Feb 2023 09:24:34 -0500 X-MC-Unique: ObEyGdsjOJyANQgwr2IuhQ-1 Received: by mail-pj1-f72.google.com with SMTP id l22-20020a17090aaa9600b00230aa3c1350so2511783pjq.2 for ; Fri, 10 Feb 2023 06:24:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3x4UAQF6nK0yNzqphv3aCV5ZtEDfzzUZyjZxlUP4AWA=; b=Y5NNqesGmZg6A5bTl3uyRq48yE/7NE5j47sPUXhCR4vXoAlVFcCeAP3d+J6HzRWnnO N9MIdXPcFyoc6s0UVCYRqpDRphxvVzlWOYwP3UDyjPfH6GK/LxlhOBTNeeX8MmlQc44k UJfundbCUye/wcaJOYExX5I5vMB1pL6sJH9zWSqKV/9O6qbtmG9aFY6xTb2IEEnktUol TJqNDGxilkgYTp9HbVlfoJvbbzRQDjQuaAO62WM64k+D1PpPeFjbfWkavmXtHgwutpsf IkhGtyGRj3NQZS0RwDML5u9EJ8H6ieSZZpQxmnpEszuWbPvI9BCdMj+dbBCp1aA1oknt 2DwA== X-Gm-Message-State: AO0yUKWRSGlkstJ1XAdMY86gg+MJfK8HWjc2EHmv2YazWiYB+sQmXaN3 5DPf2McKUBNOyzyYxVNMX/VAtjQw36urGZ77hVsrpfHjSrt9RG4d+qDwnsKP7CpNxzN6P2e/nlG q49Ls0COFMBvHlRnEbTM= X-Received: by 2002:a17:90a:8592:b0:230:b57f:5229 with SMTP id m18-20020a17090a859200b00230b57f5229mr2627723pjn.68.1676039073533; Fri, 10 Feb 2023 06:24:33 -0800 (PST) X-Google-Smtp-Source: AK7set/108q0QxHB2fL8bGMCr7JABbyw0uooC4jSIt6rKkN6iKW+YP8Sb91Uv537fOOLGbxraUFqVw/yQxV9uLGKJmc= X-Received: by 2002:a17:90a:8592:b0:230:b57f:5229 with SMTP id m18-20020a17090a859200b00230b57f5229mr2627717pjn.68.1676039073248; Fri, 10 Feb 2023 06:24:33 -0800 (PST) MIME-Version: 1.0 References: <20230209133019.933380-1-adwivedi@marvell.com> <20230209133019.933380-2-adwivedi@marvell.com> In-Reply-To: From: David Marchand Date: Fri, 10 Feb 2023 15:24:22 +0100 Message-ID: Subject: Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map To: Jerin Jacob , Ankur Dwivedi Cc: "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , Jerin Jacob Kollanukkaran X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote: > > On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi wrote: > > > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > > >wrote: > > >> > > >> The file rte_mempool_trace.h contains tracepoints which are internal > > >> to the mempool library. This file is renamed to mempool_trace.h, and > > >> is made an internal header. The tracepoints in this file are removed > > >> from the experimental section in version.map file. > > >> > > >> Signed-off-by: Ankur Dwivedi > > > > > >> @@ -47,22 +47,8 @@ EXPERIMENTAL { > > >> __rte_mempool_trace_generic_get; > > >> __rte_mempool_trace_get_bulk; > > >> __rte_mempool_trace_get_contig_blocks; > > > > > >I think, FP ones also can be removed. > > > > The FP symbols are used in header file rte_mempool.h. Removing the symbols will cause build > > failure in shared build. > > OK. Please update the below note documentation only for FP symbols then. I disagree. We may enhance this note, but it is not a matter of being FP / non-FP. A simple example is the "generic" non-FP tracepoints provided by EAL. -- David Marchand