From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A79C4545B; Fri, 14 Jun 2024 16:33:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29E7B40BA2; Fri, 14 Jun 2024 16:33:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8189A40BA2 for <dev@dpdk.org>; Fri, 14 Jun 2024 16:33:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718375588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2md2oAzawuEcpVvTmS8DvwgY6F1XmSpT6zM9hV3GGNA=; b=KWNQEbcMQojHd05DZ+DZpTOeBQJL0ZaGKGYr3GVK93I4mMeOvIAK6jLFh/hPMPaCKnEdsZ 8Ac21Tu1FSt3T3ifUXTnbLFoZ4GtB+L+Gz+mQeXFzE/fmZKZyy9ob+fR0Eu2S7TcK8QbAR soIXAecwVbbU7RVYnj4u7rKvj4sjH0s= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-FvCwQlnrP2qG-OMjyYDJJg-1; Fri, 14 Jun 2024 10:33:06 -0400 X-MC-Unique: FvCwQlnrP2qG-OMjyYDJJg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ea892f8441so16355491fa.1 for <dev@dpdk.org>; Fri, 14 Jun 2024 07:33:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718375585; x=1718980385; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2md2oAzawuEcpVvTmS8DvwgY6F1XmSpT6zM9hV3GGNA=; b=jsZyEGyijm6hu+KMXnKLAOcAeXUIyGFV64Z9ajIod7U81fj8pByqBvqO6LV6oJ2iK0 6V5HsFA5veAbBa965ZCvK9XBNDGqHEAP/9LdX01zHi12YbBF8wlij032BFE4oHWOZ7+k x+tmIAlaSHmMN694mVjEHEU9iwfY2DMCo6n88bBnwoS59MkfStAjTivO5B802G7A942R npTClT24kYgDuOJNl8Zs7GmKCDzquMTLYNksclxIwYC0/x8kLHQ5xRhkuJa5oWoHZgDv 1PGD3UXTbHkYNUHUtdzvcPLNudAnqg3MVUNXodQCjjwplmxxgLdPP/BD5mod4AWjjFGU /SdQ== X-Gm-Message-State: AOJu0YyjsShA8Z9KWw4oBTCgcVqzOUBFmjZrB/PrLrQ8TxjVdml7C3PJ 9AWHkPkcR52hPAaD1C1aZlieqXYBbXUYnFgxOQb5G42ExK3Hr2Q02LxMnXBtHirejAx4FVt5Sd1 HZQgxpdkukJdFY3pL6unq6CuyE4St4B5984N2uMj+e7nRzYjrohy9eH7BhtXQn2JbQj43DKmCSQ GQpkhEJSSWwM2Jp9E= X-Received: by 2002:a2e:9055:0:b0:2ec:1890:5ec with SMTP id 38308e7fff4ca-2ec18900778mr11687051fa.41.1718375585363; Fri, 14 Jun 2024 07:33:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoj/2YX76E6mhDzQ/UyHC/PpickYodTLjYPg9Kqx8qKqIwnOYDpXTXtoCaTEgk5whN9H9lwKQX9DB1UGsgl84= X-Received: by 2002:a2e:9055:0:b0:2ec:1890:5ec with SMTP id 38308e7fff4ca-2ec18900778mr11686941fa.41.1718375584975; Fri, 14 Jun 2024 07:33:04 -0700 (PDT) MIME-Version: 1.0 References: <1710970416-27841-1-git-send-email-roretzla@linux.microsoft.com> <1710970416-27841-3-git-send-email-roretzla@linux.microsoft.com> <4023574.2iPT33SAM4@thomas> In-Reply-To: <4023574.2iPT33SAM4@thomas> From: David Marchand <david.marchand@redhat.com> Date: Fri, 14 Jun 2024 16:32:52 +0200 Message-ID: <CAJFAV8yaU2=xs1=m3icuWTEz68_1KiqpUcPha6E6wQ9qKa8jOw@mail.gmail.com> Subject: Re: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin To: Thomas Monjalon <thomas@monjalon.net>, Tyler Retzlaff <roretzla@linux.microsoft.com> Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, May 29, 2024 at 4:51=E2=80=AFPM Thomas Monjalon <thomas@monjalon.ne= t> wrote: > > 20/03/2024 22:33, Tyler Retzlaff: > > Use newly introduced __rte_constant(e) macro instead of directly using > > __builtin_constant_p() allowing mempool to be built by MSVC. > > Does it mean we should enable mempool build? > If yes, please send a v2. I guess now it is possible, as I merged some other patches on mempool from Stephen that were for MSVC. Tyler, can you send a v2 so it passes through the CI? Thanks. --=20 David Marchand