Re: [dpdk-dev] [PATCH 2/3] net/bnxt: fix ver get HWRM command

[David Marchand <david.marchand@redhat.com>]

Hi Ajit,

On Thu, Mar 17, 2022 at 5:48 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
> > On Tue, Mar 1, 2022 at 1:53 PM David Marchand <david.marchand@redhat.com> wrote:
> > > On Thu, Mar 4, 2021 at 9:45 AM Kalesh A P
> > > <kalesh-anakkur.purayil@broadcom.com> wrote:
> > > >
> > > > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> > > >
> > > > Fix HWRM_VER_GET command to handle DEV_NOT_RDY state.
> > > >
> > > > Driver should fail probe if the device is not ready.
> > > > Conversely, the HWRM_VER_GET poll after reset can safely
> > > > retry until the existing timeout is exceeded.
> > > >
> > > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> > > > Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> > > > Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
> > > > Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> > >
> > > This patch makes probing fail on a RHEL9 kernel with firmwares:
> > > firmware-version: 20.6.143.0/pkg 20.06.04.06
> > > and
> > > firmware-version: 20.6.112.0
> Oh wow! That's really old FW.

Well, hard to tell it is old, from my side.

I found a few nics in our lab that show similar firmware versions.
As you can see, QE have some servers with such nics too.


> > If there is no other option, I will send a revert for this patch.
> A version check may help avoid a complete revert.
> But that will require some testing, which means we are looking at
> mid-next week for the fix.
>
> Submit the revert patch, just in case it takes longer than that.

I'll do that.
Thanks.


-- 
David Marchand