From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADC20A0093; Fri, 18 Mar 2022 15:54:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68FAE40DF7; Fri, 18 Mar 2022 15:54:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B05BC4068A for ; Fri, 18 Mar 2022 15:54:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647615259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xbbC/fL1KiXnGWIoHOmNUD7EiQzGG9Cb9KQEbb/8jAw=; b=Tv4Hl7h3Nj4+7euivQFt6kmPGkdwFs7atpejFqoO1QBmPjdRkKT5/CVwBSjIr3SBuHrkQN hvww2lxbOiTTonoopbQ36OabgnJeX2gKRg4WsGjzJUss0aVTuRKNio58Tw6++S7xG0ACWx t8Eh4WmlTmU2kl967O/pxzk3jTkmsjg= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-134-ht_ubXc_NPi1bSXaFuwpJA-1; Fri, 18 Mar 2022 10:54:01 -0400 X-MC-Unique: ht_ubXc_NPi1bSXaFuwpJA-1 Received: by mail-lj1-f199.google.com with SMTP id a23-20020a05651c031700b00247fd91c2b5so3520465ljp.21 for ; Fri, 18 Mar 2022 07:54:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xbbC/fL1KiXnGWIoHOmNUD7EiQzGG9Cb9KQEbb/8jAw=; b=zG4EYSLd/grfhOv7b9CwzGizecojnMiWjC+pFPcKXze1Od5wPDJGkWUsbVTMhC97Sr yWf6WQPKsLSXfiMbRBhqSkzuVnxPZ5bLwE+rfi2blyecGio+isZ1pP62tVoPqZp3b3tk 3f8ZTxFfg9g8ii6S9phie31X1s6NkE5frOVE5Di/+aVUtGQyrBDqhNUBWHN/4M5MzfWv 8aPNV/labaA2RLUXd+bFjpsIJyXHgruYBJCvVnJW4n6kDJSCuRr9HcRWS6h8rrf6mobS YZyi1dbc6jcxa0wwITavd0LhKvjYxucIEL7909gJvciFZdauOAsejjB2mR4EqDibkC5E Osvw== X-Gm-Message-State: AOAM532Pu28G1+ONY9wKz+zFUkTjg+ZaQiuZHEyLeg4g1xB2H2MC5oEK wRu4Bs7AanY3IAZo8W2E8uloqaN9x/x/SJdcRYD507xIGannwIjh4ioGem/QIbayQ7Hg3ivW4SK B+hjUKEiqt2lOvOw7VRE= X-Received: by 2002:a2e:8603:0:b0:23a:6193:e2e2 with SMTP id a3-20020a2e8603000000b0023a6193e2e2mr6436176lji.333.1647615239874; Fri, 18 Mar 2022 07:53:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrqim9HZFbhwDvd2XTvtuw4XgZGQzYL8qxU66OJ+zbDWyQn3GFczusRUqfdDqlskp1U+dUspXmLFhlnO6Cnfg= X-Received: by 2002:a2e:8603:0:b0:23a:6193:e2e2 with SMTP id a3-20020a2e8603000000b0023a6193e2e2mr6436164lji.333.1647615239578; Fri, 18 Mar 2022 07:53:59 -0700 (PDT) MIME-Version: 1.0 References: <20210304090728.26166-1-kalesh-anakkur.purayil@broadcom.com> <20210304090728.26166-3-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: From: David Marchand Date: Fri, 18 Mar 2022 15:53:48 +0100 Message-ID: Subject: Re: [dpdk-dev] [PATCH 2/3] net/bnxt: fix ver get HWRM command To: Ajit Khaparde Cc: Kalesh A P , dev , Thomas Monjalon , Kevin Traynor , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ajit, On Thu, Mar 17, 2022 at 5:48 PM Ajit Khaparde wrote: > > On Tue, Mar 1, 2022 at 1:53 PM David Marchand wrote: > > > On Thu, Mar 4, 2021 at 9:45 AM Kalesh A P > > > wrote: > > > > > > > > From: Kalesh AP > > > > > > > > Fix HWRM_VER_GET command to handle DEV_NOT_RDY state. > > > > > > > > Driver should fail probe if the device is not ready. > > > > Conversely, the HWRM_VER_GET poll after reset can safely > > > > retry until the existing timeout is exceeded. > > > > > > > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Kalesh AP > > > > Reviewed-by: Somnath Kotur > > > > Reviewed-by: Randy Schacher > > > > Reviewed-by: Ajit Kumar Khaparde > > > > > > This patch makes probing fail on a RHEL9 kernel with firmwares: > > > firmware-version: 20.6.143.0/pkg 20.06.04.06 > > > and > > > firmware-version: 20.6.112.0 > Oh wow! That's really old FW. Well, hard to tell it is old, from my side. I found a few nics in our lab that show similar firmware versions. As you can see, QE have some servers with such nics too. > > If there is no other option, I will send a revert for this patch. > A version check may help avoid a complete revert. > But that will require some testing, which means we are looking at > mid-next week for the fix. > > Submit the revert patch, just in case it takes longer than that. I'll do that. Thanks. -- David Marchand