From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35002A00BE; Mon, 25 Apr 2022 10:25:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C671241109; Mon, 25 Apr 2022 10:25:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 987B8410E6 for ; Mon, 25 Apr 2022 10:25:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650875144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MORRr1zHi1alKN8S7EvvoXGcdea6nDLPS1N7pfb80Bg=; b=U4HQOy94mkw2XA2suF+Yj3dvXIWfqmTyuB2kYad0tfcljADKECEFyNLSGQJjX4gGPwMSSS RJVt25o8d0lJEbVClh0BItLh2J+/nNZxsWjNJreViziBYIYkug7Ep/9rOU50H444TJPAZs T8SAy3R1qg1hrCtrWtTrYcbptz7gu9Q= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-55-5EMMTpCQP42oQPvLgFu4WQ-1; Mon, 25 Apr 2022 04:25:43 -0400 X-MC-Unique: 5EMMTpCQP42oQPvLgFu4WQ-1 Received: by mail-lj1-f200.google.com with SMTP id l16-20020a2e5710000000b0024f0c34eff1so504609ljb.10 for ; Mon, 25 Apr 2022 01:25:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MORRr1zHi1alKN8S7EvvoXGcdea6nDLPS1N7pfb80Bg=; b=0pQ6PK3gXii03B/Bqi2PftujIFRo7EUU6N/vQw/URwe+w28N/eV4/MqGBSlSsPeMhK EbE1FV297yz0VEwuoclTpBzALmJGymTrb/KJw/rwoVTQsq6e5HHzaJzgksNNva0e6eeT ME9ZqfDOrajRqfOyAb13LOEptq8HDd2/xqUZmT/6J/S/0bu7Hqfg2WZP0TTr91r+QpZZ bovdOgCpNkNp7sAHCoq6amyG+B9qMJsjUfnVFkam+tnRCije5prbLIqdWvrtm5jGX/2W NW9JjF0TY+8dO/h+T/Q+tHu+ecvB3i0bRiSUl4xl0yrPtz91CHZBJ7roCH9heVaNPWof j/rg== X-Gm-Message-State: AOAM533MbB20BgPR+nW52EmxPAKEZt754quuO6LPVWPLbMP92wXnsHNp fDmPE+sBm+GyZ0V81EFF0rjiMfF8dkgUda8SmKPTQvjXAY3ZrsjIcofFQ2B3AOvWqFkNxD3iljV Kahbltc9/b6t1eIBzRyY= X-Received: by 2002:a05:6512:1326:b0:45a:3a4:f25a with SMTP id x38-20020a056512132600b0045a03a4f25amr12071116lfu.575.1650875141960; Mon, 25 Apr 2022 01:25:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLR+9RwcwPgz47AnyTdOu9d3Ec4LOvBr0dUQ69VOIgWbu4YFdqygOr/jH+amL60lEVTzkqcxs3V3wD02ZXC54= X-Received: by 2002:a05:6512:1326:b0:45a:3a4:f25a with SMTP id x38-20020a056512132600b0045a03a4f25amr12071103lfu.575.1650875141716; Mon, 25 Apr 2022 01:25:41 -0700 (PDT) MIME-Version: 1.0 References: <1648819793-18948-1-git-send-email-roretzla@linux.microsoft.com> <1649760220-8683-1-git-send-email-roretzla@linux.microsoft.com> <1649760220-8683-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1649760220-8683-2-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Mon, 25 Apr 2022 10:25:30 +0200 Message-ID: Subject: Re: [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors To: Tyler Retzlaff Cc: dev , Thomas Monjalon , Dmitry Kozlyuk , "Burakov, Anatoly" , Narcisa Vasile Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 12, 2022 at 12:44 PM Tyler Retzlaff wrote: > > Add function to translate Windows error codes to errno-style error > codes. The possible return values are chosen so that we have as > much semantical compatibility between platforms as possible. > > Signed-off-by: Narcisa Vasile > Signed-off-by: Tyler Retzlaff This patch alone does not make sense, and I guess it breaks compilation on Windows if we stop at it during a bisect (because it adds two unused static symbols). It can be squashed in patch 3 where thread_log_last_error is first used. -- David Marchand