From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14138A0543; Tue, 21 Jun 2022 11:06:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A5504069C; Tue, 21 Jun 2022 11:06:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A0B3340151 for ; Tue, 21 Jun 2022 11:06:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655802411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lkb8253pnmRtof+5/aRgG7uKhH8/YL7L8GG9jEd+JzA=; b=DvAzcfqBahtFrroJCMqu31bwhu7+JTC+bCUCqHvgp/s38uSECmV7slXKzC4Hk6NgxhpAlB XX2eIhD8tEMEV+6IOWX3XQLtLPpYhI8V+kNSqL54JXByj4pWrfQ2a6KaKpgYcM6OYMwBRD qzc223ZtqrkshbnfZdlYz7s4w9hOk1g= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-DBmj3np_OY6fTMHbcQanjA-1; Tue, 21 Jun 2022 05:06:49 -0400 X-MC-Unique: DBmj3np_OY6fTMHbcQanjA-1 Received: by mail-lf1-f72.google.com with SMTP id cf10-20020a056512280a00b0047f5a295656so4096019lfb.15 for ; Tue, 21 Jun 2022 02:06:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lkb8253pnmRtof+5/aRgG7uKhH8/YL7L8GG9jEd+JzA=; b=t2NmfWyIMPmqW7Z5JW2q460lKEzUQjRLKuoLV7EIAfMejlqG3pJrd3Jooo/Imj/f2A mbE/ni+nU1VZGGfuzkvSRM6qQCfW+dWHaHxbxDPH0sh8rlls59LgSORuYTnyjEBcGfk5 J0IYUCH+o6msF2wsO0Dn3xKVevo8BBSvYQg5dGoVlEpZqt6O3y3KYQJMYZtr/ryhLyZJ /QjL/wceOzbAoEvFwo6JYQvqTeW+2+GRt1eDZvjUC3fGZHMWPVyMxF5RVlKe62re0INi 2ILKluKHd54zcHXf3N3VVBX7ZgxfIY7UGkvoy8Z1VzSnBGF9KAtYKsEpWfKEPnG7/FaT hJRw== X-Gm-Message-State: AJIora9Be5trd9hZ90MkqwYZsLpBvT5SYckQ9oc/bFJ8FED30/nSsoVe lF9YkMof/Trf+YD4q/ds5Gt31bDKx74JtXip86JO5/vU1jcSI0uBIkTSwdl8MoeHNWb80M8C5ZR +2pn9hkuHDyjRDknd8DA= X-Received: by 2002:a05:6512:13a0:b0:47f:709d:dc11 with SMTP id p32-20020a05651213a000b0047f709ddc11mr4725043lfa.265.1655802408241; Tue, 21 Jun 2022 02:06:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sjcFm4fjGfmNmr3ycqI6qfpQICf9uoHg20wPIwNqDet/sD4XfQU/yUvKKJSO56He4to76NXViLFUGRO3oQyeM= X-Received: by 2002:a05:6512:13a0:b0:47f:709d:dc11 with SMTP id p32-20020a05651213a000b0047f709ddc11mr4725028lfa.265.1655802408024; Tue, 21 Jun 2022 02:06:48 -0700 (PDT) MIME-Version: 1.0 References: <20220607120014.49823-1-fengchengwen@huawei.com> <20220614055900.22848-1-fengchengwen@huawei.com> <20220614055900.22848-4-fengchengwen@huawei.com> <382eda43-9a03-60b9-ea8c-316e44a29d1f@huawei.com> In-Reply-To: <382eda43-9a03-60b9-ea8c-316e44a29d1f@huawei.com> From: David Marchand Date: Tue, 21 Jun 2022 11:06:37 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] test: support trace-autotest when enable trace To: fengchengwen Cc: Aaron Conole , Thomas Monjalon , dev , "Burakov, Anatoly" , Jerin Jacob Kollanukkaran , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 17, 2022 at 4:43 AM fengchengwen wrote: > > Hi David, thanks for your review. > > On 2022/6/15 22:00, David Marchand wrote: > > On Tue, Jun 14, 2022 at 8:06 AM Chengwen Feng wrote: > >> > >> There are a bug[1] when exit application while enable tracing, this > >> bug has not been discovered for a long time, to quickly detect such > >> bugs, this patch was introduced. > >> > >> This patch adds a testcase with trace enabling, it also depends on > >> patch[2] because it has a long file-prefix. > >> > >> [1] eal: fix segment fault when exit trace > >> [2] eal: fix trace init fail with long file-prefix > > > > This commitlog feels more like a cover letter. > > > > Please describe what the impact of the patch is, like mention that the > > trace_autotest unit test is being called twice, once with traces > > disabled, and once with traces enabled. > > And that the traces file is being written in a directory part of the > > build directory. > > > > > >> > >> Signed-off-by: Chengwen Feng > >> --- > >> app/test/meson.build | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/app/test/meson.build b/app/test/meson.build > >> index 7fe261cae8..eb37aa632a 100644 > >> --- a/app/test/meson.build > >> +++ b/app/test/meson.build > >> @@ -509,6 +509,17 @@ foreach arg : fast_tests > >> is_parallel : false, > >> suite : 'fast-tests') > >> endif > >> + > >> + if run_test and arg[0] == 'trace_autotest' and (not is_windows) > > > > Calling this test on Windows should not be an issue. > > Is it not the case? > > I notice that eal_parse_common_option still keep windows macro for trace parameter parse: > > #ifndef RTE_EXEC_ENV_WINDOWS > case OPT_TRACE_NUM: { > ... > case OPT_TRACE_MODE_NUM: { > if (eal_trace_mode_args_save(optarg) < 0) { > RTE_LOG(ERR, EAL, "invalid parameters for --" > OPT_TRACE_MODE "\n"); > return -1; > } > break; > } > #endif /* !RTE_EXEC_ENV_WINDOWS */ > > Maybe trace already support in windows, but I havn't the windows enviorment to verify it. > > So I think we should keep '(not is_windows)' currently. Indeed. -- David Marchand