From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C8B9DA04BB;
	Tue,  6 Oct 2020 09:47:53 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A901049E0;
	Tue,  6 Oct 2020 09:47:52 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by dpdk.org (Postfix) with ESMTP id 5F66A11A4
 for <dev@dpdk.org>; Tue,  6 Oct 2020 09:47:50 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1601970468;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=//Cyg5HEgJ9B4zq0JywM3qWAXL2t3Qh5iYnHvjs1LWI=;
 b=aHImexVe1PDN3I+mqjq5Jdl6+v1w02iO4BxeKiLAj8B9DZadIQyuqo/d9MUzapbrOtKm1v
 ShWqyF9PGNF+ZBrExLSFBsrUWSeXniW+URWUT9UBZ/zrvW5f4J98jz6f9Lw5db3+FJqaal
 rthR1avTTvlD64rauXOc7HuTEnojoq0=
Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com
 [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-341-Hh8tlKmUOGKYYrtlX5fFrg-1; Tue, 06 Oct 2020 03:47:45 -0400
X-MC-Unique: Hh8tlKmUOGKYYrtlX5fFrg-1
Received: by mail-ua1-f71.google.com with SMTP id b1so2062035uad.11
 for <dev@dpdk.org>; Tue, 06 Oct 2020 00:47:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=//Cyg5HEgJ9B4zq0JywM3qWAXL2t3Qh5iYnHvjs1LWI=;
 b=oYOxMsnRn2kAKCcqyUkZgxEYmPt3MDJgJlV/yaYeHuMjD8XRW2sfPJz/ZufJp8q6UN
 Bga/xQvJ2a1CIWpwORycfNhyM4SSERrqtdW+DnmAKefL8HXOBOIiMrAIzQ0or0k/uvf8
 vs5QNZUXkHwIaAjy5yfoFP+PEiasqFVU+jcE0rwQcGmEFNsepXFEDPS1r1ucI/kmTyeu
 M+B+A3C1TSW0hiOVwdym2s/mARL97aX4Hi12UVOGFZWBL+IDLecj5jWnczggd4NGsIWQ
 dXa+czgn2DUibn9EAhEuWdV306DSHI70z+eeFRPjq3X9CZ9AeXH4TO1epV/qzjJV3aWS
 GduA==
X-Gm-Message-State: AOAM533MrtTACF04crKoY1dpxJZC6Maz3y4D2n430OsQI+qKlbT8Aq5V
 q9ctG5Fw8OIbcWT3DLYW6iB1FmvXVSV0aecR3zpcX60Xj3RrePtxRnyyxggp/IrfCdmPzwWeCgd
 8D0P1RuFtQyZgjDFfWB0=
X-Received: by 2002:a05:6102:5d:: with SMTP id
 k29mr2219475vsp.17.1601970464658; 
 Tue, 06 Oct 2020 00:47:44 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJw02ywHcgbrBWAyFdYLhR1axrb/ZWs5BX7vYhqnxpWjewGF0MMl+Yg24fkUBJrxEmFr3Mp9jk2+KC6GTpYuBcg=
X-Received: by 2002:a05:6102:5d:: with SMTP id
 k29mr2219470vsp.17.1601970464350; 
 Tue, 06 Oct 2020 00:47:44 -0700 (PDT)
MIME-Version: 1.0
References: <20201005170201.431125-1-ferruh.yigit@intel.com>
In-Reply-To: <20201005170201.431125-1-ferruh.yigit@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 6 Oct 2020 09:47:33 +0200
Message-ID: <CAJFAV8ycjbTv_C6GWcuYXVGzG0oQK01eQ9qywB-y0RxhLtV5xQ@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: David Hunt <david.hunt@intel.com>, Lee Daly <lee.daly@intel.com>, 
 Marcin Hajkowski <marcinx.hajkowski@intel.com>, dev <dev@dpdk.org>, 
 dpdk stable <stable@dpdk.org>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH] examples/vm_power: fix 32-bit build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Oct 5, 2020 at 8:57 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Compiler version:
> gcc 10.2.1 "cc (GCC) 10.2.1 20200723 (Red Hat 10.2.1-1)"
>
> Build error:
> ../examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:346:23:
>  warning: format =E2=80=98%ld=E2=80=99 expects argument of type =E2=80=98=
long int=E2=80=99, but
>         argument 4 has type =E2=80=98uint64_t=E2=80=99 {aka =E2=80=98long=
 long unsigned int=E2=80=99}
>         [-Wformat=3D]
>   346 |    cmdline_printf(cl, "Capabilities of [%d] vcore are:"
>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ......
>   349 |      pkt_caps_list.turbo[i],
>       |      ~~~~~~~~~~~~~~~~~~~~~~
>       |                         |
>       |                         uint64_t {aka long long unsigned int}
>
> Fixes: 07525d1a047a ("examples/vm_power: send capabilities request from g=
uest")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: David Marchand <david.marchand@redhat.com>
> Cc: David Hunt <david.hunt@intel.com>
>
> Fixed patch is not new, not sure why getting the error now but was not
> getting it before, do you have any clue?
> Or is the CI having this error?

Personally, I do not have a libvirt for 32 bits on my build system.

In Intel CI, I can see a 32 bits job, but I guess there is no libvirt
for i386 available in it.
http://mails.dpdk.org/archives/test-report/2020-October/156516.html

The UNH lab has no 32 bits job.

In Travis, we have a "static" cross compilation job.
But static jobs only build l2fwd and l3fwd examples.

We could switch this job to shared to get all examples built, but we
would still need the libvirt devel headers + libs for i386 to get this
specific example to get built (I tried, but did not find the right
magic to install a i386 package).

We can at least add libvirt-devel for 64 bits in Travis.


> ---
>  examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/e=
xamples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> index 96c1a1ff69..58029f8fb9 100644
> --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> @@ -344,13 +344,13 @@ cmd_query_caps_list_parsed(void *parsed_result,
>                 unsigned int i;
>                 for (i =3D 0; i < pkt_caps_list.num_vcpu; ++i)
>                         cmdline_printf(cl, "Capabilities of [%d] vcore ar=
e:"
> -                                       " turbo possibility: %ld, is prio=
rity core: %ld.\n",
> +                                       " turbo possibility: %"PRId64", i=
s priority core: %"PRId64".\n",
>                                         i,
>                                         pkt_caps_list.turbo[i],
>                                         pkt_caps_list.priority[i]);
>         } else {
>                 cmdline_printf(cl, "Capabilities of [%d] vcore are:"
> -                               " turbo possibility: %ld, is priority cor=
e: %ld.\n",
> +                               " turbo possibility: %"PRId64", is priori=
ty core: %"PRId64".\n",
>                                 lcore_id,
>                                 pkt_caps_list.turbo[lcore_id],
>                                 pkt_caps_list.priority[lcore_id]);
> --
> 2.26.2
>

Installed a libvirt-devel for i686 on a fc32, reproduced and tested the fix=
.
Tested-by: David Marchand <david.marchand@redhat.com>


--=20
David Marchand