From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3C9F41E65; Fri, 10 Mar 2023 14:47:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E73F40ED9; Fri, 10 Mar 2023 14:47:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 74EDC40DD8 for ; Fri, 10 Mar 2023 14:47:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678456055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dnx1jcf7gj2U/WBHpfOc9Tb9t5d+7blDEvhtU/OVrhk=; b=hqYmUNWI3PrEQtgZIyetwPqHj/ChxBzN4/pqC2Jl8OFmPMVSMd/49NRUfnJcBYbDrYMSCO uH12qZaETEPtCYAT8/bVr16KhONEZPXijm6MJpj3MZxcLR9lpvVpYWTdPoLlOTay3tWV3+ K2dBc5c7HSzOXRECdDYeBff5rCJxtQk= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-zJkv0067M4qrhiaLFrBNnA-1; Fri, 10 Mar 2023 08:47:34 -0500 X-MC-Unique: zJkv0067M4qrhiaLFrBNnA-1 Received: by mail-pf1-f200.google.com with SMTP id n17-20020a056a000d5100b005e5e662a4ccso2903474pfv.4 for ; Fri, 10 Mar 2023 05:47:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678456053; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dnx1jcf7gj2U/WBHpfOc9Tb9t5d+7blDEvhtU/OVrhk=; b=okJjX/KdnBf5Yuj64WL7X1coS5NQjov30O8R8KNWX9WREvv6lj/JiwN4YREKo42CT8 mucqjIX8wcj7G64rDC5nvq8IZMwMe0oqNF8EJ40EAC+Jme4MBQSIb/zsrK4HGPuDqume ASO5L88ZKkR5nUExqrM+3gI6i0u3NeIFwf3cjwOH9WRiphTwwQmYoINfRWmREh5YDb0d He2RRA6f/XXTWjw7x/PKXkZ1OTu+7/MAzV9q1CHR2UPoOhGvFAEOFe6F0sq8u1Jcfo1s 9OmHvrf79B7IqmIjsxJiZ9BiBbfF3UFc2xFlzxOswl6NW0jp3z6EwyVXR0vChUvnEQOS pgYw== X-Gm-Message-State: AO0yUKVvYK8c0Yh8W5U9iMDM/4xQDpVH3p1JQ9Bg7im53kgofeFa7q/I 6XHH+GTr2D9+2aYtec6v1OiV7I7MyhC7VgOIfuY7cL4/eMqzQHHSWJ24Lx5ieXn9PPY4pdqKYpr 2Z/bChr55cZtXc12RZjo= X-Received: by 2002:a17:90a:d785:b0:237:622f:cf22 with SMTP id z5-20020a17090ad78500b00237622fcf22mr9690040pju.7.1678456053785; Fri, 10 Mar 2023 05:47:33 -0800 (PST) X-Google-Smtp-Source: AK7set9eubswp4dM0NPE2VMR/OcDhm07BevOsTDR635HwQYEa9g9VY0qO3GkGQ7jBulO8Cqwu+i+duhg8znIGs49ncY= X-Received: by 2002:a17:90a:d785:b0:237:622f:cf22 with SMTP id z5-20020a17090ad78500b00237622fcf22mr9690030pju.7.1678456053506; Fri, 10 Mar 2023 05:47:33 -0800 (PST) MIME-Version: 1.0 References: <20230309144249.1199517-1-yogesh.jangra@intel.com> <20230309083109.01baaebb@hermes.local> <10c16ee4-1c6c-8686-00a6-b5628f415267@amd.com> In-Reply-To: <10c16ee4-1c6c-8686-00a6-b5628f415267@amd.com> From: David Marchand Date: Fri, 10 Mar 2023 14:47:21 +0100 Message-ID: Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports To: Ferruh Yigit Cc: "Dumitrescu, Cristian" , Stephen Hemminger , "Jangra, Yogesh" , Aman Singh , Yuying Zhang , "dev@dpdk.org" , "R, Kamalakannan" , "Suresh Narayane, Harshad" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 10, 2023 at 1:00=E2=80=AFPM Ferruh Yigit = wrote: > >> NAK > >> No driver specific hacks please. > >> > >> Instead fix the driver design or bug please. > > > > Hi Stephen, > > > > This is not a Soft NIC driver-specific hack, this is required for worki= ng around some of the ethdev drivers that don't implement the stop() API co= rrectly and free up the device queues or some other internal resources on s= top() instead of close(). > > > > Why not fix the misbehaving drivers, instead of working around for > softnic, as Stephen suggested? +1 --=20 David Marchand