From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1C49A04DC; Sat, 31 Oct 2020 23:16:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 578975A0F; Sat, 31 Oct 2020 23:16:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 940875953 for ; Sat, 31 Oct 2020 23:15:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604182557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BKcMX/SHEqTk8HOiwxQUCF2HuFbFzcJ8OsobK0bP7U8=; b=JPhSm8UF6tBTPZFmRzeDBRmGeR85F9HU0NZFD/OyGhhVnqSymYStXr2YfNHsvsZCmW91Eq hbaXELlhGoHhdtjGyUjnkkhvf19f596fPmGJvmUMvRsEOuFuP5TT8//N3e4gHn7gnsac7J d1FE5Lf+skwzjd9qaynEfajY+eTLB+4= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-SSPztxyEMlyDH6_BpyfHsQ-1; Sat, 31 Oct 2020 18:15:54 -0400 X-MC-Unique: SSPztxyEMlyDH6_BpyfHsQ-1 Received: by mail-vs1-f69.google.com with SMTP id q15so868770vsg.12 for ; Sat, 31 Oct 2020 15:15:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BKcMX/SHEqTk8HOiwxQUCF2HuFbFzcJ8OsobK0bP7U8=; b=icrrBYGMI49v7hNIyiTOjj9Ip7cbKYC1fQW2aJ8HivdbXLp59fbZ4VmNQdcKz9gkr4 KbWSuKGSTuv6CAoEsAKvveqlc6mzv1a+kEuvjNvoWX0vHJ1STAhMGU92ZXz1v05fFVyo WX2COVLXWCoI4+VwhDRs/y8HmRxlrjaOpwxPh5HGXt+p/5yswJEW63n4qr+6dEI3+L7X aSD4gIPwKueLD7yuufXYDKL9aVpzv/FTJVqKEGoViDtenh/IeX1PmO6P971jrRIxgfDt Lmoa9Y/7oLuCPdmZIValStSJfv3MUJdZ9MgDJpUy7szB+kA7kXIH88U2+hQhT1uo6Ipn lmDQ== X-Gm-Message-State: AOAM531eEhkX8YaCXiFECtgZtL8eeJ/wF4RDxgANVd3dKYkCzuWY+lD6 30cxJrIrDnPNsAdvzZVEnmFpNtRAw4qg4YX3omrV+tikS1evB9Fu8yeOLIwTHGOwXYcOhzrYMdw wy+gvnLumLZe6dCxmmJ8= X-Received: by 2002:ab0:200c:: with SMTP id v12mr4981068uak.53.1604182554109; Sat, 31 Oct 2020 15:15:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHeewIJPWC8aCAGqDoA7akmmtx0U3DVeTJeLG+w7157dGQC/X61JZOWHDbmWfkgbm3UAAQSeg7kFUX2RlwGKA= X-Received: by 2002:ab0:200c:: with SMTP id v12mr4981061uak.53.1604182553905; Sat, 31 Oct 2020 15:15:53 -0700 (PDT) MIME-Version: 1.0 References: <20200612212434.6852-2-timothy.mcdaniel@intel.com> <1604168282-30079-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1604168282-30079-1-git-send-email-timothy.mcdaniel@intel.com> From: David Marchand Date: Sat, 31 Oct 2020 23:15:41 +0100 Message-ID: To: Timothy McDaniel Cc: dev , Erik Gabriel Carrillo , Gage Eads , Van Haaren Harry , Jerin Jacob Kollanukkaran , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v14 00/23] Add DLB PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 31, 2020 at 7:16 PM Timothy McDaniel wrote: > > The following patch series adds support for a new eventdev PMD. The DLB > PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. > The DLB is a PCIe device that provides load-balanced, prioritized > scheduling of core-to-core communication. The device consists of > queues and arbiters that connect producer and consumer cores, and > implements load-balanced queueing features including: > - Lock-free multi-producer/multi-consumer operation. > - Multiple priority levels for varying traffic types. > - 'Direct' traffic (i.e. multi-producer/single-consumer) > - Simple unordered load-balanced distribution. > - Atomic lock-free load balancing across multiple consumers. > - Queue element reordering feature allowing ordered load-balanced > distribution. > > The DLB hardware supports both load balanced and directed ports and > queues. Unlike other eventdev devices already in the repo, not all > DLB ports and queues are equally capable. In particular, directed > ports are limited to a single link, and must be connected to a directed > queue. > Additionally, even though LDB ports may link multiple queues, the > number of queues that may be linked is limited by hardware. Another > difference is that DLB does not have a straightforward way of carrying > the flow_id in the queue elements (QE) that the hardware operates on. > > While reviewing the code, please be aware that this PMD has full > control over the DLB hardware. Intel will be extending the DLB PMD > in the future (not as part of this first series) with a mode that we > refer to as the bifurcated PMD. The bifurcated PMD communicates with a > kernel driver to configure the device, ports, and queues, and memory > maps device MMIO so datapath operations occur purely in user-space. > > The framework to support both the PF PMD and bifurcated PMD exists in > this patchset, and is why the iface.[ch] layer is present. > > Major changes in V14 > ==================== > - Fixed format errors in doc/api/doxy-api-index.md > - Delayed introduction of dlb2_consume_qe_immediate until > add-dequeue-and-its-burst-variants.patch > - Delayed introduction of dlb2_construct_token_pop_qe until > add-PMD-s-token-pop-public-interface.patch > - Delayed introduction of dlb_equeue_*_delayed until > add dequeue and its burst variants.patch I just sent a bunch of comments. I still see a build error with clang for unused stuff. There is no point in sending a new series unless the clang build is fixed once and for all. I compared dlb and dlb2 code. I presume fixing bugs in the future will amount to double patches every time. But, on a positive note, France won against Ireland. -- David Marchand