From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE357A0548; Tue, 27 Apr 2021 11:54:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB93C4069D; Tue, 27 Apr 2021 11:54:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 479D840150 for ; Tue, 27 Apr 2021 11:54:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619517274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6LN5zfMsp0G0uqtY+H65xLXwfm4eiKspcBkwjhUZlLQ=; b=aUCB6/LzrHNi5M4r/MwBBfM17hLAH3OE3ME6xKEbpN0v68fHL0V8JncX2+2boC/DZbzNqj S6B6QJFnR9vzIyS8i8gOKPasGyN4t5pZ6ARQytMcIgQBTxj1wNE/xXqw+2Wa1GLExxsJmQ iwBrrlPHHCbL5s5PhbyxyNmRdwrgm5Q= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-lCeZm61GOZO6-swVUJby3A-1; Tue, 27 Apr 2021 05:54:33 -0400 X-MC-Unique: lCeZm61GOZO6-swVUJby3A-1 Received: by mail-vs1-f70.google.com with SMTP id y4-20020a67d2040000b029022169fd7297so9834398vsi.5 for ; Tue, 27 Apr 2021 02:54:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6LN5zfMsp0G0uqtY+H65xLXwfm4eiKspcBkwjhUZlLQ=; b=knks+Y8tktfX6DpbxlztNkE0Zt4cfLhtW17lqCJvFxOK6IalHBlS0zO7Y0QjpnwJWe T/K6DhJImjAgXPFFrfKQFDL+9WuAHc+ECqZOBeMiV9Xz8b5uVxwPVw/wF5wXp8OCfU/H IC72CazKF4VcWWNitAIyPca6ALu0fuEyNLSa5qiSj1e4DL/xaXUW58niwDvaTzCvtcYs Ja5VqutuAiDofuwa5xshpWrATKAbsethptONd/pE8q6yg9VZKjeDIKUK0M7o8Qum+kMd cH2MTwJF5K5DdCLPDvbiW0CbpstgNxgCQr03vsBmtLN59QUNiiaAVsFI0jVoJsJnljiB hptw== X-Gm-Message-State: AOAM531qbTLhD3+Lyc8atN0ApXW+BPFJH0nWuVJJyGdrwcp2vAiUpvDU 4/Re+xkA38BJFiuplGVe72X5uZGthRtQ97J7frz7+XmoMPzNUPl3/2ukw63JLxMa65UewdB6m3A S6TH6WaNT+KPdhEf9nBE= X-Received: by 2002:a1f:5682:: with SMTP id k124mr17044294vkb.20.1619517272655; Tue, 27 Apr 2021 02:54:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUvoG1RPjgpWcUnDCsQEasZNc3oCQY2uWJvK2h0bF5FG4aXwVYS3KLyv7ioUyus0X8CL3cdT8rQWwqOZ8Sjk8= X-Received: by 2002:a1f:5682:: with SMTP id k124mr17044288vkb.20.1619517272486; Tue, 27 Apr 2021 02:54:32 -0700 (PDT) MIME-Version: 1.0 References: <20210421091146.1384708-1-conor.walsh@intel.com> <7938996.8XznLcKUNL@thomas> <7749199.3i1lGzfMWf@thomas> In-Reply-To: <7749199.3i1lGzfMWf@thomas> From: David Marchand Date: Tue, 27 Apr 2021 11:54:21 +0200 Message-ID: To: Thomas Monjalon , "Walsh, Conor" Cc: "Yigit, Ferruh" , "Richardson, Bruce" , "Burakov, Anatoly" , "Mcnamara, John" , "dev@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 21, 2021 at 4:21 PM Thomas Monjalon wrote: > > 21/04/2021 16:17, Mcnamara, John: > > From: Thomas Monjalon > > > > > > > > This is a very good suggestion and I think we should encourage doc > > > > writers to use this when including code in the documentation. > > > > > > Yes, and we should try to clean-up existing code snippets. > > > > If there is no general objection to including code snippets this way > > then we could get someone to work on refactoring the sample code docs to use it. > > I'd love such rework! > Removing lines is always good :) +1 :-) -- David Marchand