Re: [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio

[David Marchand <david.marchand@redhat.com>]

On Fri, Jun 21, 2019 at 3:52 PM Lavanya Govindarajan <
lavanyax.govindarajan@intel.com> wrote:

> Added unit test cases for EAL flags --proc-type=auto and
> --create-uio-dev in order to cover the below functions
> eal_proc_type_detect()
> rte_eal_create_uio_dev()
>
> Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
> ---
>  app/test/test_eal_flags.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index 9112c96d0..82d24e1a8 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -880,6 +880,18 @@ test_misc_flags(void)
>         const char *argv15[] = {prgname, "--file-prefix=intr",
>                         "-c", "1", "-n", "2", "--vfio-intr=invalid"};
>
> +       /* With process type as auto-detect */
> +       const char * const argv16[] = {prgname, "--file-prefix=auto",
> +                       "-c", "1", "-n", "2", "--proc-type=auto"};
> +
> +       /* With process type as auto-detect with no-shconf */
> +       const char * const argv17[] = {prgname, "-c", "1", "-n", "2",
> +                       "--proc-type=auto", no_shconf, nosh_prefix,
> no_huge};
> +
> +       /* With process type as --create-uio-dev flag */
> +       const char * const argv18[] = {prgname, "--file-prefix=uiodev",
> +                       "-c", "1", "-n", "2", "--create-uio-dev"};
> +
>

-n is unneeded to run those tests.
-c 1 is not needed either.

Please drop those.
Thanks.


-- 
David Marchand