From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F268BA046B for ; Wed, 26 Jun 2019 11:36:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C20492BE3; Wed, 26 Jun 2019 11:36:27 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 0D0352B82 for ; Wed, 26 Jun 2019 11:36:26 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id l125so1111089vsl.13 for ; Wed, 26 Jun 2019 02:36:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mZjCSAKPDIU76mS17TsfUicmhZl7X0nvy5LDbHWIbwo=; b=evS7hnTWk86mpT+2BqIE0rk4cVvhfyxWJaDFPYXFxuRXE/fIL/zZwSmUzTTJ/pYG5e Yb5gIiLw/6DAYnI01KzYafCKR0ohJIMX8As7aIXaULf7YMUKKtwuK+2xaTxtmvBHrlMM GgYIDOOohpUhb0T5WvRyeO3G7Es1M/DT0f5Nb0494ljPCM6BW0w9ZgHgLp+SPv8oUg65 ZwjnB+2JJ9NBYnXqsXEj5q4vMOoBiPWMFlX7avV6M0IZqp/dyuJNJMifIgFpi4bBSd3q JCUA9d84QfphGU1cjc+NQhBNhEDpZ+pvxtBgC/mDyp9OYJuGV5TK8EDfVQrwqZWf4gBZ grQQ== X-Gm-Message-State: APjAAAVrSWOfzM8J66Nu/6h4G662f3zXBHixvgxbi+ZG+ciwxduaHwS9 FvCluJxdCsYISWryg9+VwDZIR9UAswqeCzpbw2j0rw== X-Google-Smtp-Source: APXvYqyPl3LwgrPpbyIKh7P+BK5x7pLj79OsLVyi3iaeI9lUQvFV3L37V7rZrpiWp1K4sYyqY8+fJCXm7JXq9ronBls= X-Received: by 2002:a67:e9ca:: with SMTP id q10mr2493889vso.105.1561541785388; Wed, 26 Jun 2019 02:36:25 -0700 (PDT) MIME-Version: 1.0 References: <1561125028-21003-1-git-send-email-lavanyax.govindarajan@intel.com> In-Reply-To: <1561125028-21003-1-git-send-email-lavanyax.govindarajan@intel.com> From: David Marchand Date: Wed, 26 Jun 2019 11:36:14 +0200 Message-ID: To: Lavanya Govindarajan Cc: dev , "Pattan, Reshma" , "Burakov, Anatoly" , jananeex.m.parthasarathy@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 21, 2019 at 3:52 PM Lavanya Govindarajan < lavanyax.govindarajan@intel.com> wrote: > Added unit test cases for EAL flags --proc-type=auto and > --create-uio-dev in order to cover the below functions > eal_proc_type_detect() > rte_eal_create_uio_dev() > > Signed-off-by: Lavanya Govindarajan > --- > app/test/test_eal_flags.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c > index 9112c96d0..82d24e1a8 100644 > --- a/app/test/test_eal_flags.c > +++ b/app/test/test_eal_flags.c > @@ -880,6 +880,18 @@ test_misc_flags(void) > const char *argv15[] = {prgname, "--file-prefix=intr", > "-c", "1", "-n", "2", "--vfio-intr=invalid"}; > > + /* With process type as auto-detect */ > + const char * const argv16[] = {prgname, "--file-prefix=auto", > + "-c", "1", "-n", "2", "--proc-type=auto"}; > + > + /* With process type as auto-detect with no-shconf */ > + const char * const argv17[] = {prgname, "-c", "1", "-n", "2", > + "--proc-type=auto", no_shconf, nosh_prefix, > no_huge}; > + > + /* With process type as --create-uio-dev flag */ > + const char * const argv18[] = {prgname, "--file-prefix=uiodev", > + "-c", "1", "-n", "2", "--create-uio-dev"}; > + > -n is unneeded to run those tests. -c 1 is not needed either. Please drop those. Thanks. -- David Marchand