From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF582A0C47; Tue, 6 Jul 2021 15:50:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 977564128B; Tue, 6 Jul 2021 15:50:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 564884120E for ; Tue, 6 Jul 2021 15:50:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625579448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sr67QlDvyUxSO5IitUJkXK30DFgHUXf+phlY2xTr7xM=; b=ApCSaVFOud788SbPe6f1GzEYKNzHUppV5y16Nd3HL8v3FUxRMrpxIANLh0D2kWLRBXmEKO NVXCSl/PY27lkIJ9yc6vYAtIjvhAW0jHyZ1gNZhKsNNMEgKIlpc7PFsXxsYCJV0lc5Kz6C 7Ob+nUZXO5nta1oMb28+m3imFhraiHI= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-XxuBDRGHNAOJSaVMs077WA-1; Tue, 06 Jul 2021 09:50:47 -0400 X-MC-Unique: XxuBDRGHNAOJSaVMs077WA-1 Received: by mail-ua1-f72.google.com with SMTP id v20-20020ab076940000b029020b0b4ada34so7956601uaq.4 for ; Tue, 06 Jul 2021 06:50:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sr67QlDvyUxSO5IitUJkXK30DFgHUXf+phlY2xTr7xM=; b=Yf+w0T0lCS9741cQIVg0G0jMVadi3zPjkd/tCAckxACjpC7FEh/UtOvhstJEGtD3sZ v5ERHPGmbLymUbYkWV2lc2ccqIsuTzdbVWgALvqL0hzAaNiVP/GGpG5g8lfH6rH0Vxnw WYVyz5RcrMv1mswn0ZB1Q4P7GwNA0Mkw67rhRypSL8+FghZZo+5Dojc/5IusnAHDhUhg M2AMphA29v2dzKI17O3U47P60NnAu3hFrcOpJQwdB+yrO21Y19uEZsbuNwYqqcSC+pY0 Ehwf5Nd0q3bntcu+U3DfsP+gFgqTLrE0QdXBUStz9zowPCA0EbMvPNVwC0Gx4mpctL7o EueA== X-Gm-Message-State: AOAM532qWY7P/FqtrOgCEy0s7EfsSxTIDrxHNp6smMBlnbRg0pnuV2+1 QfWHlVdL9wbRjxi95whGiNCETJqTyxym3dR4NkMnNO78GcobDJ+tBQbUfzGKcnju6uwqeTpKyDk ncsXuRjRQGBCmf4X3904= X-Received: by 2002:a1f:26cd:: with SMTP id m196mr13638898vkm.9.1625579447224; Tue, 06 Jul 2021 06:50:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKqtvAxRWy1mJliw8H39hrr6Jgt5HEf7Nuz66JYgiANay1cW+ywkZtijfy7u5xVbEbjxMvCz8wlihJXFLpHz8= X-Received: by 2002:a1f:26cd:: with SMTP id m196mr13638874vkm.9.1625579446991; Tue, 06 Jul 2021 06:50:46 -0700 (PDT) MIME-Version: 1.0 References: <20210706085643.5088-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 6 Jul 2021 15:50:35 +0200 Message-ID: To: "Wang, Haiyue" Cc: "dev@dpdk.org" , "stable@dpdk.org" , "Yang, Qiming" , "Zhang, Qi Z" , "Stillwell Jr, Paul M" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ice: fix memzone leak when firmware is missing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 6, 2021 at 2:53 PM Wang, Haiyue wrote: > > In such a case a single label should be enough, right? > > Yes, since pf->proto_xtr = NULL can be 'freed' safely. Ah ok, I thought proto_xtr was initialised earlier and I had missed the ice_pf_sw_init() call. I'll go with your suggestion. Thanks. -- David Marchand