From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Jin Yu <jin.yu@intel.com>, dev <dev@dpdk.org>,
changpeng.liu@intel.com, Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] vhost: delete vhost scsi example
Date: Thu, 24 Oct 2019 11:55:01 +0200 [thread overview]
Message-ID: <CAJFAV8yeaQ2pARLpKkRTFXzMJ+GmBFBkrosLt5f46H9g2mr6fg@mail.gmail.com> (raw)
In-Reply-To: <4c486ba4-ef74-1405-a1ec-f65e67149ba6@redhat.com>
On Thu, Oct 24, 2019 at 11:50 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
>
>
> On 10/24/19 12:21 PM, Jin Yu wrote:
> > This example is too old and SPDK will not maintain this example
> > anymore. Also SPDK has submitted a new vhost example vhost-blk.
> > We will keep on maintaining vhost-blk and It shows the packed
> > ring and live recovery support.
> >
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> > V2 - delete the left trace
> > ---
> > MAINTAINERS | 2 -
> > doc/guides/sample_app_ug/index.rst | 1 -
> > doc/guides/sample_app_ug/vhost_scsi.rst | 77 ----
> > examples/Makefile | 2 +-
> > examples/meson.build | 2 +-
> > examples/vhost_scsi/Makefile | 69 ----
> > examples/vhost_scsi/meson.build | 21 -
> > examples/vhost_scsi/scsi.c | 515 ------------------------
> > examples/vhost_scsi/scsi_spec.h | 464 ---------------------
> > examples/vhost_scsi/vhost_scsi.c | 487 ----------------------
> > examples/vhost_scsi/vhost_scsi.h | 79 ----
> > 11 files changed, 2 insertions(+), 1717 deletions(-)
> > delete mode 100644 doc/guides/sample_app_ug/vhost_scsi.rst
> > delete mode 100644 examples/vhost_scsi/Makefile
> > delete mode 100644 examples/vhost_scsi/meson.build
> > delete mode 100644 examples/vhost_scsi/scsi.c
> > delete mode 100644 examples/vhost_scsi/scsi_spec.h
> > delete mode 100644 examples/vhost_scsi/vhost_scsi.c
> > delete mode 100644 examples/vhost_scsi/vhost_scsi.h
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Maxime,
When applying, can you add a little note in the release notes to
indicate this example removal ?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2019-10-24 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 16:01 [dpdk-dev] [PATCH] " Jin Yu
2019-10-23 13:52 ` David Marchand
2019-10-24 2:42 ` Yu, Jin
2019-10-24 10:21 ` [dpdk-dev] [PATCH v2] " Jin Yu
2019-10-24 9:49 ` Maxime Coquelin
2019-10-24 9:55 ` David Marchand [this message]
2019-10-24 10:19 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yeaQ2pARLpKkRTFXzMJ+GmBFBkrosLt5f46H9g2mr6fg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=jin.yu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).