From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C48AA45450; Wed, 19 Jun 2024 21:58:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9359F402C6; Wed, 19 Jun 2024 21:58:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 11F1F402B8 for ; Wed, 19 Jun 2024 21:58:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718827118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fSYgyt+nNZKg2kG2Yj9gtxY9Qb9MHwseYbbqdrmWnQ8=; b=aCh1w2Bxk+F4xzKAJ74ixlELqWerNh/7rU4zE4ar2m1a/ayb8+I408rDaQK5Xa62ABUvsk mQZvzht7rLaTY5m7JpiTU5x8gq4DrDUaoxkdVr2PLFZnRuwfr401j8bSrEQxnKRPXmldYQ +eXLNrUCChzeVlxac/qSpT5uGjDMt2c= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-VzM-ie6OOs-3ARNX_dYg3g-1; Wed, 19 Jun 2024 15:58:37 -0400 X-MC-Unique: VzM-ie6OOs-3ARNX_dYg3g-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52c7fca52f8so83741e87.1 for ; Wed, 19 Jun 2024 12:58:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718827115; x=1719431915; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fSYgyt+nNZKg2kG2Yj9gtxY9Qb9MHwseYbbqdrmWnQ8=; b=gsv1l/D2O4Hi3pe9f0FR00dWzvrpxP//xqLP1IP/Z0OhzdKR5caaM9EyZEEYJYwLCJ g8gd2c5i6QMsKOa2pClMoAEmL5BDJo2Z5oZZHgGlDsGVTqGB+/WBIZYUUplGNAlTRB6i xGgBKN6VBCHOMbUbwTMyBbXqSO3FNDkwFu3VOOqsTG4ZghMMUOtNHKRh7WBv+3c9Uiqh QAglBCaJvGxtE2acDw2E2+kRO55kmXGAIsdhkfRMOc6zYSyyU2K/vxdZ7REp0XbByzOB nrvJsSzg44jP2AcRvfH7nt3s6e7TBH45tGNljHgz665fbXzdWGwz3qep6QcFfkYw5sK5 Z8tQ== X-Gm-Message-State: AOJu0YzMg69DvHmVM4GGCvoO60jufBSwsWPADeKzz9r4VA0JNKUDgjZC 2zpPxwmtpSM9/vtcUxHtuWImS1JsNMj15zmd/zICUVoDZJaR+exu14VkPwYN5mZYJWaRP4u81hN HqRejj3fppVHYafPfRCT9/CaxlPwvU/NWI4sRKbB7aUmlJ8QoUAOf8bOIPEtWmbx06agT/XHFlu WX6xE9eOD1PJYSH4T+mj4DRG0= X-Received: by 2002:a05:6512:12c7:b0:52c:910b:9c7d with SMTP id 2adb3069b0e04-52cca1ea259mr1252953e87.21.1718827115038; Wed, 19 Jun 2024 12:58:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdFzAYTIMPmdtWAR//adzEYXzqMzTZ292l9FXQq8sa969uncH/DqvVuKSFNrXFk9K6unB+tKScc5kT8ywAQA8= X-Received: by 2002:a05:6512:12c7:b0:52c:910b:9c7d with SMTP id 2adb3069b0e04-52cca1ea259mr1252952e87.21.1718827114663; Wed, 19 Jun 2024 12:58:34 -0700 (PDT) MIME-Version: 1.0 References: <20240322135328.393562-1-david.marchand@redhat.com> In-Reply-To: <20240322135328.393562-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 19 Jun 2024 21:58:23 +0200 Message-ID: Subject: Re: [PATCH] table: remove experimental CRC API for some arches To: dev@dpdk.org Cc: Cristian Dumitrescu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 22, 2024 at 2:54=E2=80=AFPM David Marchand wrote: > > x86 and ARM architectures provide a non-experimental implementation for > rte_crc32_u64(). > Experimental API rte_crc32_u64_generic() was only exported for other > arches. > > Leaving this API exposed could result in portability issues: an > application using rte_crc32_u64_generic() would not compile on x86 or > ARM. > > Move this symbol code in the only caller of the table library, and > remove this symbol. > > Signed-off-by: David Marchand Applied. --=20 David Marchand