From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FD96A0543; Thu, 15 Dec 2022 10:09:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A887840684; Thu, 15 Dec 2022 10:09:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 84A4040223 for ; Thu, 15 Dec 2022 10:09:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671095359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=As3BlZ927p/mkN6T7Vu06LCx1PIxSoRaxfKzLbrGcUk=; b=UYcWWoqEKuuBe5W0YnNU4C6DXbBCE0P+bZRXt7uKDJgXeKOu0DmQfeR8Vart8jID4O1zfN CNpMY6BcUMlMRkfcvYPhRnmrKoizkx9pYjNdTcG+y1y3QtAPcVJu5UW/DSw8mEHDJ5DbJK cG0e0lMiLEumy4lEFCuKIfjEX9e57dI= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-46-HyX901L1MpOS2aa6T28hTA-1; Thu, 15 Dec 2022 04:09:17 -0500 X-MC-Unique: HyX901L1MpOS2aa6T28hTA-1 Received: by mail-pl1-f200.google.com with SMTP id o5-20020a170903210500b0018f9edbba6eso4721746ple.11 for ; Thu, 15 Dec 2022 01:09:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=As3BlZ927p/mkN6T7Vu06LCx1PIxSoRaxfKzLbrGcUk=; b=V0XJ6OUZo7vFtXgvqE24gdL5TzAcHIPJ+ha6nk4+XbJC6gofWElOHsrL27+DikH8L/ pKv2hSCL2Oj0cpUQ0fC0uUn61Fdy4L80x7rMMWSiodUXvdFvM/HH/L2vWR8OTJqO46lT EvoMgieX8i2X6S0doWSsKj8O5h1EefrRRfvkFMV3akWTSU/j4KBu4haceCx9eXXWcGyr VLDdWfZg1FLPGaxU7jgFtHzu2oh+FcIshzYAttLJ8JQSEi9yqf375we2jyPPl6X3Lfsz uPM5DkNt+XQhJ91vKgcCPn7O05hD3so62xdOVIyZ2M/iqb/48LU0xSiV7D5WiigSm5jx 23aQ== X-Gm-Message-State: ANoB5pmpiEiA2XSRTbZK7GUYkEMa179oAxYDisBMqeisp/OXHn9jIcgh UCGPtN38c6aOnf+KM4QFR3ZbZ44951aNZ/VeXPoKGMTkctV6ch4atr3q8kMpMsh5TrCzx+t37yT B/a3LBk2Qblhok+2JpKo= X-Received: by 2002:a05:6a00:140c:b0:56b:b520:3751 with SMTP id l12-20020a056a00140c00b0056bb5203751mr80581927pfu.29.1671095356894; Thu, 15 Dec 2022 01:09:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf6fZR/cNBmTsSmsvdkgvr/W93kLrzbojoOEqe3Ka+NAi4fNKSm4lEPc3kMolOQtHtUqa6WlNBG50NSHTDIC9DQ= X-Received: by 2002:a05:6a00:140c:b0:56b:b520:3751 with SMTP id l12-20020a056a00140c00b0056bb5203751mr80581926pfu.29.1671095356638; Thu, 15 Dec 2022 01:09:16 -0800 (PST) MIME-Version: 1.0 References: <20200610144506.30505-1-david.marchand@redhat.com> <20200706205234.8040-1-david.marchand@redhat.com> <20200706205234.8040-8-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D875A7@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D875A7@smartserver.smartshare.dk> From: David Marchand Date: Thu, 15 Dec 2022 10:09:05 +0100 Message-ID: Subject: Re: [dpdk-dev] [PATCH v6 07/10] eal: add lcore init callbacks To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dev@dpdk.org, jerinj@marvell.com, bruce.richardson@intel.com, mdr@ashroe.eu, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, ktraynor@redhat.com, ian.stokes@intel.com, i.maximets@ovn.org, olivier.matz@6wind.com, konstantin.ananyev@intel.com, Neil Horman X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 15, 2022 at 10:05 AM Morten Br=C3=B8rup wrote: > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand > > Sent: Monday, 6 July 2020 22.53 > > > > DPDK components and applications can have their say when a new lcore is > > initialized. For this, they can register a callback for initializing > > and > > releasing their private data. > > > > Signed-off-by: David Marchand > > --- > > David, > > Shouldn't these callbacks be called from the EAL threads too, e.g. from e= al_thread_loop()? > > I looks like they are only called from eal_lcore_non_eal_allocate(), whic= h is only called from rte_thread_register(). These should be called for already present lcores on callback registration. See rte_lcore_callback_register(). --=20 David Marchand