From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FB0BA04B7; Tue, 13 Oct 2020 14:02:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 753BA1BEE1; Tue, 13 Oct 2020 14:02:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 2227E1BC8C for ; Tue, 13 Oct 2020 14:01:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602590518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w3Lp7JsJVTUbp/TINbVmymY67nSjrVvPePhElohDS9A=; b=A5sjCnZDWP+G1MItyAkjHOXpyLiH7xOiyRDtBf6OS7omcTJI7K2aMAl5kI2b1vWbNf1YAt /urUNbvvCrbPYAOhbYxV7NOGbtbV4CUeqxFoo/wgkGcBJASgVAbwcGUZ3kLa34cYQRzJDX 5WJinvcqMZ0UyZTXeviH5vQnWQgrxfA= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-0bq_cENVMHCl2L4i5SJwEQ-1; Tue, 13 Oct 2020 08:01:57 -0400 X-MC-Unique: 0bq_cENVMHCl2L4i5SJwEQ-1 Received: by mail-ua1-f70.google.com with SMTP id k5so2954908uag.1 for ; Tue, 13 Oct 2020 05:01:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=w3Lp7JsJVTUbp/TINbVmymY67nSjrVvPePhElohDS9A=; b=cLuruFGdZKbYwUFQLSUM9V/mzHA2KL3tYowcWZnTAWdhitBK4qAczkL1hzHwYijfrN 7YUJpt6kjAtMuOlbGhXuxtNLpwmLJbtzXL21V7ozt2kJVImHQdQ+mx5dCtdjR1Oi9kGw RU2IozRXouaxfZIGBNnqyW4TKlvpkvqbnre15DnQDlx8pL22ZRrbL7JtL/NwEJAcVjQJ ypifs54Tih9hEpXNf3ZuWaGtgOerSHDF8LEUEU5IwR3Adk5PDxYOs/BB+xvKCdI2ikY+ fISbUdKgVvflzdqIASKj3pR4zrnR55J6akvZbfGeFzw2V6oaV8nDJN5esRBjTYpOcGAh KBxg== X-Gm-Message-State: AOAM531l/UGk2Y6XeNwo2Ly3QJASQVDNsbJP0ejZU3G7SV4ZuE1t9UVU lIXBFegs2WlR+P1VwCb6bLAKKJ91zlcZ0FLpvIgNrhg9hyWVr3JluVcKmi4JwNeM5IUG1yg7j+O kvpAuki1PJUNRWVx4YPI= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr16544966vsh.10.1602590516104; Tue, 13 Oct 2020 05:01:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNk1Y7FluHVdQia9LFs74O7gFszgaLlV1oQWCTaH/L3Yk2Swl2ydWXwO6o+F2U1QIyj3abffRNFHLd+LOaAvY= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr16544939vsh.10.1602590515777; Tue, 13 Oct 2020 05:01:55 -0700 (PDT) MIME-Version: 1.0 References: <20200805122640.13884-1-nick.connolly@mayadata.io> <20201012192803.3741-1-nick.connolly@mayadata.io> In-Reply-To: From: David Marchand Date: Tue, 13 Oct 2020 14:01:44 +0200 Message-ID: To: Nick Connolly Cc: Nicolas Dichtel , Anatoly Burakov , Didier Pallard , Olivier Matz , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] mem: fix allocation failure on non-NUMA kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 13, 2020 at 10:00 AM Nicolas Dichtel wrote: > > Le 12/10/2020 =C3=A0 21:28, Nick Connolly a =C3=A9crit : > > Running dpdk-helloworld on Linux with lib numa present, > > but no kernel support for NUMA (CONFIG_NUMA=3Dn) causes > > ret_service_init() to fail with EAL: error allocating > > rte services array. > > > > alloc_seg() calls get_mempolicy to verify that the allocation > > has happened on the correct socket, but receives ENOSYS from > > the kernel and fails the allocation. > > > > The allocated socket should only be verified if check_numa() is true. > > > > Fixes: 2a96c88be83e ("mem: ease init in a docker container") > > Cc: nicolas.dichtel@6wind.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Nick Connolly > Reviewed-by: Nicolas Dichtel Acked-by: Anatoly Burakov Applied, thanks Nick. --=20 David Marchand