From: David Marchand <david.marchand@redhat.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] net/bnxt: fix ver get HWRM command
Date: Tue, 1 Mar 2022 13:53:32 +0100 [thread overview]
Message-ID: <CAJFAV8yezCJ==az6h0k9Wztiia-azs19Ydr9cGjnd+5TYjGOXQ@mail.gmail.com> (raw)
In-Reply-To: <20210304090728.26166-3-kalesh-anakkur.purayil@broadcom.com>
Hello,
On Thu, Mar 4, 2021 at 9:45 AM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Fix HWRM_VER_GET command to handle DEV_NOT_RDY state.
>
> Driver should fail probe if the device is not ready.
> Conversely, the HWRM_VER_GET poll after reset can safely
> retry until the existing timeout is exceeded.
>
> Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
This patch makes probing fail on a RHEL9 kernel with firmwares:
firmware-version: 20.6.143.0/pkg 20.06.04.06
and
firmware-version: 20.6.112.0
Simply reverting the patch fixes probing in my env.
This was reported by our QE team which is doing sanity checks on ovs
2.17 which uses dpdk v21.11.
https://bugzilla.redhat.com/show_bug.cgi?id=2055531
--
David Marchand
next prev parent reply other threads:[~2022-03-01 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 9:07 [dpdk-dev] [PATCH 0/3] bnxt fixes Kalesh A P
2021-03-04 9:07 ` [dpdk-dev] [PATCH 1/3] net/bnxt: check flush status during ring free Kalesh A P
2021-03-04 9:07 ` [dpdk-dev] [PATCH 2/3] net/bnxt: fix ver get HWRM command Kalesh A P
2022-03-01 12:53 ` David Marchand [this message]
2022-03-17 10:11 ` David Marchand
2022-03-17 16:48 ` Ajit Khaparde
2022-03-18 14:53 ` David Marchand
2021-03-04 9:07 ` [dpdk-dev] [PATCH 3/3] net/bnxt: fix VF info allocation Kalesh A P
2021-03-12 0:11 ` [dpdk-dev] [PATCH 0/3] bnxt fixes Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yezCJ==az6h0k9Wztiia-azs19Ydr9cGjnd+5TYjGOXQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).