From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E691BA04A4; Tue, 1 Mar 2022 13:54:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91280426DE; Tue, 1 Mar 2022 13:54:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3C03640DF6 for ; Tue, 1 Mar 2022 13:54:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646139245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cS59hjRxQkE2gZt/bcsvvtudPolUlHEuFdfGAhHpDN0=; b=DxQKTa0PEW5JDjUIkP6WzAT+dt2k4HtXHUw9Uu/jiybzv9hJbsh6PtzwLnruhGMfAlxxH5 j37cIlHnVn6EL08wFcWCJuaqWEfzRVSGzTsdsn3CcXWDfvUH4q/tCzqTZnzI7RxWIIJwe2 kAKE/SU/lepH2LHl8nA6GRXZuQSElig= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-ut6GmMplPHmZh8ukBhNJXQ-1; Tue, 01 Mar 2022 07:53:45 -0500 X-MC-Unique: ut6GmMplPHmZh8ukBhNJXQ-1 Received: by mail-lj1-f198.google.com with SMTP id b16-20020a05651c0b1000b0024647a956a2so7221083ljr.5 for ; Tue, 01 Mar 2022 04:53:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cS59hjRxQkE2gZt/bcsvvtudPolUlHEuFdfGAhHpDN0=; b=lM2/V+rs7sKEacTJvtRIkMcjhwqsXizb4zyv4GhEgTTJuQssVeYFXajmO3Lk2N+Ckh ET7m8/LeHZ2zird2EGQssPdBx6CfCJdJ+a5q106oxwo1mfMEWVTweksZDVp09+GoLQzM +Y+XI8SRB221Sp4tLlFdXAEZGruStZ+2AY6akm15JpNgybrs+VYKvOmAyjDs/Lu1gyTQ 5yn5QJ+MwUp07ApVnjXsMWtHRJSUPzkk51j0+ipPYj8J8RGSRmSR9/NwGj/gS+3iIxXK HlhRuTPbzA/OYeCC9Ju5CUjTRgdw6Ck+NbrZkMnAnsIeMo7SH9l6S5aREQGcJxM8gVvz PMuA== X-Gm-Message-State: AOAM533Mc8WZ+yM3DGIIpzN2QMNRjdBLqDKgnTvnQoHwUil94DWzQYFX fFLk7VaJpKtEWf1/+kTDDWMLfe+5Bvk4QJp3ZIMIS5P4aEcSpsNlk2g9aaRsrIuH/iDLe9kGCvR ZVwR2WceikMUKWpvsiUo= X-Received: by 2002:a2e:b52f:0:b0:23e:2fe6:af10 with SMTP id z15-20020a2eb52f000000b0023e2fe6af10mr16623733ljm.46.1646139223482; Tue, 01 Mar 2022 04:53:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwU9w3/Wn/3SR8K2W+Cv1cJ5FgkfZbNlzGWR+k9v0v4lggPPQwF5el6rg3faBLjeZtWaodE1h4H0Li7lVcNnuY= X-Received: by 2002:a2e:b52f:0:b0:23e:2fe6:af10 with SMTP id z15-20020a2eb52f000000b0023e2fe6af10mr16623725ljm.46.1646139223267; Tue, 01 Mar 2022 04:53:43 -0800 (PST) MIME-Version: 1.0 References: <20210304090728.26166-1-kalesh-anakkur.purayil@broadcom.com> <20210304090728.26166-3-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210304090728.26166-3-kalesh-anakkur.purayil@broadcom.com> From: David Marchand Date: Tue, 1 Mar 2022 13:53:32 +0100 Message-ID: Subject: Re: [dpdk-dev] [PATCH 2/3] net/bnxt: fix ver get HWRM command To: Kalesh A P Cc: dev , "Yigit, Ferruh" , Ajit Khaparde Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Thu, Mar 4, 2021 at 9:45 AM Kalesh A P wrote: > > From: Kalesh AP > > Fix HWRM_VER_GET command to handle DEV_NOT_RDY state. > > Driver should fail probe if the device is not ready. > Conversely, the HWRM_VER_GET poll after reset can safely > retry until the existing timeout is exceeded. > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Randy Schacher > Reviewed-by: Ajit Kumar Khaparde This patch makes probing fail on a RHEL9 kernel with firmwares: firmware-version: 20.6.143.0/pkg 20.06.04.06 and firmware-version: 20.6.112.0 Simply reverting the patch fixes probing in my env. This was reported by our QE team which is doing sanity checks on ovs 2.17 which uses dpdk v21.11. https://bugzilla.redhat.com/show_bug.cgi?id=2055531 -- David Marchand