From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1569DA0544; Tue, 28 Jun 2022 09:31:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3D6A40691; Tue, 28 Jun 2022 09:31:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8B4FA400D7 for ; Tue, 28 Jun 2022 09:31:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656401492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pj2k+2cYkcNBpx//3OfcNvgJL34cp1tUXFGdZMhSRmA=; b=ZymcobzxB0E+XpMUwnoFcjp3Sp5QiJfhTLs+9NG5FA5b5alpgZxSFw0eLa66+SZhwLgA6v H8vemvNX3uD3U9KVw5AJCjVOzNyCR++6jrvPFADobkJdG5qRodQ0CPIVMOyvUPB0XLuVwH MjC7e6z7fAAx0IkRyikLac0YS8Gm8Ao= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-673-f921bU_GPiWEigusjgk16A-1; Tue, 28 Jun 2022 03:31:31 -0400 X-MC-Unique: f921bU_GPiWEigusjgk16A-1 Received: by mail-lj1-f199.google.com with SMTP id l5-20020a2e8345000000b0025bce6dcde0so430680ljh.12 for ; Tue, 28 Jun 2022 00:31:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pj2k+2cYkcNBpx//3OfcNvgJL34cp1tUXFGdZMhSRmA=; b=Jtc4d1StYZcgvQDd/4OA22CGQe3CQ/DtYv2z19KkD50GVv1f/53dd8D5suuTPp0IbN ZqtdY//UxK9hnm8xqfup/QbEJf+n+BiDgVDUidCu97Ndcm8N30rb3QNJtMgosbAfPPPz N3XpfsZwcQXswND+1ODEY92ck8jSrRBeH1dh/wDLA9SJ9UJ0g1O6Mbyohy8VwQI6QhRw FiSFQN4Yg2+XsGaYXmFrIg/pI5mLbkCH3vCkkyLsLE6l9WFxGjVQygF1sI4ojSqgWm9J l6FISqRzxOcn/jflFNgtuGNcF9zKcM65hrpEr313lbczzPlkG6ps9+d38rDvK1+TPeVW mt9w== X-Gm-Message-State: AJIora9gpT9TAcFiCWAsGZVWKhCnvv/T0BqJ6xpJi3T0G0yHvYv2oaF5 CmNOtbV3yFQHQUxaERt0R96LeQA5Ay1FQI1txUPZMktbegXYVusDLxP/IVruLLMmqtts8Rc8kOV rz8tviAHLOa4vXXSZjZ8= X-Received: by 2002:a05:6512:13a0:b0:47f:709d:dc11 with SMTP id p32-20020a05651213a000b0047f709ddc11mr10220680lfa.265.1656401489824; Tue, 28 Jun 2022 00:31:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1soVay58//67YVrJEOAc6OutulwJ/CI4H5vE+EUz+Atgb61AEl4r0jZULDOXTpnF/UbaTAh4QeDNjmDdXrcgw0= X-Received: by 2002:a05:6512:13a0:b0:47f:709d:dc11 with SMTP id p32-20020a05651213a000b0047f709ddc11mr10220671lfa.265.1656401489632; Tue, 28 Jun 2022 00:31:29 -0700 (PDT) MIME-Version: 1.0 References: <20220627164352.181868-1-rebecca.troy@intel.com> In-Reply-To: <20220627164352.181868-1-rebecca.troy@intel.com> From: David Marchand Date: Tue, 28 Jun 2022 09:31:18 +0200 Message-ID: Subject: Re: [PATCH] crypto/qat: fix docsis segmentation fault To: Rebecca Troy Cc: Fan Zhang , Arkadiusz Kusztal , Fiona Trahe , Tomasz Jozwiak , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 27, 2022 at 6:45 PM Rebecca Troy wrote: > > Currently if AES or DES algorithms fail for Docsis test suite, > a segmentation fault occurs when cryptodev_qat_autotest is ran. > > This is due to a duplicate call of EVP_CIPHER_CTX_free for the > session context. Ctx is freed firstly in the bpi_cipher_ctx_init > function and then again at the end of qat_sym_session_configure_cipher > function. > > This commit fixes this bug by removing the first instance > of EVP_CIPHER_CTX_free, leaving just the dedicated function in > the upper level to free the ctx. This is awkward. This helper should let *ctx alone until everything succeeded. -- David Marchand