Re: [PATCH v6 2/2] net/bnxt: code refactor for supporting speed lanes

[David Marchand <david.marchand@redhat.com>]

Hello,

On Thu, Sep 26, 2024 at 11:56 PM Damodharam Ammepalli
<damodharam.ammepalli@broadcom.com> wrote:
> @@ -1331,16 +1376,17 @@ static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev)
>  void bnxt_print_link_info(struct rte_eth_dev *eth_dev)
>  {
>         struct rte_eth_link *link = &eth_dev->data->dev_link;
> +       struct bnxt *bp = eth_dev->data->dev_private;
>
>         if (link->link_status)
> -               PMD_DRV_LOG(DEBUG, "Port %d Link Up - speed %u Mbps - %s\n",
> -                       eth_dev->data->port_id,
> -                       (uint32_t)link->link_speed,
> -                       (link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?
> -                       ("full-duplex") : ("half-duplex\n"));
> +               PMD_DRV_LOG(DEBUG, "Port %d Link Up - speed %u Mbps - %s Lanes - %d\n",
> +                           eth_dev->data->port_id,
> +                           (uint32_t)link->link_speed,
> +                           (link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?
> +                           ("full-duplex") : ("half-duplex\n"),

A \n slipped in with the "half-duplex" string.
Please send a fix against next-net.


> +                           (uint16_t)bp->link_info->active_lanes);
>         else
> -               PMD_DRV_LOG(INFO, "Port %d Link Down\n",
> -                       eth_dev->data->port_id);
> +               PMD_DRV_LOG(INFO, "Port %d Link Down\n", eth_dev->data->port_id);
>  }
>
>  /*


-- 
David Marchand