From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAF7D45AAE; Fri, 4 Oct 2024 15:56:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6559410FC; Fri, 4 Oct 2024 15:56:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 86A5F40E34 for ; Fri, 4 Oct 2024 15:56:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728050165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VaqlJBtTH6jXbStH+zqcDbKLdpFxUYAVPFPV75EpvAc=; b=Wg3VZsi4c+WB/rbUzKhRh0PVGs+UC6JUq+B/8N1RcUzOt14TNXzL4qqaKd7ZCtOXCBoHTI gvnwMhvgVoMlDOBhkcquICjfeH3/ws1fq4WzJ9nLHLSSK46u7nbSon5RUDmCCRhamis0Nq W0La2MHm1DeeYIo9shhPHjSpTwLh2Rk= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-tUzPxV2RNniLnuOtHvHYug-1; Fri, 04 Oct 2024 09:56:04 -0400 X-MC-Unique: tUzPxV2RNniLnuOtHvHYug-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2fad8337b8aso18575931fa.3 for ; Fri, 04 Oct 2024 06:56:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728050162; x=1728654962; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VaqlJBtTH6jXbStH+zqcDbKLdpFxUYAVPFPV75EpvAc=; b=VlHg2RtIrEWt/mq+oh/57JA1DaxavsANR1aHVwUO7yHwywBmq0DBYaLpHGdL2JO2Qu r5qaxMagNyAGSfVQ10jmso5mGSDtR0InVkIbuN4W4pj0m3HfOw6MOBYy3RV16/Xxbyq1 d0WbUSq68r5OicFtD+0bqVtGpYOGUzpIXeJ6kUlCYbPSLT6v5ksyEQE6UcjkDDx1Xv+q lm0Jq94/4jn7QCg8mzOWPoqsGzTNj9rah1wU6bLEnmOiiu+MWiW/D+x07xqPd0bDNXGj Voz0+TsHUJjqgAHMPgqmV0ToAnb3miiFttpLOr4pV2spr6tn21aTHvmoJ5wO2GUgAcuN gEow== X-Forwarded-Encrypted: i=1; AJvYcCUu4mFY0TKNQPwNzxR3et0B7gLMibqKKiCo44eZpik+thzIALMxuALhVFzXt6Q+7pl7A2w=@dpdk.org X-Gm-Message-State: AOJu0YxuABp9GWqKTD6gto34LMJmvR34yPK2xIrOZxKCM1VxXOiGNpm1 ytNNph034rNWW5dSevccWq054JXdf/PrY99v+8cj+gsW1U3e72x/Qua/LTlxgipcOi7q14dhBX2 mIvP5MB2hEAk6VlzWv911aTRq51ixayyEI4AB6zu+3ctqfib8kAio10MT4++8xY5jRWY7BnNvjW R8iFkfrzdFNMKfuWg= X-Received: by 2002:a05:651c:b1e:b0:2fa:cf5b:1ea7 with SMTP id 38308e7fff4ca-2faf3c141e3mr16170061fa.6.1728050162388; Fri, 04 Oct 2024 06:56:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlPLiNV88eE9KsGvJCsXEaEI7uXq8zbLkhihU0CVEVp/FsKoLfLa4en1Wha1JTXN7LGU5eB6/0xsZL2OYSPHA= X-Received: by 2002:a05:651c:b1e:b0:2fa:cf5b:1ea7 with SMTP id 38308e7fff4ca-2faf3c141e3mr16169791fa.6.1728050161944; Fri, 04 Oct 2024 06:56:01 -0700 (PDT) MIME-Version: 1.0 References: <20240926215012.9987-1-damodharam.ammepalli@broadcom.com> <20240926215012.9987-3-damodharam.ammepalli@broadcom.com> In-Reply-To: <20240926215012.9987-3-damodharam.ammepalli@broadcom.com> From: David Marchand Date: Fri, 4 Oct 2024 15:55:49 +0200 Message-ID: Subject: Re: [PATCH v6 2/2] net/bnxt: code refactor for supporting speed lanes To: Damodharam Ammepalli Cc: ajit.khaparde@broadcom.com, dev@dpdk.org, ferruh.yigit@amd.com, huangdengdui@huawei.com, kalesh-anakkur.purayil@broadcom.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Thu, Sep 26, 2024 at 11:56=E2=80=AFPM Damodharam Ammepalli wrote: > @@ -1331,16 +1376,17 @@ static int bnxt_dev_configure_op(struct rte_eth_d= ev *eth_dev) > void bnxt_print_link_info(struct rte_eth_dev *eth_dev) > { > struct rte_eth_link *link =3D ð_dev->data->dev_link; > + struct bnxt *bp =3D eth_dev->data->dev_private; > > if (link->link_status) > - PMD_DRV_LOG(DEBUG, "Port %d Link Up - speed %u Mbps - %s\= n", > - eth_dev->data->port_id, > - (uint32_t)link->link_speed, > - (link->link_duplex =3D=3D RTE_ETH_LINK_FULL_DUPLE= X) ? > - ("full-duplex") : ("half-duplex\n")); > + PMD_DRV_LOG(DEBUG, "Port %d Link Up - speed %u Mbps - %s = Lanes - %d\n", > + eth_dev->data->port_id, > + (uint32_t)link->link_speed, > + (link->link_duplex =3D=3D RTE_ETH_LINK_FULL_D= UPLEX) ? > + ("full-duplex") : ("half-duplex\n"), A \n slipped in with the "half-duplex" string. Please send a fix against next-net. > + (uint16_t)bp->link_info->active_lanes); > else > - PMD_DRV_LOG(INFO, "Port %d Link Down\n", > - eth_dev->data->port_id); > + PMD_DRV_LOG(INFO, "Port %d Link Down\n", eth_dev->data->p= ort_id); > } > > /* --=20 David Marchand