From: David Marchand <david.marchand@redhat.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] eal: correct error log for alarm
Date: Wed, 5 Jun 2019 09:31:29 +0200 [thread overview]
Message-ID: <CAJFAV8ygs9vsFz2KxHUMkMYkL29ZP=r29wpYDuY93_hYmJvmJw@mail.gmail.com> (raw)
In-Reply-To: <20190605071829.113385-1-xiaolong.ye@intel.com>
On Wed, Jun 5, 2019 at 9:28 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> Fixes: af75078fece3 ("first public release")
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>
> v2:
>
> add freebsd fix suggested by David
>
> lib/librte_eal/freebsd/eal/eal.c | 2 +-
> lib/librte_eal/linux/eal/eal.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/freebsd/eal/eal.c
> b/lib/librte_eal/freebsd/eal/eal.c
> index c6ac9028f..a3b664125 100644
> --- a/lib/librte_eal/freebsd/eal/eal.c
> +++ b/lib/librte_eal/freebsd/eal/eal.c
> @@ -663,7 +663,7 @@ rte_eal_init(int argc, char **argv)
> }
>
> if (rte_eal_alarm_init() < 0) {
> - rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> + rte_eal_init_alert("Cannot init alarm");
> /* rte_eal_alarm_init sets rte_errno on failure. */
> return -1;
> }
> diff --git a/lib/librte_eal/linux/eal/eal.c
> b/lib/librte_eal/linux/eal/eal.c
> index 161399619..10e2887ca 100644
> --- a/lib/librte_eal/linux/eal/eal.c
> +++ b/lib/librte_eal/linux/eal/eal.c
> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
> }
>
> if (rte_eal_alarm_init() < 0) {
> - rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> + rte_eal_init_alert("Cannot init alarm");
> /* rte_eal_alarm_init sets rte_errno on failure. */
> return -1;
> }
> --
> 2.17.1
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-06-05 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 16:31 [dpdk-dev] [PATCH] " Xiaolong Ye
2019-06-05 6:51 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-06-05 6:49 ` Ye Xiaolong
2019-06-05 7:13 ` David Marchand
2019-06-05 7:12 ` Ye Xiaolong
2019-06-05 7:18 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
2019-06-05 7:31 ` David Marchand [this message]
2019-06-27 15:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8ygs9vsFz2KxHUMkMYkL29ZP=r29wpYDuY93_hYmJvmJw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).