From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57FD4A00C2; Wed, 22 Apr 2020 16:14:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A403B1D672; Wed, 22 Apr 2020 16:14:02 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 752581D636 for <dev@dpdk.org>; Wed, 22 Apr 2020 16:14:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587564841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1KVcofUpl+3QPzFJ3qJ9ljli8REdmbdy1V0ikBuu9Wk=; b=B9UMh5XmgFp1gtNfH3FxyBiJHd0m6eu5yrDRieldCVQIN5/xWsu8QyS0v1KH3IZjaeF1G6 KObYb6Si55E+sMyFUA4hk4Bf+BCsdiZ7y95JToaNS2iIcPDrUNtLzOmsbGjmM+cu0js7rA ia5KT6SlIC8lh3mMsd+a7hlDrIRJC+w= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-M0wHbDzZPBqOc4zkIxqVyQ-1; Wed, 22 Apr 2020 10:13:57 -0400 X-MC-Unique: M0wHbDzZPBqOc4zkIxqVyQ-1 Received: by mail-vk1-f199.google.com with SMTP id e69so998900vke.11 for <dev@dpdk.org>; Wed, 22 Apr 2020 07:13:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o4tGV7ukwey7Q4IYQvvd9YEARJ9PxuqwotinrR/xcZY=; b=fqYl31OL/Z1jdcJ3JLBuj+EGXMc5GQ5SVIL+zZ9sWi6niioIafekHFqvSTJsBIHDxN Zt4gXkOIPkOMtU/jF3KADPaMpEF4WksMDTGCUQ9tktNd2nF71l0NiJTrjiUl9ernPbAn 91IHbmuOE8pKm607HZQYcHTmXsDwHhRV0rU3c3LxLJNhJ4YffSy399Lc67POEbVwIEWX OoZLkyBllmlkGuNfW9wnp7/gotXrkD0wtWUaD8Peo71uQeFdBrk2RDSVcGk6HKXNtKaW BDMh95NGVmOXLyjRcclRdRLwGH78dAF3joSFISOFd8po7cTpk59bFSR1y/sfLaWdXqtb D7eQ== X-Gm-Message-State: AGi0PubNRORmuYDMd4h9EkG/8DECCCN6n+7iYerIqSmQchVdGnAEGzuA Gi5srYST9rGJIovXqTBHsa/fMd76E15/JeyaBMNauwk0gdGPMbjIB+SI9nczaqBExKm17HK8Dq3 e/BPCgvOgkna026oswpQ= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr16545001uaj.41.1587564836690; Wed, 22 Apr 2020 07:13:56 -0700 (PDT) X-Google-Smtp-Source: APiQypLc3XmPMI98PkFqV9LGUopryIuGbhntiI3MrnJgblrVJ6otVkpoZCuRAAyOlzQD3TvI/S0NWOBGtYJdkD8Yp8s= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr16544958uaj.41.1587564836336; Wed, 22 Apr 2020 07:13:56 -0700 (PDT) MIME-Version: 1.0 References: <20190613142344.9188-1-nhorman@tuxdriver.com> <20200422135241.57667-1-haiyue.wang@intel.com> <20200422135241.57667-2-haiyue.wang@intel.com> In-Reply-To: <20200422135241.57667-2-haiyue.wang@intel.com> From: David Marchand <david.marchand@redhat.com> Date: Wed, 22 Apr 2020 16:13:45 +0200 Message-ID: <CAJFAV8yhUwq8X3NC9umGZWS_4W2eEr_jeDqAJomX3FoUC88vRQ@mail.gmail.com> To: Haiyue Wang <haiyue.wang@intel.com> Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Bruce Richardson <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Ray Kinsella <mdr@ashroe.eu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 1/1] eal: add internal ABI mark support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Apr 22, 2020 at 3:58 PM Haiyue Wang <haiyue.wang@intel.com> wrote: > > Introduce __rte_internal tag to mark internal ABI function, this kind of > function can't be called by external application. > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> > --- > buildtools/check-internal-syms.sh | 57 +++++++++++++++++++++++++++++ > devtools/check-symbol-change.sh | 7 ++++ > drivers/meson.build | 2 +- > lib/librte_eal/include/rte_compat.h | 13 +++++++ > lib/meson.build | 2 +- > mk/internal/rte.compile-pre.mk | 3 ++ > mk/target/generic/rte.vars.mk | 1 + > 7 files changed, 83 insertions(+), 2 deletions(-) > create mode 100755 buildtools/check-internal-syms.sh I did not enter the details, but I suppose this patch lacks an update on the suppression rules so that INTERNAL versioned symbols are skipped. https://git.dpdk.org/dpdk/tree/devtools/libabigail.abignore --=20 David Marchand