From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0498A0542; Wed, 26 Oct 2022 08:24:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7ACFA40E28; Wed, 26 Oct 2022 08:24:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B9ABC40A7F for ; Wed, 26 Oct 2022 08:24:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666765490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OdM5d88NnxJnG0bnIQc6vVx7brGKQUHxkKOHa1Pp6U8=; b=KRVOGUJ/SJbEhJwgbb1daH6SVgta+SXZa0SFPT4oJ0P5UnbBsa+L2T7jcjJjpEoVllr8kB bXR5Ewu033egbVQJeoW5DMiKpkoPx3Fx+vAWEp+z9mESm5gxFFEObWEXB0MoAfL0TNNVED yf2NXUWc05QZyrUuFbJrD3jclzjZxHw= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-376-944g5TjAP3ybKcCIxUmDwQ-1; Wed, 26 Oct 2022 02:24:46 -0400 X-MC-Unique: 944g5TjAP3ybKcCIxUmDwQ-1 Received: by mail-pg1-f199.google.com with SMTP id t4-20020a635344000000b0045fe7baa222so7479636pgl.13 for ; Tue, 25 Oct 2022 23:24:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OdM5d88NnxJnG0bnIQc6vVx7brGKQUHxkKOHa1Pp6U8=; b=aMbiJujCSfn5xHM3xTZ8dVQyNjUAU9i9M1vR01KBt7gR9HPXBqyTVYcdtCmXZyuuXQ EnDabXq8WAZ2l/hfrfsVYyUsC0RSAmsMjNPi6ycEL6SSyj1WYUQU7Z4kYJQENwXpH4EM u82/v7th6XqF42zbk58yLcy+i3tyxPiKK9ieiGcMEwn1lNgMa2V8xbK+cYczKk5LieAW OMYcUKOr/D4QCx3xvUpemBDQ3YZ1pdSeCHloNb4xOPrfokm5UocBkFoWW8mtRWAI5Q7X ti4P9L2Z94dvSWkJnFFAuqYMz7rm67kqWKkKGsB4P6PP04eT/84olsA95eTCtBPp/WzI eBBg== X-Gm-Message-State: ACrzQf11dN0id8SLrA9qtuJajzIqLcPXA/BAAnTCKtG7wUqo7vgNBA1E f2aSbufSy1v1JmkPAaIk+EJMqmd9I2p4WHNI8hTug7nietzffIZmpTw6vyujTDr6pl7iAb1WCSz kiYPpw3tTzxCyNQZ4zPE= X-Received: by 2002:a17:90a:8b93:b0:20a:bd84:5182 with SMTP id z19-20020a17090a8b9300b0020abd845182mr2534916pjn.161.1666765485338; Tue, 25 Oct 2022 23:24:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4VO40Fld1f8pEak7PKfftned9BHCZ4syrw0iL6qfMuU3s+XktaW4OJbBRNj8x2j2YzVdYB2QAR5k7uy8jlEL4= X-Received: by 2002:a17:90a:8b93:b0:20a:bd84:5182 with SMTP id z19-20020a17090a8b9300b0020abd845182mr2534902pjn.161.1666765485033; Tue, 25 Oct 2022 23:24:45 -0700 (PDT) MIME-Version: 1.0 References: <20221024153706.3117107-1-alialnu@nvidia.com> <20221025101512.3190439-1-alialnu@nvidia.com> In-Reply-To: <20221025101512.3190439-1-alialnu@nvidia.com> From: David Marchand Date: Wed, 26 Oct 2022 08:24:33 +0200 Message-ID: Subject: Re: [PATCH v2] devtools: check for supported git version To: Ali Alnubani Cc: dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 25, 2022 at 12:15 PM Ali Alnubani wrote: > > The script devtools/parse-flow-support.sh uses the git-grep > option (-o, --only-matching), which is only supported from > git version 2.19 and onwards.[1] > > The script now exits early providing a clear message to the user > about the required git version instead of showing the following > error messages multiple times: > error: unknown switch `o' > usage: git grep [] [-e] [...] [[--] ...] > [..] > > [1] https://github.com/git/git/blob/v2.19.0/Documentation/RelNotes/2.19.0.txt > > Signed-off-by: Ali Alnubani > Signed-off-by: Thomas Monjalon I don't have a "non working" git, but the patch lgtm. Acked-by: David Marchand -- David Marchand